Skip to content

Commit 5e7c50d

Browse files
authored
[Resources.OperatingSystem] Replace .NET 6 target with .NET 8 and add .NET Standard 2.0 target (open-telemetry#2169)
1 parent 6f35936 commit 5e7c50d

File tree

4 files changed

+22
-16
lines changed

4 files changed

+22
-16
lines changed

src/OpenTelemetry.Resources.OperatingSystem/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
* Drop support for .NET 6 as this target is no longer supported
6+
and add .NET 8/.NET Standard 2.0 targets.
7+
([#2169](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2169))
8+
59
## 0.1.0-alpha.4
610

711
Released 2024-Sep-09

src/OpenTelemetry.Resources.OperatingSystem/OpenTelemetry.Resources.OperatingSystem.csproj

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,21 @@
22

33
<PropertyGroup>
44
<!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. -->
5-
<TargetFrameworks>net6.0</TargetFrameworks>
5+
<TargetFrameworks>net8.0;$(NetStandardMinimumSupportedVersion)</TargetFrameworks>
66
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);$(NetFrameworkMinimumSupportedVersion)</TargetFrameworks>
7-
<Description>OpenTelemetry Extensions - Operating System Resource Detector for .NET</Description>
7+
<Description>OpenTelemetry Resource Detectors for Operating System.</Description>
88
<MinVerTagPrefix>Resources.OperatingSystem-</MinVerTagPrefix>
99
</PropertyGroup>
1010

11-
<!--Do not run Package Baseline Validation as this package has never released a stable version.
12-
Remove this property once we have released a stable version and add PackageValidationBaselineVersion property.-->
11+
<!-- Do not run Package Baseline Validation as this package has never released a stable version.
12+
Remove this property once we have released a stable version and add PackageValidationBaselineVersion property. -->
1313
<PropertyGroup>
1414
<DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
1515
</PropertyGroup>
1616

1717
<ItemGroup>
1818
<PackageReference Include="OpenTelemetry" Version="$(OpenTelemetryCoreLatestVersion)" />
19+
<PackageReference Include="Microsoft.Win32.Registry" Version="5.0.0" Condition="'$(TargetFrameworkIdentifier)' == '.NETStandard'" />
1920
</ItemGroup>
2021

2122
<ItemGroup>

src/OpenTelemetry.Resources.OperatingSystem/OperatingSystemDetector.cs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
#if NET
4+
#if !NETFRAMEWORK
55
using System.Runtime.InteropServices;
6+
#endif
7+
#if NET
68
using System.Xml.Linq;
79
#endif
8-
910
using static OpenTelemetry.Resources.OperatingSystem.OperatingSystemSemanticConventions;
1011

1112
namespace OpenTelemetry.Resources.OperatingSystem;
@@ -18,16 +19,16 @@ internal sealed class OperatingSystemDetector : IResourceDetector
1819
private const string RegistryKey = @"SOFTWARE\Microsoft\Windows NT\CurrentVersion";
1920
private const string KernelOsRelease = "/proc/sys/kernel/osrelease";
2021
private static readonly string[] DefaultEtcOsReleasePaths =
21-
[
22-
"/etc/os-release",
23-
"/usr/lib/os-release"
24-
];
22+
[
23+
"/etc/os-release",
24+
"/usr/lib/os-release"
25+
];
2526

2627
private static readonly string[] DefaultPlistFilePaths =
27-
[
28-
"/System/Library/CoreServices/SystemVersion.plist",
29-
"/System/Library/CoreServices/ServerVersion.plist"
30-
];
28+
[
29+
"/System/Library/CoreServices/SystemVersion.plist",
30+
"/System/Library/CoreServices/ServerVersion.plist"
31+
];
3132

3233
private readonly string? osType;
3334
private readonly string? registryKey;

test/OpenTelemetry.Resources.OperatingSystem.Tests/OpenTelemetry.Resources.OperatingSystem.Tests.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<Description>Unit test project for Operating System Detector for OpenTelemetry</Description>
54
<!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. -->
6-
<TargetFrameworks>$(SupportedNetTargets)</TargetFrameworks>
5+
<TargetFrameworks>$(SupportedNetTargetsWithoutNet6)</TargetFrameworks>
76
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);$(NetFrameworkMinimumSupportedVersion)</TargetFrameworks>
7+
<Description>Unit test project for Operating System Detector for OpenTelemetry.</Description>
88
</PropertyGroup>
99

1010
<ItemGroup>

0 commit comments

Comments
 (0)