Skip to content

Commit 9bf9188

Browse files
[Instrumentation.EntityFrameworkCore] Add case for providerName when Devart Oracle is used (open-telemetry#2465)
Co-authored-by: Piotr Kiełkowicz <[email protected]>
1 parent 305475c commit 9bf9188

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
* Updated OpenTelemetry core component version(s) to `1.11.0`.
66
([#2470](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2470))
77

8+
* Attribute `db.system` reports `oracle` when
9+
`Devart.Data.Oracle.Entity.EFCore` is used a provider.
10+
([#2465](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2465))
11+
812
## 1.10.0-beta.1
913

1014
Released 2024-Dec-09

src/OpenTelemetry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ public override void OnEventWritten(string name, object? payload)
107107
break;
108108
case "Oracle.EntityFrameworkCore":
109109
case "Devart.Data.Oracle.EFCore":
110+
case "Devart.Data.Oracle.Entity.EFCore":
110111
activity.AddTag(AttributeDbSystem, "oracle");
111112
break;
112113
case "Microsoft.EntityFrameworkCore.InMemory":

test/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/EntityFrameworkDiagnosticListenerTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,7 @@ public void ShouldCollectTelemetryWhenFilterEvaluatesToTrueByDbCommand()
200200
[InlineData("Devart.Data.PostgreSql.EFCore")]
201201
[InlineData("Oracle.EntityFrameworkCore")]
202202
[InlineData("Devart.Data.Oracle.EFCore")]
203+
[InlineData("Devart.Data.Oracle.Entity.EFCore")]
203204
[InlineData("Microsoft.EntityFrameworkCore.InMemory")]
204205
[InlineData("FirebirdSql.EntityFrameworkCore.Firebird")]
205206
[InlineData("FileContextCore")]

0 commit comments

Comments
 (0)