Skip to content

Commit d8643cb

Browse files
[Instrumentation.StackExchangeRedis] Replace .NET 6 target with .NET 8 (open-telemetry#2160)
Co-authored-by: joegoldman2 <[email protected]> Co-authored-by: Mikel Blanchard <[email protected]>
1 parent 0decdac commit d8643cb

File tree

7 files changed

+17
-12
lines changed

7 files changed

+17
-12
lines changed

.github/workflows/integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
version: [net6.0, net8.0]
17+
version: [net8.0]
1818
steps:
1919
- uses: actions/checkout@v4
2020

src/OpenTelemetry.Instrumentation.StackExchangeRedis/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## Unreleased
44

5+
* Drop support for .NET 6 as this target is no longer supported and add .NET 8 target.
6+
([#2160](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2160))
7+
58
## 1.9.0-beta.1
69

710
Released 2024-Jul-23

src/OpenTelemetry.Instrumentation.StackExchangeRedis/OpenTelemetry.Instrumentation.StackExchangeRedis.csproj

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2+
23
<PropertyGroup>
34
<!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. -->
4-
<TargetFrameworks>net6.0;netstandard2.0;net462</TargetFrameworks>
5-
<Description>StackExchange.Redis instrumentation for OpenTelemetry .NET</Description>
5+
<TargetFrameworks>net8.0;$(NetStandardMinimumSupportedVersion);$(NetFrameworkMinimumSupportedVersion)</TargetFrameworks>
6+
<Description>StackExchange.Redis instrumentation for OpenTelemetry .NET.</Description>
67
<PackageTags>$(PackageTags);distributed-tracing;Redis;StackExchange.Redis</PackageTags>
78
<MinVerTagPrefix>Instrumentation.StackExchangeRedis-</MinVerTagPrefix>
89
</PropertyGroup>
910

10-
<!--Do not run Package Baseline Validation as this package has never released a stable version.
11-
Remove this property once we have released a stable version and add PackageValidationBaselineVersion property.-->
11+
<!-- Do not run Package Baseline Validation as this package has never released a stable version.
12+
Remove this property once we have released a stable version and add PackageValidationBaselineVersion property. -->
1213
<PropertyGroup>
1314
<DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
1415
</PropertyGroup>

test/OpenTelemetry.Instrumentation.Cassandra.Tests/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ ARG PUBLISH_FRAMEWORK=net8.0
1111
WORKDIR /repo
1212
COPY . ./
1313
WORKDIR "/repo/test/OpenTelemetry.Instrumentation.Cassandra.Tests"
14-
RUN dotnet publish "OpenTelemetry.Instrumentation.Cassandra.Tests.csproj" -c "${PUBLISH_CONFIGURATION}" -f "${PUBLISH_FRAMEWORK}" -o /drop -p:IntegrationBuild=true -p:TARGET_FRAMEWORK=${PUBLISH_FRAMEWORK}
14+
RUN dotnet publish "OpenTelemetry.Instrumentation.Cassandra.Tests.csproj" -c "${PUBLISH_CONFIGURATION}" -f "${PUBLISH_FRAMEWORK}" -o /drop -p:IntegrationBuild=true
1515

1616
FROM mcr.microsoft.com/dotnet/sdk:${TEST_SDK_VERSION} AS final
1717
WORKDIR /test

test/OpenTelemetry.Instrumentation.ConfluentKafka.Tests/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ ARG PUBLISH_FRAMEWORK=net8.0
1111
WORKDIR /repo
1212
COPY . ./
1313
WORKDIR "/repo/test/OpenTelemetry.Instrumentation.ConfluentKafka.Tests"
14-
RUN dotnet publish "OpenTelemetry.Instrumentation.ConfluentKafka.Tests.csproj" -c "${PUBLISH_CONFIGURATION}" -f "${PUBLISH_FRAMEWORK}" -o /drop -p:IntegrationBuild=true -p:TARGET_FRAMEWORK=${PUBLISH_FRAMEWORK}
14+
RUN dotnet publish "OpenTelemetry.Instrumentation.ConfluentKafka.Tests.csproj" -c "${PUBLISH_CONFIGURATION}" -f "${PUBLISH_FRAMEWORK}" -o /drop -p:IntegrationBuild=true
1515

1616
FROM mcr.microsoft.com/dotnet/sdk:${TEST_SDK_VERSION} AS final
1717
WORKDIR /test

test/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ ARG PUBLISH_FRAMEWORK=net8.0
1111
WORKDIR /repo
1212
COPY . ./
1313
WORKDIR "/repo/test/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests"
14-
RUN dotnet publish "OpenTelemetry.Instrumentation.StackExchangeRedis.Tests.csproj" -c "${PUBLISH_CONFIGURATION}" -f "${PUBLISH_FRAMEWORK}" -o /drop -p:IntegrationBuild=true -p:TARGET_FRAMEWORK=${PUBLISH_FRAMEWORK}
14+
RUN dotnet publish "OpenTelemetry.Instrumentation.StackExchangeRedis.Tests.csproj" -c "${PUBLISH_CONFIGURATION}" -f "${PUBLISH_FRAMEWORK}" -o /drop -p:IntegrationBuild=true
1515

1616
FROM mcr.microsoft.com/dotnet/sdk:${TEST_SDK_VERSION} AS final
1717
WORKDIR /test

test/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests.csproj

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2+
23
<PropertyGroup>
3-
<Description>Unit test project for OpenTelemetry StackExchangeRedis instrumentation</Description>
44
<!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. -->
5-
<TargetFrameworks Condition="$(TARGET_FRAMEWORK) == ''">$(SupportedNetTargets)</TargetFrameworks>
6-
<TargetFrameworks Condition="$(TARGET_FRAMEWORK) == '' and $(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
7-
<TargetFrameworks Condition="$(TARGET_FRAMEWORK) != ''">$(TARGET_FRAMEWORK)</TargetFrameworks>
5+
<TargetFrameworks>$(SupportedNetTargetsWithoutNet6)</TargetFrameworks>
6+
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);$(NetFrameworkMinimumSupportedVersion)</TargetFrameworks>
7+
<Description>Unit test project for OpenTelemetry StackExchangeRedis instrumentation.</Description>
88
</PropertyGroup>
99

1010
<ItemGroup>
@@ -24,4 +24,5 @@
2424
<!-- System.Text.Json is indirect reference. It is needed to upgrade it directly to avoid https://github.com/advisories/GHSA-hh2w-p6rv-4g7w -->
2525
<PackageReference Include="System.Text.Json" Version="8.0.4" />
2626
</ItemGroup>
27+
2728
</Project>

0 commit comments

Comments
 (0)