Skip to content

Commit e6d42c0

Browse files
authored
[Instrumentation.EntityFrameworkCore] Fix db.system for Devart packages (open-telemetry#2571)
1 parent 1f43e10 commit e6d42c0

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

src/OpenTelemetry.Instrumentation.EntityFrameworkCore/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
## Unreleased
44

5+
* Fixed attribute `db.system` for following providers:
6+
* `Devart.Data.SQLite.Entity.EFCore`,
7+
* `Devart.Data.MySql.Entity.EFCore`,
8+
* `Devart.Data.PostgreSql.Entity.EFCore`.
9+
([#2571](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2571))
10+
511
## 1.11.0-beta.1
612

713
Released 2025-Jan-27

src/OpenTelemetry.Instrumentation.EntityFrameworkCore/Implementation/EntityFrameworkDiagnosticListener.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,20 +93,19 @@ public override void OnEventWritten(string name, object? payload)
9393
activity.AddTag(AttributeDbSystem, "cosmosdb");
9494
break;
9595
case "Microsoft.EntityFrameworkCore.Sqlite":
96-
case "Devart.Data.SQLite.EFCore":
96+
case "Devart.Data.SQLite.Entity.EFCore":
9797
activity.AddTag(AttributeDbSystem, "sqlite");
9898
break;
9999
case "MySql.Data.EntityFrameworkCore":
100100
case "Pomelo.EntityFrameworkCore.MySql":
101-
case "Devart.Data.MySql.EFCore":
101+
case "Devart.Data.MySql.Entity.EFCore":
102102
activity.AddTag(AttributeDbSystem, "mysql");
103103
break;
104104
case "Npgsql.EntityFrameworkCore.PostgreSQL":
105-
case "Devart.Data.PostgreSql.EFCore":
105+
case "Devart.Data.PostgreSql.Entity.EFCore":
106106
activity.AddTag(AttributeDbSystem, "postgresql");
107107
break;
108108
case "Oracle.EntityFrameworkCore":
109-
case "Devart.Data.Oracle.EFCore":
110109
case "Devart.Data.Oracle.Entity.EFCore":
111110
activity.AddTag(AttributeDbSystem, "oracle");
112111
break;

test/OpenTelemetry.Instrumentation.EntityFrameworkCore.Tests/EntityFrameworkDiagnosticListenerTests.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,14 +192,13 @@ public void ShouldCollectTelemetryWhenFilterEvaluatesToTrueByDbCommand()
192192
[Theory]
193193
[InlineData("Microsoft.EntityFrameworkCore.SqlServer")]
194194
[InlineData("Microsoft.EntityFrameworkCore.Cosmos")]
195-
[InlineData("Devart.Data.SQLite.EFCore")]
195+
[InlineData("Devart.Data.SQLite.Entity.EFCore")]
196196
[InlineData("MySql.Data.EntityFrameworkCore")]
197197
[InlineData("Pomelo.EntityFrameworkCore.MySql")]
198-
[InlineData("Devart.Data.MySql.EFCore")]
198+
[InlineData("Devart.Data.MySql.Entity.EFCore")]
199199
[InlineData("Npgsql.EntityFrameworkCore.PostgreSQL")]
200-
[InlineData("Devart.Data.PostgreSql.EFCore")]
200+
[InlineData("Devart.Data.PostgreSql.Entity.EFCore")]
201201
[InlineData("Oracle.EntityFrameworkCore")]
202-
[InlineData("Devart.Data.Oracle.EFCore")]
203202
[InlineData("Devart.Data.Oracle.Entity.EFCore")]
204203
[InlineData("Microsoft.EntityFrameworkCore.InMemory")]
205204
[InlineData("FirebirdSql.EntityFrameworkCore.Firebird")]

0 commit comments

Comments
 (0)