[geneva] Remove remaining project-level warning suppressions and update code to be compliant (open-telemetry#2063)

Author: CodeBlanch

src/OpenTelemetry.Exporter.Geneva/GenevaExporterHelperExtensions.cs

@@ -91,7 +91,10 @@ public static TracerProviderBuilder AddGenevaTraceExporter(this TracerProviderBu
 
     private static BaseProcessor<Activity> BuildGenevaTraceExporter(GenevaExporterOptions options, BatchExportActivityProcessorOptions batchActivityExportProcessor)
     {
+#pragma warning disable CA2000 // Dispose objects before losing scope
         var exporter = new GenevaTraceExporter(options);
+#pragma warning restore CA2000 // Dispose objects before losing scope
+
         if (exporter.IsUsingUnixDomainSocket)
         {
             return new BatchActivityExportProcessor(

src/OpenTelemetry.Exporter.Geneva/GenevaLogExporter.cs

@@ -61,7 +61,7 @@ public GenevaLogExporter(GenevaExporterOptions options)
                 break;
 
             default:
-                throw new ArgumentOutOfRangeException(nameof(connectionStringBuilder.Protocol));
+                throw new NotSupportedException($"Protocol '{connectionStringBuilder.Protocol}' is not supported");
         }
 
         if (useMsgPackExporter)

src/OpenTelemetry.Exporter.Geneva/GenevaLoggingExtensions.cs

@@ -30,14 +30,18 @@ public static OpenTelemetryLoggerOptions AddGenevaLogExporter(
 
         var genevaOptions = new GenevaExporterOptions();
         configure?.Invoke(genevaOptions);
+
+#pragma warning disable CA2000 // Dispose objects before losing scope
         var exporter = new GenevaLogExporter(genevaOptions);
+#pragma warning restore CA2000 // Dispose objects before losing scope
+
         if (exporter.IsUsingUnixDomainSocket)
         {
-            return options.AddProcessor(new BatchLogRecordExportProcessor(exporter));
+            return options.AddProcessor(sp => new BatchLogRecordExportProcessor(exporter));
         }
         else
         {
-            return options.AddProcessor(new ReentrantExportProcessor<LogRecord>(exporter));
+            return options.AddProcessor(sp => new ReentrantExportProcessor<LogRecord>(exporter));
         }
     }
 
@@ -123,7 +127,10 @@ internal static BaseProcessor<LogRecord> BuildGenevaLogExporter(
     {
         Debug.Assert(exporterOptions != null, "exporterOptions was null");
 
+#pragma warning disable CA2000 // Dispose objects before losing scope
         var exporter = new GenevaLogExporter(exporterOptions);
+#pragma warning restore CA2000 // Dispose objects before losing scope
+
         if (exporter.IsUsingUnixDomainSocket)
         {
             return new BatchLogRecordExportProcessor(

src/OpenTelemetry.Exporter.Geneva/GenevaTraceExporter.cs

@@ -61,7 +61,7 @@ public GenevaTraceExporter(GenevaExporterOptions options)
                 break;
 
             default:
-                throw new ArgumentOutOfRangeException(nameof(connectionStringBuilder.Protocol));
+                throw new NotSupportedException($"Protocol '{connectionStringBuilder.Protocol}' is not supported");
         }
 
         if (useMsgPackExporter)

src/OpenTelemetry.Exporter.Geneva/Internal/ReentrantExportProcessor.cs

@@ -14,16 +14,7 @@ namespace OpenTelemetry.Exporter.Geneva;
 internal class ReentrantExportProcessor<T> : BaseExportProcessor<T>
     where T : class
 {
-    private static readonly Func<T, Batch<T>> CreateBatch;
-
-    static ReentrantExportProcessor()
-    {
-        var flags = BindingFlags.Instance | BindingFlags.NonPublic;
-        var ctor = typeof(Batch<T>).GetConstructor(flags, null, new Type[] { typeof(T) }, null);
-        var value = Expression.Parameter(typeof(T), null);
-        var lambda = Expression.Lambda<Func<T, Batch<T>>>(Expression.New(ctor, value), value);
-        CreateBatch = lambda.Compile();
-    }
+    private static readonly Func<T, Batch<T>> CreateBatch = BuildCreateBatchDelegate();
 
     public ReentrantExportProcessor(BaseExporter<T> exporter)
         : base(exporter)
@@ -34,4 +25,13 @@ protected override void OnExport(T data)
     {
         this.exporter.Export(CreateBatch(data));
     }
+
+    private static Func<T, Batch<T>> BuildCreateBatchDelegate()
+    {
+        var flags = BindingFlags.Instance | BindingFlags.NonPublic;
+        var ctor = typeof(Batch<T>).GetConstructor(flags, null, new Type[] { typeof(T) }, null);
+        var value = Expression.Parameter(typeof(T), null);
+        var lambda = Expression.Lambda<Func<T, Batch<T>>>(Expression.New(ctor, value), value);
+        return lambda.Compile();
+    }
 }

src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporterExtensions.cs

@@ -59,7 +59,16 @@ public static MeterProviderBuilder AddGenevaMetricExporter(this MeterProviderBui
     private static PeriodicExportingMetricReader BuildGenevaMetricExporter(GenevaMetricExporterOptions options, Action<GenevaMetricExporterOptions> configure = null)
     {
         configure?.Invoke(options);
-        return new PeriodicExportingMetricReader(new GenevaMetricExporter(options), options.MetricExportIntervalMilliseconds)
-        { TemporalityPreference = MetricReaderTemporalityPreference.Delta };
+
+#pragma warning disable CA2000 // Dispose objects before losing scope
+        var exporter = new GenevaMetricExporter(options);
+#pragma warning restore CA2000 // Dispose objects before losing scope
+
+        return new PeriodicExportingMetricReader(
+            exporter,
+            options.MetricExportIntervalMilliseconds)
+        {
+            TemporalityPreference = MetricReaderTemporalityPreference.Delta,
+        };
     }
 }

src/OpenTelemetry.Exporter.Geneva/Metrics/TlvMetricExporter.cs

@@ -57,7 +57,7 @@ internal TlvMetricExporter(ConnectionStringBuilder connectionStringBuilder, IRea
                 }
 
             default:
-                throw new ArgumentOutOfRangeException(nameof(connectionStringBuilder.Protocol));
+                throw new NotSupportedException($"Protocol '{connectionStringBuilder.Protocol}' is not supported");
         }
 
         unsafe

src/OpenTelemetry.Exporter.Geneva/Metrics/Transport/MetricEtwDataTransport.cs

@@ -61,6 +61,8 @@ public unsafe void SendOtlpProtobufEvent(byte[] data, int size)
         }
     }
 
+#pragma warning disable CA1822 // Mark members as static
+
     [Event(OtlpProtobufMetricEventId)]
     public void OtlpProtobufEvent()
     {
@@ -86,6 +88,8 @@ public void TLVMetricEvent()
     {
     }
 
+#pragma warning restore CA1822 // Mark members as static
+
     protected override void Dispose(bool disposing)
     {
         if (this.isDisposed)

src/OpenTelemetry.Exporter.Geneva/MsgPackExporter/MsgPackLogExporter.cs

@@ -75,7 +75,7 @@ public MsgPackLogExporter(GenevaExporterOptions options)
                 this.dataTransport = new UnixDomainSocketDataTransport(unixDomainSocketPath);
                 break;
             default:
-                throw new ArgumentOutOfRangeException(nameof(connectionStringBuilder.Protocol));
+                throw new NotSupportedException($"Protocol '{connectionStringBuilder.Protocol}' is not supported");
         }
 
         if (options.PrepopulatedFields != null)

src/OpenTelemetry.Exporter.Geneva/MsgPackExporter/MsgPackTraceExporter.cs

@@ -92,7 +92,7 @@ public MsgPackTraceExporter(GenevaExporterOptions options)
                 this.dataTransport = new UnixDomainSocketDataTransport(unixDomainSocketPath);
                 break;
             default:
-                throw new ArgumentOutOfRangeException(nameof(connectionStringBuilder.Protocol));
+                throw new NotSupportedException($"Protocol '{connectionStringBuilder.Protocol}' is not supported");
         }
 
         // TODO: Validate custom fields (reserved name? etc).