Skip to content

Commit dc8d3fd

Browse files
xiang17Kielek
andauthored
[repo] Add .NET 8 target for W3C Trace Context Integration Test in CI (open-telemetry#5800)
Co-authored-by: Piotr Kiełkowicz <[email protected]>
1 parent 1479686 commit dc8d3fd

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ jobs:
129129
strategy:
130130
fail-fast: false
131131
matrix:
132-
version: [ net6.0 ]
132+
version: [ net6.0, net8.0 ]
133133
steps:
134134
- uses: actions/checkout@v4
135135
- name: Run W3C Trace Context docker compose

test/OpenTelemetry.Instrumentation.W3cTraceContext.Tests/Dockerfile

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ COPY --from=w3c /w3c .
2626
RUN apt-get update \
2727
&& apt-get install -y python3-pip python3-dev \
2828
&& cd /usr/local/bin \
29-
&& ln -s /usr/bin/python3 python \
30-
&& pip3 install --upgrade pip \
31-
&& pip3 install aiohttp
29+
&& ln -s /usr/bin/python3 python
30+
31+
# net6.0 image uses Python 3.9, which doesn't have `--break-system-packages` option.
32+
RUN pip3 install --upgrade pip --break-system-packages || pip3 install --upgrade pip
33+
RUN pip3 install aiohttp --break-system-packages
3234
ENTRYPOINT ["dotnet", "vstest", "OpenTelemetry.Instrumentation.W3cTraceContext.Tests.dll", "--logger:console;verbosity=detailed"]

test/OpenTelemetry.Instrumentation.W3cTraceContext.Tests/W3CTraceContextTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public void W3CTraceContextTestSuiteAsync(string value)
6969
return result;
7070
});
7171

72-
app.RunAsync();
72+
app.RunAsync("http://localhost:5000/");
7373

7474
string result = RunCommand("python", "trace-context/test/test.py http://localhost:5000/");
7575

0 commit comments

Comments
 (0)