Skip to content

Commit be8580e

Browse files
feat: add null support to adaptive array builders (open-telemetry#583)
Part of open-telemetry#534 Support adding nulls to adaptive array builders. This PR also fixes all the "unused" clippy warnings. Originally this module had `#[allow(unused)]` on it to avoid unused code clippy warnings until this was integrated with code to encode OTAP. It _should_ have had `#[allow(dead_code)]`, because `unused` also controls clippy warnings for unused imports and unused results, which we don't want. After the next release of arrow, I'll come back and clean up the `append_nulls` method in a few places where we're using loops when we should just be able to call `append_nulls` on the underlying builder. Some arrow builders don't support this in the current version, but was added here: apache/arrow-rs#7606 Co-authored-by: Laurent Quérel <l.querel@f5.com>
1 parent 73679e3 commit be8580e

File tree

9 files changed

+577
-127
lines changed

9 files changed

+577
-127
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
// TODO remove allow(unused) when we use what's in this module to encode OTAP
5-
#[allow(unused)]
4+
// TODO remove allow(dead_code) when we use what's in this module to encode OTAP
5+
#[allow(dead_code)]
66
mod array;

0 commit comments

Comments
 (0)