Skip to content

Commit c691958

Browse files
committed
slightly improved tests by using InvariantCulture for comparison
1 parent f6283fb commit c691958

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

tests/SharedParameterFileTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ static SharedParameterFileTests()
3030
[Fact]
3131
public void ValidFilesPassValidation()
3232
{
33-
Assert.All(SharedParameterFiles.Where(f => f.StartsWith(PathToValidFiles)),
33+
Assert.All(SharedParameterFiles.Where(f => f.StartsWith(PathToValidFiles, StringComparison.InvariantCulture)),
3434
sharedParamFilePath =>
3535
{
3636
var sharedParamFile = new SharedParameterFile(sharedParamFilePath);
@@ -45,7 +45,7 @@ public void ValidFilesPassValidation()
4545
[Fact]
4646
public void InvalidFilesFailValidation()
4747
{
48-
Assert.All(SharedParameterFiles.Where(f => f.StartsWith(PathToInvalidFiles)),
48+
Assert.All(SharedParameterFiles.Where(f => f.StartsWith(PathToInvalidFiles, StringComparison.InvariantCulture)),
4949
sharedParamFilePath =>
5050
{
5151
var sharedParamFile = new SharedParameterFile(sharedParamFilePath);
@@ -184,7 +184,7 @@ public void GroupsAreParsedCorrectly()
184184
[Fact]
185185
public void ClonedAndRandomizedFilesAreEqual()
186186
{
187-
Assert.All(SharedParameterFiles.Where(f => f.StartsWith(PathToValidFiles)),
187+
Assert.All(SharedParameterFiles.Where(f => f.StartsWith(PathToValidFiles, StringComparison.InvariantCulture)),
188188
sharedParamFilePath =>
189189
{
190190
var sharedParamFile1 = new SharedParameterFile(sharedParamFilePath);
@@ -200,7 +200,7 @@ public void ClonedAndRandomizedFilesAreEqual()
200200
[Fact]
201201
public void ToStringOutputCopyIsEqual()
202202
{
203-
Assert.All(SharedParameterFiles.Where(f => f.StartsWith(PathToValidFiles)),
203+
Assert.All(SharedParameterFiles.Where(f => f.StartsWith(PathToValidFiles, StringComparison.InvariantCulture)),
204204
sharedParamFilePath =>
205205
{
206206
var sharedParamFile1 = new SharedParameterFile(sharedParamFilePath);
@@ -218,7 +218,7 @@ public void ToStringOutputCopyIsEqual()
218218
public void FileIsSerializedProperly()
219219
{
220220
var simpleSharedFromDisk = File
221-
.ReadAllText(SharedParameterFiles.FirstOrDefault(f => f.EndsWith(@"SimpleShared_1.txt")));
221+
.ReadAllText(SharedParameterFiles.FirstOrDefault(f => f.EndsWith(@"SimpleShared_1.txt", StringComparison.InvariantCulture)));
222222

223223
var simpleSharedFromBuilt = new SharedParameterFile(new Dictionary<string,int> { { "Identity Data", 100 } } );
224224

tests/TypeCatalogFileTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ static TypeCatalogFileTests()
2727
[Fact]
2828
public void CheckIfNumberOfParametersIsCorrect()
2929
{
30-
Assert.All(CatalogTypeFiles.Where(f => f.StartsWith(PathToValidFiles)),
30+
Assert.All(CatalogTypeFiles.Where(f => f.StartsWith(PathToValidFiles, StringComparison.InvariantCulture)),
3131
catalogTypeFilePath =>
3232
{
3333
var catalogTypeFile = new TypeCatalogFile(catalogTypeFilePath);
@@ -40,7 +40,7 @@ public void CheckIfNumberOfParametersIsCorrect()
4040
[Fact]
4141
public void CheckIfNumberOfTypesIsCorrect()
4242
{
43-
Assert.All(CatalogTypeFiles.Where(f => f.StartsWith(PathToValidFiles)),
43+
Assert.All(CatalogTypeFiles.Where(f => f.StartsWith(PathToValidFiles, StringComparison.InvariantCulture)),
4444
catalogTypeFilePath =>
4545
{
4646
var catalogTypeFile = new TypeCatalogFile(catalogTypeFilePath);
@@ -95,7 +95,7 @@ public void iPhoneCatalogReadAndBuiltAreEqual()
9595
var catalogTypeFileFromBuilt = catalogTypeFile.ToString();
9696
Assert.True(!string.IsNullOrWhiteSpace(catalogTypeFileFromBuilt));
9797

98-
var iPhoneCatalogFilePath = CatalogTypeFiles.FirstOrDefault(f => f.EndsWith(@"iPhone6.txt"));
98+
var iPhoneCatalogFilePath = CatalogTypeFiles.FirstOrDefault(f => f.EndsWith(@"iPhone6.txt", StringComparison.InvariantCulture));
9999
var iPhoneCatalogFromDisk = File.ReadAllText(iPhoneCatalogFilePath);
100100
Assert.True(File.Exists(iPhoneCatalogFilePath) && !string.IsNullOrWhiteSpace(iPhoneCatalogFromDisk));
101101

0 commit comments

Comments
 (0)