features: Drop no-assert-string in favour of deku_error!() behaviour

The deku_error!() macro will discard dynamic formatting when it's
unavailable due to feature selection.

Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

Author: amboar

Cargo.toml

@@ -24,7 +24,6 @@ default = ["std", "bits"]
 std = ["deku_derive/std", "bitvec?/std", "alloc", "no_std_io/std"]
 alloc = ["bitvec?/alloc", "deku_derive/alloc", "no_std_io/alloc" ]
 logging = ["deku_derive/logging", "log"]
-no-assert-string = ["deku_derive/no-assert-string"]
 bits = ["dep:bitvec", "deku_derive/bits", "alloc" ]
 
 [dependencies]

deku-derive/Cargo.toml

@@ -16,7 +16,6 @@ proc-macro = true
 std = ["proc-macro-crate", "alloc"]
 alloc = []
 logging = []
-no-assert-string = []
 bits = []
 
 [dependencies]

deku-derive/src/macros/mod.rs

@@ -417,13 +417,6 @@ fn assertion_failed(
     } else {
         quote! { stringify!(#v) }
     };
-    #[cfg(feature = "no-assert-string")]
-    {
-        quote! {
-            return Err(::#crate_::DekuError::AssertionNoStr);
-        }
-    }
-    #[cfg(not(feature = "no-assert-string"))]
     {
         quote! {
             return Err(::#crate_::deku_error!(::#crate_::DekuError::Assertion, "Field failed assertion", "{}.{}: {}", #ident, #field_ident_str, #stringify));

src/error.rs

@@ -49,8 +49,6 @@ pub enum DekuError {
     InvalidParam(DekuErrorString),
     /// Assertion error from `assert` or `assert_eq` attributes
     Assertion(DekuErrorString),
-    /// Assertion error from `assert` or `assert_eq` attributes, without string
-    AssertionNoStr,
     /// Could not resolve `id` for variant
     IdVariantNotFound,
     /// IO error while reading or writing
@@ -158,8 +156,7 @@ impl core::fmt::Display for DekuError {
             ),
             DekuError::Parse(ref err) => write!(f, "Parse error: {err}"),
             DekuError::InvalidParam(ref err) => write!(f, "Invalid param error: {err}"),
-            DekuError::Assertion(ref err) => write!(f, "Assertion error: {err}"),
-            DekuError::AssertionNoStr => write!(f, "Assertion error"),
+            DekuError::Assertion(ref err) => write!(f, "{err}"),
             DekuError::IdVariantNotFound => write!(f, "Could not resolve `id` for variant"),
             DekuError::Io(ref e) => write!(f, "io errorr: {e:?}"),
         }
@@ -182,7 +179,6 @@ impl From<DekuError> for std::io::Error {
             DekuError::Parse(_) => io::Error::new(io::ErrorKind::InvalidData, error),
             DekuError::InvalidParam(_) => io::Error::new(io::ErrorKind::InvalidInput, error),
             DekuError::Assertion(_) => io::Error::new(io::ErrorKind::InvalidData, error),
-            DekuError::AssertionNoStr => io::Error::from(io::ErrorKind::InvalidData),
             DekuError::IdVariantNotFound => io::Error::new(io::ErrorKind::NotFound, error),
             DekuError::Io(e) => io::Error::new(e, error),
         }