* Make use of CompletableFuture

* Make use of Lambda expressions
* Refactoring
* Bump Android requirements

Author: CodeDead

app/build.gradle

@@ -5,7 +5,7 @@ android {
     buildToolsVersion '29.0.3'
     defaultConfig {
         applicationId "com.codedead.deadhash"
-        minSdkVersion 21
+        minSdkVersion 24
         targetSdkVersion 30
         versionName '1.7.3'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
@@ -19,17 +19,21 @@ android {
     }
     productFlavors {
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_1_8
+        targetCompatibility JavaVersion.VERSION_1_8
+    }
 }
 
 dependencies {
     implementation fileTree(include: ['*.jar'], dir: 'libs')
-    androidTestImplementation('androidx.test.espresso:espresso-core:3.2.0', {
+    androidTestImplementation('androidx.test.espresso:espresso-core:3.3.0', {
         exclude group: 'com.android.support', module: 'support-annotations'
     })
     implementation 'androidx.appcompat:appcompat:1.2.0'
     implementation 'com.google.android.material:material:1.2.1'
     implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
-    testImplementation 'junit:junit:4.12'
+    testImplementation 'junit:junit:4.13.1'
     implementation 'androidx.cardview:cardview:1.0.0'
     implementation "androidx.preference:preference:1.1.1"
 }

app/src/main/java/com/codedead/deadhash/domain/interfaces/hashgenerator/IHashResponse.java

@@ -1,8 +1,5 @@
 package com.codedead.deadhash.domain.objects.hashgenerator;
 
-import android.os.AsyncTask;
-
-import com.codedead.deadhash.domain.interfaces.hashgenerator.IHashResponse;
 import com.codedead.deadhash.domain.utils.HashUtil;
 
 import java.io.File;
@@ -11,23 +8,21 @@
 import java.util.ArrayList;
 import java.util.List;
 
-public abstract class HashGenerator extends AsyncTask<Void, Void, List<HashData>> {
+public final class HashGenerator {
 
     private final byte[] data;
     private final List<HashAlgorithm> hashAlgorithms;
     private final List<HashData> hashData;
     private final String compare;
 
-    public IHashResponse hashResponse = null;
-
     /**
      * Initialize a new HashGenerator
      *
      * @param data           The byte array that should be hashed
      * @param hashAlgorithms The List of HashingAlgorithm enums that should be used to calculate hashes
      * @param compare        The compare String for the calculated hashes
      */
-    HashGenerator(final byte[] data, final List<HashAlgorithm> hashAlgorithms, final String compare) {
+    public HashGenerator(final byte[] data, final List<HashAlgorithm> hashAlgorithms, final String compare) {
         hashData = new ArrayList<>();
         this.data = data;
 
@@ -43,7 +38,7 @@ public abstract class HashGenerator extends AsyncTask<Void, Void, List<HashData>
      * @param compare        The compare String for the calculated hashes
      * @throws IOException When the File could not be read
      */
-    HashGenerator(final File data, final List<HashAlgorithm> hashAlgorithms, final String compare) throws IOException {
+    public HashGenerator(final File data, final List<HashAlgorithm> hashAlgorithms, final String compare) throws IOException {
         hashData = new ArrayList<>();
         this.data = readFileToBytes(data);
         this.hashAlgorithms = hashAlgorithms;
@@ -76,8 +71,11 @@ private byte[] readFileToBytes(final File file) throws IOException {
         return bytes;
     }
 
-    @Override
-    protected List<HashData> doInBackground(Void... params) {
+    /**
+     * Generate the List of HashData for the given input data
+     * @return The List of HashData for the given input data
+     */
+    public final List<HashData> generateHashes() {
         for (final HashAlgorithm algorithm : hashAlgorithms) {
             switch (algorithm) {
                 case md5:

app/src/main/java/com/codedead/deadhash/domain/objects/hashgenerator/FileHashGenerator.java

@@ -74,15 +74,12 @@ static class DataHolder extends RecyclerView.ViewHolder implements View.OnClickL
             final ImageButton copyData = v.findViewById(R.id.Copy_Data);
 
             copyData.setOnClickListener(this);
-            compareData.setOnClickListener(new View.OnClickListener() {
-                @Override
-                public void onClick(final View v) {
-                    if (originalCompare == null || originalCompare.length() == 0) return;
-                    if (originalCompare.equals(encryptionData.getText().toString())) {
-                        Toast.makeText(v.getContext(), R.string.toast_hash_match, Toast.LENGTH_SHORT).show();
-                    } else {
-                        Toast.makeText(v.getContext(), R.string.toast_hash_mismatch, Toast.LENGTH_SHORT).show();
-                    }
+            compareData.setOnClickListener(v1 -> {
+                if (originalCompare == null || originalCompare.length() == 0) return;
+                if (originalCompare.equals(encryptionData.getText().toString())) {
+                    Toast.makeText(v1.getContext(), R.string.toast_hash_match, Toast.LENGTH_SHORT).show();
+                } else {
+                    Toast.makeText(v1.getContext(), R.string.toast_hash_mismatch, Toast.LENGTH_SHORT).show();
                 }
             });
         }