Skip to content

Commit 281b298

Browse files
iggy890Scrapallcontributors[bot]lukepistrol
authored
Rename Breadcrumbs to PathBar and fix comments (#1113)
* Re-open PR * Fix multiple files * More fixes * Minor fixes * Typo fixes * Typo fixes * Fix .xcodeproj * Minor update to docs * Minor docs change * Delete BreadcrumbsView.swift * Fix .xcodeproj * Update .all-contributorsrc * Update TextEditingPreferences.swift * Update TextEditingPreferencesView.swift * Update TextEditingPreferences.swift * Added setting to change font size, so can now change the default font… (#1128) Added setting to change font size, so can now change the default font size. * docs: add scrapp08 as a contributor for code (#1130) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> --------- Co-authored-by: Scrap <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Lukas Pistrol <[email protected]>
1 parent b990990 commit 281b298

File tree

25 files changed

+57
-57
lines changed

25 files changed

+57
-57
lines changed

CodeEdit.xcodeproj/project.pbxproj

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@
104104
5878DAA6291AE76700DD95A3 /* QuickOpenPreviewView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5878DAA2291AE76700DD95A3 /* QuickOpenPreviewView.swift */; };
105105
5878DAA7291AE76700DD95A3 /* QuickOpenViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5878DAA3291AE76700DD95A3 /* QuickOpenViewModel.swift */; };
106106
5878DAA8291AE76700DD95A3 /* QuickOpenItem.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5878DAA4291AE76700DD95A3 /* QuickOpenItem.swift */; };
107-
5878DAB0291D627C00DD95A3 /* BreadcrumbsMenu.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5878DAAD291D627C00DD95A3 /* BreadcrumbsMenu.swift */; };
108-
5878DAB1291D627C00DD95A3 /* BreadcrumbsComponent.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5878DAAE291D627C00DD95A3 /* BreadcrumbsComponent.swift */; };
109-
5878DAB2291D627C00DD95A3 /* BreadcrumbsView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5878DAAF291D627C00DD95A3 /* BreadcrumbsView.swift */; };
107+
5878DAB0291D627C00DD95A3 /* PathBarMenu.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5878DAAD291D627C00DD95A3 /* PathBarMenu.swift */; };
108+
5878DAB1291D627C00DD95A3 /* PathBarComponent.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5878DAAE291D627C00DD95A3 /* PathBarComponent.swift */; };
109+
5878DAB2291D627C00DD95A3 /* PathBarView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5878DAAF291D627C00DD95A3 /* PathBarView.swift */; };
110110
58798218292D92370085B254 /* String+SafeOffset.swift in Sources */ = {isa = PBXBuildFile; fileRef = 58798213292D92370085B254 /* String+SafeOffset.swift */; };
111111
58798219292D92370085B254 /* SearchModeModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 58798215292D92370085B254 /* SearchModeModel.swift */; };
112112
5879821A292D92370085B254 /* SearchResultModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 58798216292D92370085B254 /* SearchResultModel.swift */; };
@@ -508,9 +508,9 @@
508508
5878DAA2291AE76700DD95A3 /* QuickOpenPreviewView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = QuickOpenPreviewView.swift; sourceTree = "<group>"; };
509509
5878DAA3291AE76700DD95A3 /* QuickOpenViewModel.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = QuickOpenViewModel.swift; sourceTree = "<group>"; };
510510
5878DAA4291AE76700DD95A3 /* QuickOpenItem.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = QuickOpenItem.swift; sourceTree = "<group>"; };
511-
5878DAAD291D627C00DD95A3 /* BreadcrumbsMenu.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BreadcrumbsMenu.swift; sourceTree = "<group>"; };
512-
5878DAAE291D627C00DD95A3 /* BreadcrumbsComponent.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BreadcrumbsComponent.swift; sourceTree = "<group>"; };
513-
5878DAAF291D627C00DD95A3 /* BreadcrumbsView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BreadcrumbsView.swift; sourceTree = "<group>"; };
511+
5878DAAD291D627C00DD95A3 /* PathBarMenu.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PathBarMenu.swift; sourceTree = "<group>"; };
512+
5878DAAE291D627C00DD95A3 /* PathBarComponent.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PathBarComponent.swift; sourceTree = "<group>"; };
513+
5878DAAF291D627C00DD95A3 /* PathBarView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PathBarView.swift; sourceTree = "<group>"; };
514514
58798213292D92370085B254 /* String+SafeOffset.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "String+SafeOffset.swift"; sourceTree = "<group>"; };
515515
58798215292D92370085B254 /* SearchModeModel.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SearchModeModel.swift; sourceTree = "<group>"; };
516516
58798216292D92370085B254 /* SearchResultModel.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SearchResultModel.swift; sourceTree = "<group>"; };
@@ -1089,7 +1089,7 @@
10891089
5878DA7D291862BC00DD95A3 /* Acknowledgements */,
10901090
284DC84B2978B5EB00BF2770 /* Contributors */,
10911091
58F2EA9E292FB2B0004A9BDE /* AppPreferences */,
1092-
5878DAAB291D627C00DD95A3 /* Breadcrumbs */,
1092+
5878DAAB291D627C00DD95A3 /* PathBar */,
10931093
587B9D50292FC27A00AC7927 /* CodeEditExtension */,
10941094
587B9D7529300ABD00AC7927 /* CodeEditUI */,
10951095
58798244292E78D80085B254 /* CodeFile */,
@@ -1295,20 +1295,20 @@
12951295
path = ViewModels;
12961296
sourceTree = "<group>";
12971297
};
1298-
5878DAAB291D627C00DD95A3 /* Breadcrumbs */ = {
1298+
5878DAAB291D627C00DD95A3 /* PathBar */ = {
12991299
isa = PBXGroup;
13001300
children = (
13011301
5878DAAC291D627C00DD95A3 /* Views */,
13021302
);
1303-
path = Breadcrumbs;
1303+
path = PathBar;
13041304
sourceTree = "<group>";
13051305
};
13061306
5878DAAC291D627C00DD95A3 /* Views */ = {
13071307
isa = PBXGroup;
13081308
children = (
1309-
5878DAAD291D627C00DD95A3 /* BreadcrumbsMenu.swift */,
1310-
5878DAAE291D627C00DD95A3 /* BreadcrumbsComponent.swift */,
1311-
5878DAAF291D627C00DD95A3 /* BreadcrumbsView.swift */,
1309+
5878DAAD291D627C00DD95A3 /* PathBarMenu.swift */,
1310+
5878DAAE291D627C00DD95A3 /* PathBarComponent.swift */,
1311+
5878DAAF291D627C00DD95A3 /* PathBarView.swift */,
13121312
);
13131313
path = Views;
13141314
sourceTree = "<group>";
@@ -2669,7 +2669,7 @@
26692669
58D01C9B293167DC00C5B6B4 /* CodeEditKeychainConstants.swift in Sources */,
26702670
58F2EB0C292FB2B0004A9BDE /* SourceControlAccounts.swift in Sources */,
26712671
20EBB50F280C389300F3A5DA /* FileInspectorModel.swift in Sources */,
2672-
5878DAB1291D627C00DD95A3 /* BreadcrumbsComponent.swift in Sources */,
2672+
5878DAB1291D627C00DD95A3 /* PathBarComponent.swift in Sources */,
26732673
58822533292C280D00E83CDE /* StatusBarTabType.swift in Sources */,
26742674
587B9E6E29301D8F00AC7927 /* GitLabProject.swift in Sources */,
26752675
58798234292E30B90085B254 /* FeedbackIssueArea.swift in Sources */,
@@ -2858,7 +2858,7 @@
28582858
58D01C99293167DC00C5B6B4 /* String+MD5.swift in Sources */,
28592859
20EBB505280C329800F3A5DA /* HistoryInspectorItemView.swift in Sources */,
28602860
58F2EAEA292FB2B0004A9BDE /* SourceControlGeneralView.swift in Sources */,
2861-
5878DAB2291D627C00DD95A3 /* BreadcrumbsView.swift in Sources */,
2861+
5878DAB2291D627C00DD95A3 /* PathBarView.swift in Sources */,
28622862
043C321627E3201F006AE443 /* WorkspaceDocument.swift in Sources */,
28632863
58F2EAEC292FB2B0004A9BDE /* IgnoredFiles.swift in Sources */,
28642864
58F2EAEB292FB2B0004A9BDE /* SourceControlGitView.swift in Sources */,
@@ -2872,7 +2872,7 @@
28722872
5878DAA6291AE76700DD95A3 /* QuickOpenPreviewView.swift in Sources */,
28732873
58798286292ED0FB0085B254 /* SwiftTerm+Color+Init.swift in Sources */,
28742874
587B9E7229301D8F00AC7927 /* GitJSONPostRouter.swift in Sources */,
2875-
5878DAB0291D627C00DD95A3 /* BreadcrumbsMenu.swift in Sources */,
2875+
5878DAB0291D627C00DD95A3 /* PathBarMenu.swift in Sources */,
28762876
04C325512800AC7400C8DA2D /* ExtensionInstallationViewModel.swift in Sources */,
28772877
587B9DA529300ABD00AC7927 /* PressActionsModifier.swift in Sources */,
28782878
28B0A19827E385C300B73177 /* NavigatorSidebarToolbarTop.swift in Sources */,

CodeEdit/Features/AppPreferences/Model/Terminal/TerminalPreferences.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ extension AppPreferences {
1515
/// If true terminal appearance will always be `dark`. Otherwise it adapts to the system setting.
1616
var darkAppearance: Bool = false
1717

18-
/// if true, the terminal uses the background color of the theme, otherwise it is clear
18+
/// If true, the terminal uses the background color of the theme, otherwise it is clear
1919
var useThemeBackground: Bool = true
2020

2121
/// If true, the terminal treats the `Option` key as the `Meta` key

CodeEdit/Features/AppPreferences/Sections/KeybindingsPreferences/KeybindingsPreferencesView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import SwiftUI
1010
struct KeybindingsPreferencesView: View {
1111
var body: some View {
1212
PreferencesContent {
13-
Text("Hello World")
13+
Text("Implementation needed")
1414
}
1515
}
1616
}

CodeEdit/Features/AppPreferences/Sections/ThemePreferences/Model/Theme.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ struct Theme: Identifiable, Codable, Equatable, Hashable, Loopable {
3030
/// The `author` of the theme
3131
var author: String
3232

33-
/// The `licence` of the theme
33+
/// The `license` of the theme
3434
var license: String
3535

3636
/// A short `description` of the theme

CodeEdit/Features/CodeFile/CodeFile.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ final class CodeFileDocument: NSDocument, ObservableObject, QLPreviewItem {
9090
return data
9191
}
9292

93-
/// This fuction is used for decoding files.
93+
/// This function is used for decoding files.
9494
/// It should not throw error as unsupported files can still be opened by QLPreviewView.
9595
override func read(from data: Data, ofType _: String) throws {
9696
guard let content = String(data: data, encoding: .utf8) else { return }

CodeEdit/Features/Commands/ViewModels/CommandPaletteViewModel.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//
2-
// CommandPaletteState.swift
2+
// CommandPaletteViewModel.swift
33
// CodeEdit
44
//
55
// Created by Alex on 25.05.2022.

CodeEdit/Features/Documents/Views/WorkspaceCodeFileView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//
2-
// WorkspaceCodeFileEditor.swift
2+
// WorkspaceCodeFileView.swift
33
// CodeEdit
44
//
55
// Created by Pavel Kasila on 20.03.22.

CodeEdit/Features/Git/Client/Models/GitCommit.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ struct GitCommit: Equatable, Hashable, Identifiable {
3737
}
3838

3939
private func parsedRemoteUrl(domain: String, remote: URL) -> URL {
40-
// There are 2 types of remotes - https and ssh. While https has URL in its name, ssh doesnt.
40+
// There are 2 types of remotes - https and ssh. While https has URL in its name, ssh doesn't.
4141
// Following code takes remote name in format profileName/repoName and prepends according domain
4242
var formattedRemote = remote
4343
if formattedRemote.absoluteString.starts(with: "git@") {

CodeEdit/Features/Keybindings/CommandManager.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import Foundation
88

99
/**
10-
The object of this class intented to be a hearth of command palette. This object only exists as singleton.
10+
The object of this class intended to be a hearth of command palette. This object only exists as singleton.
1111
In Order to access its instance use `CommandManager.shared`
1212

1313
```
@@ -79,7 +79,7 @@ struct CommandClosureWrapper {
7979
let workspaceClientClosure: WorkspaceClientClosure?
8080

8181
/// Initializer for closure wrapper
82-
/// - Parameter closure: Function that containts all logic to run command.
82+
/// - Parameter closure: Function that contains all logic to run command.
8383
init(closure: @escaping WorkspaceClientClosure) {
8484
self.workspaceClientClosure = closure
8585
}

CodeEdit/Features/Keybindings/KeybindingManager.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
//
22
// KeybindingManager.swift
3-
//
43
//
54
// Created by Alex on 09.05.2022.
65
//

0 commit comments

Comments
 (0)