Skip to content

Commit 581c12f

Browse files
committed
Clean up confirmation messages
1 parent 28f7060 commit 581c12f

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

CodeEdit/Features/LSP/Registry/PackageManagers/Sources/GithubPackageManager.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ final class GithubPackageManager: PackageManagerProtocol {
183183
in: packagePath.deletingLastPathComponent().path(percentEncoded: false),
184184
[
185185
"gunzip",
186-
"-f", // Overwrite source file
186+
"-f",
187187
packagePath.path(percentEncoded: false).escapedDirectory(),
188188
]
189189
)

CodeEdit/Features/LSP/Registry/PackageManagers/Sources/GolangPackageManager.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,10 @@ final class GolangPackageManager: PackageManagerProtocol {
9191
let installCommand = getGoInstallCommand(source)
9292
return PackageManagerInstallStep(
9393
name: "Install Package Using go",
94-
// TODO: Confirm
95-
confirmation: .required(message: "")
94+
confirmation: .required(
95+
message: "This requires installing the go package \(installCommand)."
96+
+ "\nAllow CodeEdit to install this package?"
97+
)
9698
) { model in
9799
let gobinPath = packagePath.appending(path: "bin", directoryHint: .isDirectory).path
98100
var goInstallCommand = ["env", "GOBIN=\(gobinPath)", "go", "install"]

CodeEdit/Features/LSP/Registry/PackageManagers/Sources/NPMPackageManager.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ final class NPMPackageManager: PackageManagerProtocol {
114114
return PackageManagerInstallStep(
115115
name: "Install Package Using npm",
116116
confirmation: .required(
117-
message: "Package requires npm package\(sSuffix) \(packagesDescription)."
117+
message: "This requires the npm package\(sSuffix) \(packagesDescription)."
118118
+ "\nAllow CodeEdit to install \(suffix)?"
119119
)
120120
) { model in

0 commit comments

Comments
 (0)