Skip to content

Commit 78c3be9

Browse files
authored
Fix/deprecations memory leak entitlements (#2147)
1 parent d0adbb2 commit 78c3be9

File tree

42 files changed

+138
-113
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+138
-113
lines changed

CodeEdit.xcodeproj/project.pbxproj

Lines changed: 41 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@
397397
attributes = {
398398
BuildIndependentTargetsInParallel = 1;
399399
LastSwiftUpdateCheck = 1330;
400-
LastUpgradeCheck = 1640;
400+
LastUpgradeCheck = 2610;
401401
TargetAttributes = {
402402
2BE487EB28245162003F3F64 = {
403403
CreatedOnToolsVersion = 13.3.1;
@@ -643,13 +643,14 @@
643643
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
644644
GCC_WARN_UNUSED_FUNCTION = YES;
645645
GCC_WARN_UNUSED_VARIABLE = YES;
646-
MACOSX_DEPLOYMENT_TARGET = 13.0;
646+
MACOSX_DEPLOYMENT_TARGET = 14.0;
647647
MARKETING_VERSION = "";
648648
MTL_ENABLE_DEBUG_INFO = NO;
649649
MTL_FAST_MATH = YES;
650650
OTHER_SWIFT_FLAGS = "-D ALPHA";
651651
RUN_DOCUMENTATION_COMPILER = YES;
652652
SDKROOT = macosx;
653+
STRING_CATALOG_GENERATE_SYMBOLS = YES;
653654
SWIFT_COMPILATION_MODE = wholemodule;
654655
SWIFT_OPTIMIZATION_LEVEL = "-O";
655656
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
@@ -673,6 +674,7 @@
673674
DEAD_CODE_STRIPPING = YES;
674675
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
675676
DEVELOPMENT_TEAM = "";
677+
ENABLE_APP_SANDBOX = YES;
676678
ENABLE_HARDENED_RUNTIME = YES;
677679
ENABLE_PREVIEWS = YES;
678680
GENERATE_INFOPLIST_FILE = NO;
@@ -684,12 +686,14 @@
684686
"$(inherited)",
685687
"@executable_path/../Frameworks",
686688
);
687-
MACOSX_DEPLOYMENT_TARGET = 13.0;
689+
MACOSX_DEPLOYMENT_TARGET = 14.0;
688690
MARKETING_VERSION = "Change in Info.plist";
689691
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
690692
PRODUCT_NAME = "$(TARGET_NAME)";
691693
PROVISIONING_PROFILE_SPECIFIER = "";
692694
REGISTER_APP_GROUPS = YES;
695+
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
696+
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
693697
RUN_DOCUMENTATION_COMPILER = NO;
694698
SWIFT_EMIT_LOC_STRINGS = YES;
695699
SWIFT_OBJC_BRIDGING_HEADER = "";
@@ -715,7 +719,7 @@
715719
"@executable_path/../Frameworks",
716720
"@loader_path/../Frameworks",
717721
);
718-
MACOSX_DEPLOYMENT_TARGET = 13.0;
722+
MACOSX_DEPLOYMENT_TARGET = 14.0;
719723
MARKETING_VERSION = 1.0;
720724
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
721725
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -777,7 +781,7 @@
777781
"@executable_path/../Frameworks",
778782
"@executable_path/../../../../Frameworks",
779783
);
780-
MACOSX_DEPLOYMENT_TARGET = 13.0;
784+
MACOSX_DEPLOYMENT_TARGET = 14.0;
781785
MARKETING_VERSION = 1.0;
782786
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
783787
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -840,13 +844,14 @@
840844
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
841845
GCC_WARN_UNUSED_FUNCTION = YES;
842846
GCC_WARN_UNUSED_VARIABLE = YES;
843-
MACOSX_DEPLOYMENT_TARGET = 13.0;
847+
MACOSX_DEPLOYMENT_TARGET = 14.0;
844848
MARKETING_VERSION = "";
845849
MTL_ENABLE_DEBUG_INFO = NO;
846850
MTL_FAST_MATH = YES;
847851
OTHER_SWIFT_FLAGS = "-D BETA";
848852
RUN_DOCUMENTATION_COMPILER = YES;
849853
SDKROOT = macosx;
854+
STRING_CATALOG_GENERATE_SYMBOLS = YES;
850855
SWIFT_COMPILATION_MODE = wholemodule;
851856
SWIFT_OPTIMIZATION_LEVEL = "-O";
852857
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
@@ -870,6 +875,7 @@
870875
DEAD_CODE_STRIPPING = YES;
871876
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
872877
DEVELOPMENT_TEAM = "";
878+
ENABLE_APP_SANDBOX = YES;
873879
ENABLE_HARDENED_RUNTIME = YES;
874880
ENABLE_PREVIEWS = YES;
875881
GENERATE_INFOPLIST_FILE = NO;
@@ -881,12 +887,14 @@
881887
"$(inherited)",
882888
"@executable_path/../Frameworks",
883889
);
884-
MACOSX_DEPLOYMENT_TARGET = 13.0;
890+
MACOSX_DEPLOYMENT_TARGET = 14.0;
885891
MARKETING_VERSION = "Change in Info.plist";
886892
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
887893
PRODUCT_NAME = "$(TARGET_NAME)";
888894
PROVISIONING_PROFILE_SPECIFIER = "";
889895
REGISTER_APP_GROUPS = YES;
896+
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
897+
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
890898
RUN_DOCUMENTATION_COMPILER = NO;
891899
SWIFT_EMIT_LOC_STRINGS = YES;
892900
SWIFT_OBJC_BRIDGING_HEADER = "";
@@ -912,7 +920,7 @@
912920
"@executable_path/../Frameworks",
913921
"@loader_path/../Frameworks",
914922
);
915-
MACOSX_DEPLOYMENT_TARGET = 13.0;
923+
MACOSX_DEPLOYMENT_TARGET = 14.0;
916924
MARKETING_VERSION = 1.0;
917925
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
918926
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -974,7 +982,7 @@
974982
"@executable_path/../Frameworks",
975983
"@executable_path/../../../../Frameworks",
976984
);
977-
MACOSX_DEPLOYMENT_TARGET = 13.0;
985+
MACOSX_DEPLOYMENT_TARGET = 14.0;
978986
MARKETING_VERSION = 1.0;
979987
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
980988
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -1009,7 +1017,7 @@
10091017
"@executable_path/../Frameworks",
10101018
"@executable_path/../../../../Frameworks",
10111019
);
1012-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1020+
MACOSX_DEPLOYMENT_TARGET = 14.0;
10131021
MARKETING_VERSION = 1.0;
10141022
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
10151023
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -1044,7 +1052,7 @@
10441052
"@executable_path/../Frameworks",
10451053
"@executable_path/../../../../Frameworks",
10461054
);
1047-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1055+
MACOSX_DEPLOYMENT_TARGET = 14.0;
10481056
MARKETING_VERSION = 1.0;
10491057
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
10501058
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -1108,13 +1116,14 @@
11081116
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
11091117
GCC_WARN_UNUSED_FUNCTION = YES;
11101118
GCC_WARN_UNUSED_VARIABLE = YES;
1111-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1119+
MACOSX_DEPLOYMENT_TARGET = 14.0;
11121120
MARKETING_VERSION = "";
11131121
MTL_ENABLE_DEBUG_INFO = NO;
11141122
MTL_FAST_MATH = YES;
11151123
OTHER_SWIFT_FLAGS = "-D ALPHA";
11161124
RUN_DOCUMENTATION_COMPILER = YES;
11171125
SDKROOT = macosx;
1126+
STRING_CATALOG_GENERATE_SYMBOLS = YES;
11181127
SWIFT_COMPILATION_MODE = wholemodule;
11191128
SWIFT_OPTIMIZATION_LEVEL = "-O";
11201129
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
@@ -1139,6 +1148,7 @@
11391148
DEAD_CODE_STRIPPING = YES;
11401149
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
11411150
DEVELOPMENT_TEAM = "";
1151+
ENABLE_APP_SANDBOX = YES;
11421152
ENABLE_HARDENED_RUNTIME = YES;
11431153
ENABLE_PREVIEWS = YES;
11441154
GENERATE_INFOPLIST_FILE = NO;
@@ -1150,12 +1160,14 @@
11501160
"$(inherited)",
11511161
"@executable_path/../Frameworks",
11521162
);
1153-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1163+
MACOSX_DEPLOYMENT_TARGET = 14.0;
11541164
MARKETING_VERSION = "Change in Info.plist";
11551165
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
11561166
PRODUCT_NAME = "$(TARGET_NAME)";
11571167
PROVISIONING_PROFILE_SPECIFIER = "";
11581168
REGISTER_APP_GROUPS = YES;
1169+
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
1170+
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
11591171
RUN_DOCUMENTATION_COMPILER = NO;
11601172
SWIFT_EMIT_LOC_STRINGS = YES;
11611173
SWIFT_OBJC_BRIDGING_HEADER = "";
@@ -1181,7 +1193,7 @@
11811193
"@executable_path/../Frameworks",
11821194
"@loader_path/../Frameworks",
11831195
);
1184-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1196+
MACOSX_DEPLOYMENT_TARGET = 14.0;
11851197
MARKETING_VERSION = 1.0;
11861198
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
11871199
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -1243,7 +1255,7 @@
12431255
"@executable_path/../Frameworks",
12441256
"@executable_path/../../../../Frameworks",
12451257
);
1246-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1258+
MACOSX_DEPLOYMENT_TARGET = 14.0;
12471259
MARKETING_VERSION = 1.0;
12481260
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit.OpenWithCodeEdit;
12491261
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -1312,13 +1324,14 @@
13121324
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
13131325
GCC_WARN_UNUSED_FUNCTION = YES;
13141326
GCC_WARN_UNUSED_VARIABLE = YES;
1315-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1327+
MACOSX_DEPLOYMENT_TARGET = 14.0;
13161328
MARKETING_VERSION = "";
13171329
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
13181330
MTL_FAST_MATH = YES;
13191331
ONLY_ACTIVE_ARCH = YES;
13201332
RUN_DOCUMENTATION_COMPILER = YES;
13211333
SDKROOT = macosx;
1334+
STRING_CATALOG_GENERATE_SYMBOLS = YES;
13221335
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
13231336
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
13241337
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
@@ -1378,12 +1391,13 @@
13781391
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
13791392
GCC_WARN_UNUSED_FUNCTION = YES;
13801393
GCC_WARN_UNUSED_VARIABLE = YES;
1381-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1394+
MACOSX_DEPLOYMENT_TARGET = 14.0;
13821395
MARKETING_VERSION = "";
13831396
MTL_ENABLE_DEBUG_INFO = NO;
13841397
MTL_FAST_MATH = YES;
13851398
RUN_DOCUMENTATION_COMPILER = YES;
13861399
SDKROOT = macosx;
1400+
STRING_CATALOG_GENERATE_SYMBOLS = YES;
13871401
SWIFT_COMPILATION_MODE = wholemodule;
13881402
SWIFT_OPTIMIZATION_LEVEL = "-O";
13891403
SYSTEM_FRAMEWORK_SEARCH_PATHS = "";
@@ -1407,6 +1421,7 @@
14071421
DEAD_CODE_STRIPPING = YES;
14081422
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
14091423
DEVELOPMENT_TEAM = "";
1424+
ENABLE_APP_SANDBOX = YES;
14101425
ENABLE_HARDENED_RUNTIME = YES;
14111426
ENABLE_PREVIEWS = YES;
14121427
GENERATE_INFOPLIST_FILE = NO;
@@ -1418,12 +1433,14 @@
14181433
"$(inherited)",
14191434
"@executable_path/../Frameworks",
14201435
);
1421-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1436+
MACOSX_DEPLOYMENT_TARGET = 14.0;
14221437
MARKETING_VERSION = "Change in Info.plist";
14231438
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
14241439
PRODUCT_NAME = "$(TARGET_NAME)";
14251440
PROVISIONING_PROFILE_SPECIFIER = "";
14261441
REGISTER_APP_GROUPS = YES;
1442+
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
1443+
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
14271444
RUN_DOCUMENTATION_COMPILER = NO;
14281445
SWIFT_EMIT_LOC_STRINGS = YES;
14291446
SWIFT_OBJC_BRIDGING_HEADER = "";
@@ -1448,6 +1465,7 @@
14481465
DEAD_CODE_STRIPPING = YES;
14491466
DEVELOPMENT_ASSET_PATHS = "\"CodeEdit/Preview Content\"";
14501467
DEVELOPMENT_TEAM = "";
1468+
ENABLE_APP_SANDBOX = YES;
14511469
ENABLE_HARDENED_RUNTIME = YES;
14521470
ENABLE_PREVIEWS = YES;
14531471
GENERATE_INFOPLIST_FILE = NO;
@@ -1459,12 +1477,14 @@
14591477
"$(inherited)",
14601478
"@executable_path/../Frameworks",
14611479
);
1462-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1480+
MACOSX_DEPLOYMENT_TARGET = 14.0;
14631481
MARKETING_VERSION = "Change in Info.plist";
14641482
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEdit;
14651483
PRODUCT_NAME = "$(TARGET_NAME)";
14661484
PROVISIONING_PROFILE_SPECIFIER = "";
14671485
REGISTER_APP_GROUPS = YES;
1486+
RUNTIME_EXCEPTION_ALLOW_JIT = YES;
1487+
RUNTIME_EXCEPTION_DISABLE_LIBRARY_VALIDATION = YES;
14681488
RUN_DOCUMENTATION_COMPILER = NO;
14691489
SWIFT_EMIT_LOC_STRINGS = YES;
14701490
SWIFT_OBJC_BRIDGING_HEADER = "";
@@ -1490,7 +1510,7 @@
14901510
"@executable_path/../Frameworks",
14911511
"@loader_path/../Frameworks",
14921512
);
1493-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1513+
MACOSX_DEPLOYMENT_TARGET = 14.0;
14941514
MARKETING_VERSION = 1.0;
14951515
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
14961516
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -1517,7 +1537,7 @@
15171537
"@executable_path/../Frameworks",
15181538
"@loader_path/../Frameworks",
15191539
);
1520-
MACOSX_DEPLOYMENT_TARGET = 13.0;
1540+
MACOSX_DEPLOYMENT_TARGET = 14.0;
15211541
MARKETING_VERSION = 1.0;
15221542
PRODUCT_BUNDLE_IDENTIFIER = app.codeedit.CodeEditTests;
15231543
PRODUCT_NAME = "$(TARGET_NAME)";

CodeEdit.xcodeproj/xcshareddata/xcschemes/CodeEdit.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "2600"
3+
LastUpgradeVersion = "2610"
44
version = "1.7">
55
<BuildAction
66
parallelizeBuildables = "YES"

CodeEdit.xcodeproj/xcshareddata/xcschemes/OpenWithCodeEdit.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "2600"
3+
LastUpgradeVersion = "2610"
44
wasCreatedForAppExtension = "YES"
55
version = "2.0">
66
<BuildAction

CodeEdit/CodeEdit.entitlements

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,18 @@
22
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
33
<plist version="1.0">
44
<dict>
5+
<key>com.apple.security.app-sandbox</key>
6+
<true/>
7+
<key>com.apple.security.files.user-selected.read-write</key>
8+
<true/>
9+
<key>com.apple.security.files.bookmarks.app-scope</key>
10+
<true/>
11+
<key>com.apple.security.network.client</key>
12+
<true/>
513
<key>com.apple.security.application-groups</key>
614
<array>
715
<string>app.codeedit.CodeEdit.shared</string>
816
<string>$(TeamIdentifierPrefix)</string>
917
</array>
10-
<key>com.apple.security.cs.allow-jit</key>
11-
<true/>
12-
<key>com.apple.security.cs.disable-library-validation</key>
13-
<true/>
1418
</dict>
1519
</plist>

CodeEdit/Features/ActivityViewer/Notifications/TaskNotificationView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ struct TaskNotificationView: View {
4949
}
5050
}
5151
.animation(.easeInOut, value: notification)
52-
.onChange(of: taskNotificationHandler.notifications) { newValue in
52+
.onChange(of: taskNotificationHandler.notifications) { _, newValue in
5353
withAnimation {
5454
notification = newValue.first
5555
}

CodeEdit/Features/ActivityViewer/Notifications/TaskNotificationsDetailView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ struct TaskNotificationsDetailView: View {
3535
}
3636
.padding(15)
3737
.frame(minWidth: 320)
38-
.onChange(of: taskNotificationHandler.notifications) { newValue in
38+
.onChange(of: taskNotificationHandler.notifications) { _, newValue in
3939
if selectedTaskNotificationIndex >= newValue.count {
4040
selectedTaskNotificationIndex = 0
4141
}

CodeEdit/Features/CEWorkspaceSettings/Views/EnvironmentVariableListItem.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ struct EnvironmentVariableListItem: View {
5050
.autocorrectionDisabled()
5151
.labelsHidden()
5252
}
53-
.onChange(of: isKeyFocused) { isFocused in
53+
.onChange(of: isKeyFocused) { _, isFocused in
5454
if isFocused {
5555
if selectedEnvID != environmentVariable.id {
5656
selectedEnvID = environmentVariable.id
@@ -62,10 +62,10 @@ struct EnvironmentVariableListItem: View {
6262
}
6363
}
6464
}
65-
.onChange(of: key) { newValue in
65+
.onChange(of: key) { _, newValue in
6666
environmentVariable.key = newValue
6767
}
68-
.onChange(of: value) { newValue in
68+
.onChange(of: value) { _, newValue in
6969
environmentVariable.value = newValue
7070
}
7171
}

CodeEdit/Features/CodeEditUI/Views/KeyValueTable.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ struct KeyValueTable<Header: View, ActionBarView: View>: View {
203203
}
204204
selection = []
205205
}
206-
.onChange(of: items) { newValue in
206+
.onChange(of: items) { _, newValue in
207207
updateTableItems(newValue)
208208
}
209209
}

CodeEdit/Features/CodeEditUI/Views/WorkspacePanelTabBar.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,10 +281,10 @@ struct WorkspacePanelTabBar<Tab: WorkspacePanelTab>: View {
281281
self.tabWidth[tab] = (position == .top) ? geometry.size.width : geometry.size.height
282282
self.tabLocations[tab] = geometry.frame(in: .global)
283283
}
284-
.onChange(of: geometry.frame(in: .global)) { newFrame in
284+
.onChange(of: geometry.frame(in: .global)) { _, newFrame in
285285
self.tabLocations[tab] = newFrame
286286
}
287-
.onChange(of: geometry.size.width) { newWidth in
287+
.onChange(of: geometry.size.width) { _, newWidth in
288288
self.tabWidth[tab] = newWidth
289289
}
290290
}

0 commit comments

Comments
 (0)