Refactors

Author: FastestMolasses

CodeEdit/Features/LSP/Registry/PackageManagers/GithubPackageManager.swift

@@ -30,18 +30,17 @@ final class GithubPackageManager: PackageManagerProtocol {
     }
 
     func install(method: InstallationMethod) async throws {
-        guard case .standardPackage(let source) = method else {
-            throw PackageManagerError.invalidConfiguration
-        }
-
-        let packagePath = installationDirectory.appending(path: source.entryName)
-        try await initialize(in: packagePath)
-
         switch method {
         case let .binaryDownload(source, url):
+            let packagePath = installationDirectory.appending(path: source.entryName)
+            try await initialize(in: packagePath)
             try await downloadBinary(source, url)
+
         case let .sourceBuild(source, command):
+            let packagePath = installationDirectory.appending(path: source.entryName)
+            try await initialize(in: packagePath)
             try await installFromSource(source, command)
+
         case .standardPackage, .unknown:
             throw PackageManagerError.invalidConfiguration
         }
@@ -64,11 +63,29 @@ final class GithubPackageManager: PackageManagerProtocol {
     }
 
     private func downloadBinary(_ source: PackageSource, _ url: URL) async throws {
-        _ = try await URLSession.shared.data(from: url)
+        let (data, response) = try await URLSession.shared.data(from: url)
+
+        guard let httpResponse = response as? HTTPURLResponse,
+              (200...299).contains(httpResponse.statusCode) else {
+            throw RegistryManagerError.downloadFailed(
+                url: url,
+                error: NSError(domain: "HTTP error", code: (response as? HTTPURLResponse)?.statusCode ?? -1)
+            )
+        }
+
         let fileName = url.lastPathComponent
         let downloadPath = installationDirectory.appending(path: source.entryName)
         let packagePath = downloadPath.appending(path: fileName)
 
+        do {
+            try data.write(to: packagePath, options: .atomic)
+        } catch {
+            throw RegistryManagerError.downloadFailed(
+                url: url,
+                error: error
+            )
+        }
+
         if !FileManager.default.fileExists(atPath: packagePath.path) {
             throw RegistryManagerError.downloadFailed(
                 url: url,
@@ -84,7 +101,11 @@ final class GithubPackageManager: PackageManagerProtocol {
     private func installFromSource(_ source: PackageSource, _ command: String) async throws {
         let installPath = installationDirectory.appending(path: source.entryName, directoryHint: .isDirectory)
         do {
-            _ = try await executeInDirectory(in: installPath.path, ["git", "clone", source.repositoryUrl!])
+            guard let repoURL = source.repositoryUrl else {
+                throw PackageManagerError.invalidConfiguration
+            }
+
+            _ = try await executeInDirectory(in: installPath.path, ["git", "clone", repoURL])
             let repoPath = installPath.appending(path: source.pkgName, directoryHint: .isDirectory)
             _ = try await executeInDirectory(in: repoPath.path, [command])
         } catch {

CodeEdit/Features/LSP/Registry/PackageSourceParser/PackageSourceParser.swift

@@ -40,7 +40,7 @@ enum PackageSourceParser {
             false
         }
 
-        let source = PackageSource(
+        var source = PackageSource(
             sourceId: sourceId,
             type: isSourceBuild ? .sourceBuild : .github,
             pkgName: packageName,