Skip to content

Commit 4ef82c3

Browse files
authored
fix: register WorkerTextModelSyncClient (microsoft#259442)
It is disposable object which might run timer until it is disposed. Drive-by: removed await for non async call.
1 parent 8923817 commit 4ef82c3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/vs/workbench/contrib/output/browser/outputLinkProvider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ class OutputLinkWorkerClient extends Disposable {
102102
FileAccess.asBrowserUri('vs/workbench/contrib/output/common/outputLinkComputerMain.js'),
103103
'OutputLinkDetectionWorker'
104104
));
105-
this._workerTextModelSyncClient = WorkerTextModelSyncClient.create(this._workerClient, modelService);
105+
this._workerTextModelSyncClient = this._register(WorkerTextModelSyncClient.create(this._workerClient, modelService));
106106
this._initializeBarrier = this._ensureWorkspaceFolders();
107107
}
108108

@@ -112,7 +112,7 @@ class OutputLinkWorkerClient extends Disposable {
112112

113113
public async provideLinks(modelUri: URI): Promise<ILink[]> {
114114
await this._initializeBarrier;
115-
await this._workerTextModelSyncClient.ensureSyncedResources([modelUri]);
115+
this._workerTextModelSyncClient.ensureSyncedResources([modelUri]);
116116
return this._workerClient.proxy.$computeLinks(modelUri.toString());
117117
}
118118
}

src/vs/workbench/services/languageDetection/browser/languageDetectionWorkerServiceImpl.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ export class LanguageDetectionWorkerClient extends Disposable {
212212
$getModelJsonUri: async () => this.getModelJsonUri(),
213213
$getWeightsUri: async () => this.getWeightsUri(),
214214
});
215-
const workerTextModelSyncClient = WorkerTextModelSyncClient.create(workerClient, this._modelService);
215+
const workerTextModelSyncClient = this._register(WorkerTextModelSyncClient.create(workerClient, this._modelService));
216216
this.worker = { workerClient, workerTextModelSyncClient };
217217
}
218218
return this.worker;
@@ -272,7 +272,7 @@ export class LanguageDetectionWorkerClient extends Disposable {
272272
}
273273

274274
const { workerClient, workerTextModelSyncClient } = this._getOrCreateLanguageDetectionWorker();
275-
await workerTextModelSyncClient.ensureSyncedResources([resource]);
275+
workerTextModelSyncClient.ensureSyncedResources([resource]);
276276
const modelId = await workerClient.proxy.$detectLanguage(resource.toString(), langBiases, preferHistory, supportedLangs);
277277
const languageId = this.getLanguageId(modelId);
278278

0 commit comments

Comments
 (0)