improve consistency of function names (microsoft#251145)

Author: meganrogge

src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts

@@ -17,7 +17,7 @@ import { TerminalCompletionItemKind, type ITerminalCompletion } from './terminal
 import { env as processEnv } from '../../../../../base/common/process.js';
 import type { IProcessEnvironment } from '../../../../../base/common/platform.js';
 import { timeout } from '../../../../../base/common/async.js';
-import { gitBashPathToWindows } from './terminalGitBashHelpers.js';
+import { gitBashToWindowsPath } from './terminalGitBashHelpers.js';
 
 export const ITerminalCompletionService = createDecorator<ITerminalCompletionService>('terminalCompletionService');
 
@@ -282,7 +282,7 @@ export class TerminalCompletionService extends Disposable implements ITerminalCo
 			}
 			case 'absolute': {
 				if (shellType === WindowsShellType.GitBash) {
-					lastWordFolderResource = URI.file(gitBashPathToWindows(lastWordFolder, this._processEnv.SystemDrive));
+					lastWordFolderResource = URI.file(gitBashToWindowsPath(lastWordFolder, this._processEnv.SystemDrive));
 				} else {
 					lastWordFolderResource = URI.file(lastWordFolder.replaceAll('\\ ', ' '));
 				}

src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalGitBashHelpers.ts

@@ -11,7 +11,7 @@
  *   "/c/Users/foo" => "C:\\Users\\foo"
  *   "/d/bar" => "D:\\bar"
  */
-export function gitBashPathToWindows(path: string, driveLetter?: string): string {
+export function gitBashToWindowsPath(path: string, driveLetter?: string): string {
 	// Dynamically determine the system drive (default to 'C:' if not set)
 	const systemDrive = (driveLetter || 'C:').toUpperCase();
 	// Handle root "/"

src/vs/workbench/contrib/terminalContrib/suggest/test/browser/terminalCompletionService.test.ts

@@ -19,7 +19,7 @@ import { TerminalCapability } from '../../../../../../platform/terminal/common/c
 import { ITerminalCompletion, TerminalCompletionItemKind } from '../../browser/terminalCompletionItem.js';
 import { count } from '../../../../../../base/common/strings.js';
 import { WindowsShellType } from '../../../../../../platform/terminal/common/terminal.js';
-import { gitBashPathToWindows, windowsToGitBashPath } from '../../browser/terminalGitBashHelpers.js';
+import { gitBashToWindowsPath, windowsToGitBashPath } from '../../browser/terminalGitBashHelpers.js';
 
 const pathSeparator = isWindows ? '\\' : '/';
 
@@ -615,10 +615,10 @@ suite('TerminalCompletionService', () => {
 	if (isWindows) {
 		suite('gitbash', () => {
 			test('should convert Git Bash absolute path to Windows absolute path', () => {
-				assert.strictEqual(gitBashPathToWindows('/'), 'C:\\');
-				assert.strictEqual(gitBashPathToWindows('/c/'), 'C:\\');
-				assert.strictEqual(gitBashPathToWindows('/c/Users/foo'), 'C:\\Users\\foo');
-				assert.strictEqual(gitBashPathToWindows('/d/bar'), 'D:\\bar');
+				assert.strictEqual(gitBashToWindowsPath('/'), 'C:\\');
+				assert.strictEqual(gitBashToWindowsPath('/c/'), 'C:\\');
+				assert.strictEqual(gitBashToWindowsPath('/c/Users/foo'), 'C:\\Users\\foo');
+				assert.strictEqual(gitBashToWindowsPath('/d/bar'), 'D:\\bar');
 			});
 
 			test('should convert Windows absolute path to Git Bash absolute path', () => {