Author: NikolaRHristov

.eslint-ignore

@@ -0,0 +1,36 @@
+**/build/*/**/*.js
+**/dist/**/*.js
+**/extensions/**/*.d.ts
+**/extensions/**/build/**
+**/extensions/**/colorize-fixtures/**
+**/extensions/css-language-features/server/test/pathCompletionFixtures/**
+**/extensions/html-language-features/server/lib/jquery.d.ts
+**/extensions/html-language-features/server/src/test/pathCompletionFixtures/**
+**/extensions/ipynb/notebook-out/**
+**/extensions/markdown-language-features/media/**
+**/extensions/markdown-language-features/notebook-out/**
+**/extensions/markdown-math/notebook-out/**
+**/extensions/notebook-renderers/renderer-out/index.js
+**/extensions/simple-browser/media/index.js
+**/extensions/typescript-language-features/test-workspace/**
+**/extensions/typescript-language-features/extension.webpack.config.js
+**/extensions/typescript-language-features/extension-browser.webpack.config.js
+**/extensions/typescript-language-features/package-manager/node-maintainer/**
+**/extensions/vscode-api-tests/testWorkspace/**
+**/extensions/vscode-api-tests/testWorkspace2/**
+**/fixtures/**
+**/node_modules/**
+**/out-*/**/*.js
+**/out-editor-*/**
+**/out/**/*.js
+**/src/**/dompurify.js
+**/src/**/marked.js
+**/src/**/semver.js
+**/src/typings/**/*.d.ts
+**/src/vs/*/**/*.d.ts
+**/src/vs/base/test/common/filters.perf.data.js
+**/src/vs/loader.js
+**/test/unit/assert.js
+**/test/automation/out/**
+**/typings/**
+!.vscode

.eslint-plugin-local/code-amd-node-module.ts

@@ -0,0 +1,61 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as eslint from 'eslint';
+import { join } from 'path';
+
+
+export = new class ApiProviderNaming implements eslint.Rule.RuleModule {
+
+	readonly meta: eslint.Rule.RuleMetaData = {
+		messages: {
+			amdX: 'Use `import type` for import declarations, use `amdX#importAMDNodeModule` for import expressions'
+		},
+		schema: false,
+	};
+
+	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
+
+		const modules = new Set<string>();
+
+		try {
+			const { dependencies, optionalDependencies } = require(join(__dirname, '../package.json'));
+			const all = Object.keys(dependencies).concat(Object.keys(optionalDependencies));
+			for (const key of all) {
+				modules.add(key);
+			}
+
+		} catch (e) {
+			console.error(e);
+			throw e;
+		}
+
+
+		const checkImport = (node: any) => {
+
+			if (node.type !== 'Literal' || typeof node.value !== 'string') {
+				return;
+			}
+
+			if (node.parent.importKind === 'type') {
+				return;
+			}
+
+			if (!modules.has(node.value)) {
+				return;
+			}
+
+			context.report({
+				node,
+				messageId: 'amdX'
+			});
+		}
+
+		return {
+			['ImportExpression Literal']: checkImport,
+			['ImportDeclaration Literal']: checkImport
+		};
+	}
+};

.eslint-plugin-local/code-declare-service-brand.ts

@@ -0,0 +1,28 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as eslint from 'eslint';
+
+export = new class DeclareServiceBrand implements eslint.Rule.RuleModule {
+
+	readonly meta: eslint.Rule.RuleMetaData = {
+		fixable: 'code',
+		schema: false,
+	};
+
+	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
+		return {
+			['PropertyDefinition[key.name="_serviceBrand"][value]']: (node: any) => {
+				return context.report({
+					node,
+					message: `The '_serviceBrand'-property should not have a value`,
+					fix: (fixer) => {
+						return fixer.replaceText(node, 'declare _serviceBrand: undefined;')
+					}
+				});
+			}
+		};
+	}
+};

.eslint-plugin-local/code-ensure-no-disposables-leak-in-test.ts

@@ -0,0 +1,44 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as eslint from 'eslint';
+import { Node } from 'estree';
+
+export = new class EnsureNoDisposablesAreLeakedInTestSuite implements eslint.Rule.RuleModule {
+
+	readonly meta: eslint.Rule.RuleMetaData = {
+		type: 'problem',
+		messages: {
+			ensure: 'Suites should include a call to `ensureNoDisposablesAreLeakedInTestSuite()` to ensure no disposables are leaked in tests.'
+		},
+		fixable: 'code',
+		schema: false,
+	};
+
+	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
+		const config = <{ exclude: string[] }>context.options[0];
+
+		const needle = context.getFilename().replace(/\\/g, '/');
+		if (config.exclude.some((e) => needle.endsWith(e))) {
+			return {};
+		}
+
+		return {
+			[`Program > ExpressionStatement > CallExpression[callee.name='suite']`]: (node: Node) => {
+				const src = context.getSourceCode().getText(node)
+				if (!src.includes('ensureNoDisposablesAreLeakedInTestSuite(')) {
+					context.report({
+						node,
+						messageId: 'ensure',
+						fix: (fixer) => {
+							const updatedSrc = src.replace(/(suite\(.*\n)/, '$1\n\tensureNoDisposablesAreLeakedInTestSuite();\n');
+							return fixer.replaceText(node, updatedSrc);
+						}
+					});
+				}
+			},
+		};
+	}
+};