Skip to content

Commit 7f7061a

Browse files
authored
don't play signal if auto approve is enabled (microsoft#249394)
fix microsoft#249389
1 parent ef18b65 commit 7f7061a

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.vscode/sdfsd/test.ipynb

Whitespace-only changes.

src/vs/workbench/contrib/chat/browser/languageModelToolsService.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,9 @@ export class LanguageModelToolsService extends Disposable implements ILanguageMo
270270
model.acceptResponseProgress(request, toolInvocation);
271271

272272
if (prepared?.confirmationMessages) {
273-
this.playAccessibilitySignal([toolInvocation]);
273+
if (!toolInvocation.isConfirmed) {
274+
this.playAccessibilitySignal([toolInvocation]);
275+
}
274276
const userConfirmed = await toolInvocation.confirmed.p;
275277
if (!userConfirmed) {
276278
throw new CancellationError();
@@ -366,6 +368,10 @@ export class LanguageModelToolsService extends Disposable implements ILanguageMo
366368

367369
private playAccessibilitySignal(toolInvocations: ChatToolInvocation[]): void {
368370
const hasFocusedWindow = getFocusedWindow();
371+
const autoApproved = this._configurationService.getValue('chat.tools.autoApprove');
372+
if (autoApproved) {
373+
return;
374+
}
369375
const setting: { sound: 'auto' | 'on' | 'off' } = this._configurationService.getValue(AccessibilitySignal.chatUserActionRequired.settingsKey);
370376
if (setting.sound === 'on' || (setting.sound === 'auto' && (this._accessibilityService.isScreenReaderOptimized() || !hasFocusedWindow))) {
371377
this._accessibilitySignalService.playSignal(AccessibilitySignal.chatUserActionRequired, { customAlertMessage: this._instantiationService.invokeFunction(getToolConfirmationAlert, toolInvocations), userGesture: true });

0 commit comments

Comments
 (0)