feat: improve AI settings search tooltip label (microsoft#251163)

feat: add AI settings search loading tooltip text

Author: rzhao271

src/vs/base/browser/ui/toggle/toggle.ts

@@ -55,10 +55,12 @@ export class ToggleActionViewItem extends BaseActionViewItem {
 	constructor(context: unknown, action: IAction, options: IActionViewItemOptions) {
 		super(context, action, options);
 
+		const title = (<IActionViewItemOptions>this.options).keybinding ?
+			`${this._action.label} (${(<IActionViewItemOptions>this.options).keybinding})` : this._action.label;
 		this.toggle = this._register(new Toggle({
 			actionClassName: this._action.class,
 			isChecked: !!this._action.checked,
-			title: (<IActionViewItemOptions>this.options).keybinding ? `${this._action.label} (${(<IActionViewItemOptions>this.options).keybinding})` : this._action.label,
+			title,
 			notFocusable: true,
 			inputActiveOptionBackground: options.toggleStyles?.inputActiveOptionBackground,
 			inputActiveOptionBorder: options.toggleStyles?.inputActiveOptionBorder,
@@ -94,6 +96,12 @@ export class ToggleActionViewItem extends BaseActionViewItem {
 		this.toggle.checked = !!this._action.checked;
 	}
 
+	protected override updateLabel(): void {
+		const title = (<IActionViewItemOptions>this.options).keybinding ?
+			`${this._action.label} (${(<IActionViewItemOptions>this.options).keybinding})` : this._action.label;
+		this.toggle.setTitle(title);
+	}
+
 	override focus(): void {
 		this.toggle.domNode.tabIndex = 0;
 		this.toggle.focus();

src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts

@@ -634,11 +634,18 @@ export class SettingsEditor2 extends EditorPane {
 		if (!setupHidden && showSuggestions) {
 			const showAiResultActionClassNames = ['action-label', ThemeIcon.asClassName(preferencesAiResultsIcon)];
 			const searchServiceEnabled = this.aiSettingsSearchService.isEnabled();
+
 			this.showAiResultsAction = this._register(new Action(SETTINGS_EDITOR_COMMAND_SHOW_AI_RESULTS,
-				localize('showAiResultsDescription', "Search settings with AI"), showAiResultActionClassNames.join(' '), searchServiceEnabled
+				searchServiceEnabled
+					? localize('showAiResultsDescription', "Search settings with AI")
+					: localize('showAiResultsNotReady', "AI search functionality loading..."),
+				showAiResultActionClassNames.join(' '), searchServiceEnabled
 			));
 			this._register(this.aiSettingsSearchService.onProviderRegistered(() => {
-				this.showAiResultsAction!.enabled = true;
+				if (this.showAiResultsAction) {
+					this.showAiResultsAction.label = localize('showAiResultsDescription', "Search settings with AI");
+					this.showAiResultsAction.enabled = true;
+				}
 			}));
 			this._register(this.showAiResultsAction.onDidChange(() => {
 				this.onSearchInputChanged(true);
@@ -724,7 +731,7 @@ export class SettingsEditor2 extends EditorPane {
 					return this.instantiationService.createInstance(SettingsSearchFilterDropdownMenuActionViewItem, action, options, this.actionRunner, this.searchWidget);
 				}
 				if (this.showAiResultsAction && action.id === this.showAiResultsAction.id) {
-					return new ToggleActionViewItem(null, action, { ...options, toggleStyles: defaultToggleStyles });
+					return new ToggleActionViewItem(null, action, { ...options, keybinding: 'Ctrl+I', toggleStyles: defaultToggleStyles });
 				}
 				return undefined;
 			}