update eslint (microsoft#489)

* eslint migration

* update eslint for JavaScript

Author: aeschli

.eslintignore

@@ -7,15 +7,15 @@
         "@types/mocha": "^10.0.7",
         "@types/node": "20.x",
         "@types/assert": "^1.5.10",
-        "@typescript-eslint/eslint-plugin": "^7.14.1",
-        "@typescript-eslint/parser": "^7.11.0",
-        "eslint": "^8.57.0",
-        "glob": "^10.4.2",
-        "mocha": "^10.5.2",
-        "typescript": "^5.4.5",
-        "@vscode/test-cli": "^0.0.9",
-        "@vscode/test-electron": "^2.4.0",
-        "@vscode/test-web": "^0.0.55",
+        "@typescript-eslint/eslint-plugin": "^8.3.0",
+        "@typescript-eslint/parser": "^8.3.0",
+        "eslint": "^9.9.1",
+        "glob": "^11.0.0",
+        "mocha": "^10.7.3",
+        "typescript": "^5.5.4",
+        "@vscode/test-cli": "^0.0.10",
+        "@vscode/test-electron": "^2.4.1",
+        "@vscode/test-web": "^0.0.57",
         "@types/webpack-env": "^1.18.5",
         "@types/vscode-notebook-renderer": "^1.72.3",
         "concurrently": "^8.2.2",
@@ -25,14 +25,14 @@
         "ts-loader": "^9.5.1",
         "vscode-dts": "^0.3.3",
         "vscode-notebook-error-overlay": "^1.0.1",
-        "webpack": "^5.92.1",
+        "webpack": "^5.94.0",
         "util": "^0.12.5",
         "webpack-cli": "^5.1.4",
         "webpack-dev-server": "^5.0.4",
         "assert": "^2.1.0",
         "process": "^0.11.10",
         "npm-run-all": "^4.1.5",
-        "esbuild": "^0.21.5",
+        "esbuild": "^0.23.1",
         "@esbuild-plugins/node-globals-polyfill": "^0.2.3"
     }
 }

.eslintrc.yml

@@ -63,7 +63,7 @@ export default {
         generator.fs.copyTpl(generator.templatePath('extension.js'), generator.destinationPath('extension.js'), extensionConfig);
         generator.fs.copyTpl(generator.templatePath('package.json'), generator.destinationPath('package.json'), extensionConfig);
         generator.fs.copy(generator.templatePath('.vscode-test.mjs'), generator.destinationPath('.vscode-test.mjs'));
-        generator.fs.copyTpl(generator.templatePath('.eslintrc.json'), generator.destinationPath('.eslintrc.json'), extensionConfig);
+        generator.fs.copyTpl(generator.templatePath('eslint.config.mjs'), generator.destinationPath('eslint.config.mjs'), extensionConfig);
 
         if (extensionConfig.pkgManager === 'yarn') {
             generator.fs.copyTpl(generator.templatePath('.yarnrc'), generator.destinationPath('.yarnrc'), extensionConfig);

generators/app/dependencyVersions/package.json

@@ -64,7 +64,7 @@ export default {
         generator.fs.copyTpl(generator.templatePath('src/extension.ts'), generator.destinationPath('src/extension.ts'), extensionConfig);
         generator.fs.copy(generator.templatePath('src/test'), generator.destinationPath('src/test'));
         generator.fs.copy(generator.templatePath('.vscode-test.mjs'), generator.destinationPath('.vscode-test.mjs'));
-        generator.fs.copy(generator.templatePath('.eslintrc.json'), generator.destinationPath('.eslintrc.json'));
+        generator.fs.copy(generator.templatePath('eslint.config.mjs'), generator.destinationPath('eslint.config.mjs'));
 
         if (extensionConfig.pkgManager === 'yarn') {
             generator.fs.copyTpl(generator.templatePath('.yarnrc'), generator.destinationPath('.yarnrc'), extensionConfig);

generators/app/generate-command-js.js

@@ -65,7 +65,7 @@ export default {
             generator.fs.copy(generator.templatePath('src/web/test/suite/webpack-mochaTestRunner.ts'), generator.destinationPath('src/web/test/suite/index.ts'));
         }
 
-        generator.fs.copy(generator.templatePath('.eslintrc.json'), generator.destinationPath('.eslintrc.json'));
+        generator.fs.copy(generator.templatePath('eslint.config.mjs'), generator.destinationPath('eslint.config.mjs'));
 
         if (extensionConfig.pkgManager === 'yarn') {
             generator.fs.copyTpl(generator.templatePath('.yarnrc'), generator.destinationPath('.yarnrc'), extensionConfig);

generators/app/generate-command-ts.js

@@ -41,7 +41,7 @@ export default {
         generator.fs.copy(generator.templatePath('tsconfig.json'), generator.destinationPath('tsconfig.json'));
         generator.fs.copy(generator.templatePath('.vscodeignore'), generator.destinationPath('.vscodeignore'));
         generator.fs.copy(generator.templatePath('webpack.config.js'), generator.destinationPath('webpack.config.js'));
-        generator.fs.copy(generator.templatePath('.eslintrc.json'), generator.destinationPath('.eslintrc.json'));
+        generator.fs.copy(generator.templatePath('eslint.config.mjs'), generator.destinationPath('eslint.config.mjs'));
         generator.fs.copy(generator.templatePath('.vscode-test.mjs'), generator.destinationPath('.vscode-test.mjs'));
 
         generator.fs.copyTpl(generator.templatePath('package.json'), generator.destinationPath('package.json'), extensionConfig);

generators/app/generate-command-web.js

@@ -6,5 +6,5 @@ test/**
 vsc-extension-quickstart.md
 **/jsconfig.json
 **/*.map
-**/.eslintrc.json
+**/eslint.config.mjs
 **/.vscode-test.*

generators/app/generate-notebook-renderer.js

@@ -0,0 +1,25 @@
+import globals from "globals";
+
+export default [{
+    files: ["**/*.js"],
+    languageOptions: {
+        globals: {
+            ...globals.commonjs,
+            ...globals.node,
+            ...globals.mocha,
+        },
+
+        ecmaVersion: 2022,
+        sourceType: "module",
+    },
+
+    rules: {
+        "no-const-assign": "warn",
+        "no-this-before-super": "warn",
+        "no-undef": "warn",
+        "no-unreachable": "warn",
+        "no-unused-vars": "warn",
+        "constructor-super": "warn",
+        "valid-typeof": "warn",
+    },
+}];