The option "none" for prompt "Which bundler to use?" can be misleading (microsoft#472)

Author: aeschli

generators/app/index.js

@@ -44,7 +44,7 @@ export default class extends Generator {
         this.option('extensionDescription', { type: String, description: 'Description of the extension' });
 
         this.option('pkgManager', { type: String, description: `'npm', 'yarn' or 'pnpm'` });
-        this.option('bundler', { type: String, default: 'none', description: `Bundle the extension: 'webpack', 'esbuild', 'none` });
+        this.option('bundler', { type: String, description: `Bundle the extension: 'webpack', 'esbuild'` });
         this.option('gitInit', { type: Boolean, description: `Initialize a git repo` });
 
         this.option('snippetFolder', { type: String, description: `Snippet folder location` });

generators/app/prompts.js

@@ -161,7 +161,7 @@ export function askForPackageManager(generator, extensionConfig) {
 * @param {Generator} generator
 * @param {Object} extensionConfig
 */
-export function askForBundler(generator, extensionConfig, allowNone = true, defaultBundler = 'none') {
+export function askForBundler(generator, extensionConfig, allowNone = true, defaultBundler = 'unbundled') {
     const bundler = generator.options['bundler'];
     if (bundler === 'webpack' || bundler === 'esbuild') {
         extensionConfig.bundler = bundler;
@@ -177,7 +177,7 @@ export function askForBundler(generator, extensionConfig, allowNone = true, defa
         return Promise.resolve();
     }
 
-    const choices = allowNone ? [{ name: 'none', value: 'none' }] : [];
+    const choices = allowNone ? [{ name: 'unbundled', value: 'unbundled' }] : [];
 
     return generator.prompt({
         type: 'list',

test/test-integration.mjs

@@ -27,7 +27,7 @@ describe('integration tests', function () {
 			description: 'My TestCom',
 			gitInit: false,
 			pkgManager: 'npm',
-			bundler: 'none',
+			bundler: 'unbundled',
 			openWith: 'skip'
 		});
 

test/test.mjs

@@ -627,7 +627,7 @@ describe('test code generator', function () {
 			description: 'My TestCom',
 			gitInit: true,
 			pkgManager: 'npm',
-			bundler: 'none',
+			bundler: 'unbundled',
 			openWith: 'skip'
 		}); // Mock the prompt answers
 
@@ -690,7 +690,7 @@ describe('test code generator', function () {
 			description: 'My TestCom',
 			gitInit: false,
 			pkgManager: 'yarn',
-			bundler: 'none',
+			bundler: 'unbundled',
 			openWith: 'skip'
 		}); // Mock the prompt answers
 
@@ -770,7 +770,7 @@ describe('test code generator', function () {
 			description: 'My TestCom',
 			gitInit: false,
 			pkgManager: 'pnpm',
-			bundler: 'none',
+			bundler: 'unbundled',
 			openWith: 'skip'
 		}); // Mock the prompt answers