Skip to content

Commit 40edf2a

Browse files
committed
added in policy for secrets manager to ecs task definition
1 parent d8399bd commit 40edf2a

File tree

10 files changed

+62
-36
lines changed

10 files changed

+62
-36
lines changed

bin/deploy.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@ docker run -it -v $(pwd):/app/ cfb-build-agent ./db-create
5252
$(docker run -it -v $(pwd):/app/ -v $(pwd)/docker/aws/:/root/.aws/ -e AWS_PROFILE=$AWS_PROFILE cfb-build-agent ecr-login | tr -d '\r')
5353

5454
# Build the container image for the API
55-
docker build -f docker/Dockerfile-Bmore-Responsive -t bmore-responsive \
56-
--build-arg DB_URL=${DB_URL} .
55+
docker build -f docker/Dockerfile-Bmore-Responsive -t bmore-responsive .
5756
# Get the address of the repository in AWS
5857
CFB_REPO=$(docker run -it -v $(pwd):/app/ -v $(pwd)/docker/aws/:/root/.aws/ -e AWS_PROFILE=$AWS_PROFILE cfb-build-agent output full-cluster bmore-responsive_registry | tr -d '\r')
5958
# Tag the image for pushing

bin/redeploy.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,21 @@ docker build -f docker/Dockerfile-Builder -t cfb-build-agent .
1212

1313

1414
# Rebuild the Java Projects
15-
docker run -it -v $(pwd):/app/ cfb-build-agent npm-build
15+
#docker run -it -v $(pwd):/app/ cfb-build-agent npm-build
1616

1717

1818
### Building and Pushing Docker Images ###
1919
# Log into the ECS Repository first
2020
$(docker run -it -v $(pwd):/app/ -v $(pwd)/docker/aws/:/root/.aws/ -e AWS_PROFILE=$AWS_PROFILE cfb-build-agent ecr-login | tr -d '\r')
2121

2222
# Build the container image
23-
docker build -f docker/Dockerfile-Bmore-Responsive -t bmore-responsive \
24-
--build-arg DB_URL="postgres://${DB_USERNAME}:${DB_PASSWORD}@${DB_ENDPOINT}:${DB_PORT}/${DB_NAME}" .
23+
docker build -f docker/Dockerfile-Bmore-Responsive -t bmore-responsive .
2524
# Get the address of the repository in AWS
2625
CFB_REPO=$(docker run -it -v $(pwd):/app/ -v $(pwd)/docker/aws/:/root/.aws/ -e AWS_PROFILE=$AWS_PROFILE cfb-build-agent output full-cluster bmore-responsive_registry | tr -d '\r')
26+
echo "CFB_REPO -> $CFB_REPO"
27+
2728
# Tag the image for pushing
28-
docker tag bmore-responsive $CFB_REPO:latest
29+
docker tag bmore-responsive:latest $CFB_REPO:latest
2930
# Push the new docker image
3031
docker push $CFB_REPO
3132

docker-compose.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
version: '3'
22
services:
33
api:
4-
build: .
4+
image: 180104022864.dkr.ecr.us-east-2.amazonaws.com/bmore-responsive
55
depends_on:
66
- db
77
links:
88
- "db: database"
99
ports:
10-
- '3000:3000'
10+
- '8080:80'
1111
command: >
1212
sh -c "npm run db-delete &&
1313
npm run db-create &&

docker/Dockerfile-Builder

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ RUN apt-get update && apt-get install wget python3-pip -y
55

66
# Download Terraform and make it executable.
77
WORKDIR /tmp/
8-
RUN wget -O terraform.zip https://releases.hashicorp.com/terraform/0.11.13/terraform_0.11.13_linux_amd64.zip
8+
RUN wget -O terraform.zip https://releases.hashicorp.com/terraform/0.12.24/terraform_0.12.24_linux_amd64.zip
99
RUN unzip terraform.zip
1010
RUN mv terraform /usr/bin/terraform
1111

docker/aws/config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
[default]
2-
region=us-east-1
2+
region=us-east-2
33
output=json

terraform/components/full-cluster/main.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ data "template_file" "cfb_ecs_task_definition" {
4040
}
4141

4242
resource "aws_secretsmanager_secret" "db_password" {
43-
name = "db_password"
43+
name_prefix = "db_password"
44+
4445
}
4546

4647
resource "aws_secretsmanager_secret_version" "db_password" {

terraform/components/full-cluster/matching-container.json.tpl

Lines changed: 0 additions & 25 deletions
This file was deleted.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
{
2+
"Version": "2012-10-17",
3+
"Statement": [
4+
{
5+
"Effect": "Allow",
6+
"Action": [
7+
"ssm:GetParameters",
8+
"secretsmanager:GetSecretValue",
9+
"kms:Decrypt"
10+
],
11+
"Resource": [
12+
"*"
13+
]
14+
}
15+
]
16+
}

terraform/modules/ecs/main.tf

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,13 +148,43 @@ EOF
148148

149149
}
150150

151+
resource "aws_iam_role" "task_execution_role" {
152+
name = "ecsTaskExecutionRole"
153+
assume_role_policy = <<EOF
154+
{
155+
"Version": "2012-10-17",
156+
"Statement": [
157+
{
158+
"Effect": "Allow",
159+
"Principal": {
160+
"AWS": "${aws_iam_role.ecs_cluster.arn}"
161+
},
162+
"Action": [
163+
"ssm:GetParameters",
164+
"secretsmanager:GetSecretValue",
165+
"kms:Decrypt"
166+
]
167+
}
168+
]
169+
}
170+
EOF
171+
}
172+
173+
resource "aws_iam_role_policy_attachment" "task_execution_attachment" {
174+
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy" // AWS provided policy
175+
role = "${aws_iam_role.task_execution_role.name}"
176+
}
177+
178+
151179
resource "aws_ecs_cluster" "ecs_cluster" {
152180
name = var.cluster_name
153181
}
154182

155183
resource "aws_ecs_task_definition" "bmore-responsive_ecs_task_definition" {
156184
family = "bmore-responsive"
157185
container_definitions = var.bmore-responsive_container_definitions
186+
task_role_arn = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"
187+
execution_role_arn = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"
158188
}
159189

160190
resource "aws_ecs_service" "pricer_ecs_service" {

terraform/versions.tf

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
2+
terraform {
3+
required_version = ">= 0.12"
4+
}

0 commit comments

Comments
 (0)