library-api: rename HomesteadExemption to PhlHomesteadExemption

prestoncabe · prestoncabe · commit 9fd27a8fbe06 · 2025-11-15T16:43:07.000-05:00
diff --git a/library-api/src/main/java/org/codeforphilly/bdt/api/DMNSchemaResolver.java b/library-api/src/main/java/org/codeforphilly/bdt/api/DMNSchemaResolver.java
@@ -231,7 +231,7 @@ private Object generatePrimitiveExample(String fieldName, String type, String fo
                 if (fieldName.contains("Id") || fieldName.equals("id")) {
                     return "p1";
                 } else if (fieldName.contains("benefit") || fieldName.contains("Benefit")) {
-                    return "HomesteadExemption";
+                    return "PhlHomesteadExemption";
                 } else if (fieldName.contains("type")) {
                     return "spouse";
                 }
diff --git a/library-api/src/main/java/org/codeforphilly/bdt/api/DynamicDMNOpenAPIFilter.java b/library-api/src/main/java/org/codeforphilly/bdt/api/DynamicDMNOpenAPIFilter.java
@@ -431,7 +431,7 @@ private Schema createDMNContextSchema(ModelInfo model, String inputRef, String o
                 // Check if output schema has properties (multiple output decisions like checks + isEligible)
                 if (outputSchemaNode.has("properties")) {
                     // Multiple outputs: add each property directly to context
-                    // This handles Decision Services with multiple output decisions (e.g., HomesteadExemption)
+                    // This handles Decision Services with multiple output decisions (e.g., PhlHomesteadExemption)
                     com.fasterxml.jackson.databind.JsonNode outputProps = outputSchemaNode.get("properties");
                     outputProps.fields().forEachRemaining(entry -> {
                         Schema propSchema = convertJsonNodeToSchema(entry.getValue());
diff --git a/library-api/src/main/java/org/codeforphilly/bdt/api/ModelInfo.java b/library-api/src/main/java/org/codeforphilly/bdt/api/ModelInfo.java
@@ -47,7 +47,7 @@ public String getPath() {
      * Extract category/tag from the path for OpenAPI grouping.
      * Examples:
      * - "checks/age/PersonMinAge" -> "Age Checks"
-     * - "benefits/pa/philadelphia/HomesteadExemption" -> "Benefits"
+     * - "benefits/pa/philadelphia/PhlHomesteadExemption" -> "Benefits"
      */
     public String getCategory() {
         if (path == null || path.isEmpty()) {
diff --git a/library-api/src/main/resources/benefits/pa/philadelphia/PhlHomesteadExemption.dmn b/library-api/src/main/resources/benefits/pa/philadelphia/PhlHomesteadExemption.dmn
@@ -1,12 +1,12 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="https://kie.apache.org/dmn/_128BAC16-3FFC-4BF4-ADEC-BE9FFE4EDE17" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:included1="https://kie.apache.org/dmn/_9514D95A-63FB-4345-911B-D83E1867F709" xmlns:included2="https://kie.apache.org/dmn/_3B9E68B5-63FA-437C-AF93-CC12DDD00BC5" xmlns:included3="https://kie.apache.org/dmn/_1B91A885-130A-4E0B-A762-E12AA6DD5C79" id="_EBE7464A-5EB0-4D71-B00F-0B29543EB38B" name="HomesteadExemption" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="https://kie.apache.org/dmn/_128BAC16-3FFC-4BF4-ADEC-BE9FFE4EDE17">
+<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="https://kie.apache.org/dmn/_128BAC16-3FFC-4BF4-ADEC-BE9FFE4EDE17" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:included1="https://kie.apache.org/dmn/_9514D95A-63FB-4345-911B-D83E1867F709" xmlns:included2="https://kie.apache.org/dmn/_3B9E68B5-63FA-437C-AF93-CC12DDD00BC5" xmlns:included3="https://kie.apache.org/dmn/_1B91A885-130A-4E0B-A762-E12AA6DD5C79" id="_EBE7464A-5EB0-4D71-B00F-0B29543EB38B" name="PhlHomesteadExemption" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="https://kie.apache.org/dmn/_128BAC16-3FFC-4BF4-ADEC-BE9FFE4EDE17">
   <dmn:extensionElements/>
   <dmn:import id="_1DB4F630-D116-45DB-8738-AA029CD7BEED" name="Benefits" namespace="https://kie.apache.org/dmn/_9514D95A-63FB-4345-911B-D83E1867F709" locationURI="../../Benefits.dmn" importType="http://www.omg.org/spec/DMN/20180521/MODEL/"/>
   <dmn:import id="_FC7539DB-FB6D-419C-9CE8-46456B53FC97" name="PersonNotEnrolledInBenefit" namespace="https://kie.apache.org/dmn/_3B9E68B5-63FA-437C-AF93-CC12DDD00BC5" locationURI="../../../checks/enrollment/PersonNotEnrolledInBenefit.dmn" importType="http://www.omg.org/spec/DMN/20180521/MODEL/"/>
   <dmn:import id="_B4BB17BE-CD12-4C1A-BCDE-70E6D71373C7" name="BDT" namespace="https://kie.apache.org/dmn/_1B91A885-130A-4E0B-A762-E12AA6DD5C79" locationURI="../../../BDT.dmn" importType="http://www.omg.org/spec/DMN/20180521/MODEL/"/>
-  <dmn:decisionService id="_1A77F60B-62BC-49AB-9233-5AD89A72C7F3" name="HomesteadExemptionService">
+  <dmn:decisionService id="_1A77F60B-62BC-49AB-9233-5AD89A72C7F3" name="PhlHomesteadExemptionService">
     <dmn:extensionElements/>
-    <dmn:variable id="_1701CE79-1E46-4807-901C-A5E3C45EBA9E" name="HomesteadExemptionService" typeRef="Benefits.tBenefitResponse"/>
+    <dmn:variable id="_1701CE79-1E46-4807-901C-A5E3C45EBA9E" name="PhlHomesteadExemptionService" typeRef="Benefits.tBenefitResponse"/>
     <dmn:outputDecision href="#_38277B56-7BEA-4297-A8B5-BBF084A043E8"/>
     <dmn:outputDecision href="#_51D3A9BB-4110-42E1-86CF-77FCA5DACE9A"/>
     <dmn:inputData href="#_2011065F-8B21-49FE-8685-D7566CCA1D60"/>
diff --git a/library-api/src/main/resources/benefits/pa/philadelphia/PhlHomesteadExemption.jsonc b/library-api/src/main/resources/benefits/pa/philadelphia/PhlHomesteadExemption.jsonc
@@ -1,5 +1,5 @@
 {
-  "name": "HomesteadExemption",
+  "name": "PhlHomesteadExemption",
   "checks": {
     "Not Already On Homestead": {
       // service key is special; should be the name of a DMN model that implements a "main" decision service
diff --git a/library-api/src/main/resources/checks-examples.md b/library-api/src/main/resources/checks-examples.md
@@ -105,10 +105,10 @@
 ### "Primary person already receives Homestead Exemption"
 
 - personId: situation.primaryPersonId
-- benefit: "phlHomesteadExemption"
+- benefit: "PhlHomesteadExemption"
 
 ## SomeoneEnrolledInBenefit
 ### "At least one child is already enrolled in Philly Pre-K"
 
 - peopleIds: situation.people[BDT.age as of date(item.dateOfBirth, today()) < 18].id
-- benefit: "phlPreK"
+- benefit: "PhlPreK"
diff --git a/library-api/test/bdt/benefits/pa/philadelphia/PhlHomesteadExemption/Smoke Test.bru b/library-api/test/bdt/benefits/pa/philadelphia/PhlHomesteadExemption/Smoke Test.bru
@@ -5,7 +5,7 @@ meta {
 }
 
 post {
-  url: {{host}}/benefits/pa/philadelphia/HomesteadExemption
+  url: {{host}}/benefits/pa/philadelphia/PhlHomesteadExemption
   body: json
   auth: inherit
 }

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ private Object generatePrimitiveExample(String fieldName, String type, String fo`
`231`	`231`	`if (fieldName.contains("Id") \|\| fieldName.equals("id")) {`
`232`	`232`	`return "p1";`
`233`	`233`	`} else if (fieldName.contains("benefit") \|\| fieldName.contains("Benefit")) {`
`234`		`- return "HomesteadExemption";`
	`234`	`+ return "PhlHomesteadExemption";`
`235`	`235`	`} else if (fieldName.contains("type")) {`
`236`	`236`	`return "spouse";`
`237`	`237`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "name": "HomesteadExemption",`
	`2`	`+ "name": "PhlHomesteadExemption",`
`3`	`3`	`"checks": {`
`4`	`4`	`"Not Already On Homestead": {`
`5`	`5`	`// service key is special; should be the name of a DMN model that implements a "main" decision service`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ meta {`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`post {`
`8`		`- url: {{host}}/benefits/pa/philadelphia/HomesteadExemption`
	`8`	`+ url: {{host}}/benefits/pa/philadelphia/PhlHomesteadExemption`
`9`	`9`	`body: json`
`10`	`10`	`auth: inherit`
`11`	`11`	`}`