Skip to content

Commit 21c7339

Browse files
committed
Update chart descritpion labels
1 parent 5341b1d commit 21c7339

File tree

5 files changed

+32
-20
lines changed

5 files changed

+32
-20
lines changed

src/app.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,16 +48,16 @@
4848
use_container_width=True,
4949
)
5050

51-
st.markdown(chart_descriptions(new_admit_chart))
51+
st.markdown(chart_descriptions(new_admit_chart, p.labels))
5252

5353
if st.checkbox("Show Projected Admissions in tabular form"):
5454
if st.checkbox("Show Daily Counts"):
55-
draw_projected_admissions_table(st, m.admits_df, as_date=p.as_date, daily_count=True)
55+
draw_projected_admissions_table(st, m.admits_df, p.labels, as_date=p.as_date, daily_count=True)
5656
else:
57-
draw_projected_admissions_table(st, m.admits_df, as_date=p.as_date, daily_count=False)
57+
draw_projected_admissions_table(st, m.admits_df, p.labels, as_date=p.as_date, daily_count=False)
5858
build_download_link(st,
5959
filename="projected_admissions.csv",
60-
df=admissions_df,
60+
df=m.admits_df,
6161
parameters=p
6262
)
6363
st.subheader("Admitted Patients (Census)")
@@ -69,15 +69,15 @@
6969
admitted_patients_chart(alt=alt, census=m.census_df, parameters=p),
7070
use_container_width=True,
7171
)
72-
st.markdown(chart_descriptions(census_chart, suffix=" Census"))
72+
st.markdown(chart_descriptions(census_chart, p.labels, suffix=" Census"))
7373
if st.checkbox("Show Projected Census in tabular form"):
7474
if st.checkbox("Show Daily Census Counts"):
75-
draw_census_table(st, m.census_df, as_date=p.as_date, daily_count=True)
75+
draw_census_table(st, m.census_df, p.labels, as_date=p.as_date, daily_count=True)
7676
else:
77-
draw_census_table(st, m.census_df, as_date=p.as_date, daily_count=False)
77+
draw_census_table(st, m.census_df, p.labels, as_date=p.as_date, daily_count=False)
7878
build_download_link(st,
7979
filename="projected_census.csv",
80-
df=census_df,
80+
df=m.census_df,
8181
parameters=p
8282
)
8383

src/penn_chime/charts.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def additional_projections_chart(
129129
)
130130

131131

132-
def chart_descriptions(chart: Chart, suffix: str = ""):
132+
def chart_descriptions(chart: Chart, labels, suffix: str = ""):
133133
"""
134134
135135
:param chart: Chart: The alt chart to be used in finding max points
@@ -156,7 +156,7 @@ def chart_descriptions(chart: Chart, suffix: str = ""):
156156

157157
messages.append(
158158
"{}{} peaks at {:,} on day {}{}".format(
159-
col,
159+
labels[col],
160160
suffix,
161161
ceil(chart.data[col].max()),
162162
on,

src/penn_chime/parameters.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,17 @@ def __init__(
4545
self.n_days = n_days
4646
self.recovery_days = recovery_days
4747

48+
self.labels = {
49+
"hospitalized": "Hospitalized",
50+
"icu": "ICU",
51+
"ventilated": "Ventilated",
52+
"day": "Day",
53+
"date": "Date",
54+
"susceptible": "Susceptible",
55+
"infected": "Infected",
56+
"recovered": "Recovered",
57+
}
58+
4859
self.dispositions = {
4960
"hospitalized": hospitalized,
5061
"icu": icu,

src/penn_chime/presentation.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ def show_additional_projections(
391391

392392

393393
def draw_projected_admissions_table(
394-
st, projection_admits: pd.DataFrame, as_date: bool = False, daily_count: bool = False,
394+
st, projection_admits: pd.DataFrame, labels, as_date: bool = False, daily_count: bool = False,
395395
):
396396
if daily_count == True:
397397
admits_table = projection_admits[np.mod(projection_admits.index, 1) == 0].copy()
@@ -405,11 +405,12 @@ def draw_projected_admissions_table(
405405
admits_table = add_date_column(
406406
admits_table, drop_day_column=True, date_format=DATE_FORMAT
407407
)
408+
admits_table.rename(labels)
408409
st.table(admits_table)
409410
return None
410411

411412

412-
def draw_census_table(st, census_df: pd.DataFrame, as_date: bool = False, daily_count: bool = False):
413+
def draw_census_table(st, census_df: pd.DataFrame, labels, as_date: bool = False, daily_count: bool = False):
413414
if daily_count == True:
414415
census_table = census_df[np.mod(census_df.index, 1) == 0].copy()
415416
else:
@@ -423,6 +424,7 @@ def draw_census_table(st, census_df: pd.DataFrame, as_date: bool = False, daily_
423424
census_table, drop_day_column=True, date_format=DATE_FORMAT
424425
)
425426

427+
census_table.rename(labels)
426428
st.table(census_table)
427429
return None
428430

tests/test_app.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -234,12 +234,11 @@ def test_model(model=MODEL, param=PARAM):
234234
assert (diff.abs() < 0.1).all()
235235

236236

237-
def test_chart_descriptions():
237+
def test_chart_descriptions(p=PARAM):
238238
# new admissions chart
239239
projection_admits = pd.read_csv('tests/projection_admits.csv')
240-
# projection_admits = projection_admits.rename(columns={'hospitalized': 'Hospitalized', 'icu': 'ICU', 'ventilated': 'Ventilated'})
241-
chart = new_admissions_chart(alt, projection_admits, PARAM)
242-
description = chart_descriptions(chart)
240+
chart = new_admissions_chart(alt, projection_admits, p)
241+
description = chart_descriptions(chart, p.labels)
243242

244243
hosp, icu, vent, asterisk = description.split("\n\n") # break out the description into lines
245244

@@ -256,16 +255,16 @@ def test_chart_descriptions():
256255

257256
projection_admits = pd.read_csv('tests/projection_admits.csv')
258257
# projection_admits = projection_admits.rename(columns={'hospitalized': 'Hospitalized', 'icu': 'ICU', 'ventilated': 'Ventilated'})
259-
chart = new_admissions_chart(alt, projection_admits, PARAM)
260-
description = chart_descriptions(chart)
258+
chart = new_admissions_chart(alt, projection_admits, p)
259+
description = chart_descriptions(chart, p.labels)
261260
assert "*" not in description
262261

263262
# census chart
264263
census_df = pd.read_csv('tests/census_df.csv')
265264
# census_df = census_df.rename(columns={'hospitalized': 'Hospitalized', 'icu': 'ICU', 'ventilated': 'Ventilated'})
266265
PARAM.as_date = True
267-
chart = admitted_patients_chart(alt, census_df, PARAM)
268-
description = chart_descriptions(chart)
266+
chart = admitted_patients_chart(alt, census_df, p)
267+
description = chart_descriptions(chart, p.labels)
269268

270269
assert str(ceil(chart.data['ventilated'].max())) in description
271270
assert str(chart.data['icu'].idxmax()) not in description

0 commit comments

Comments
 (0)