Skip to content

Commit 4ba3bed

Browse files
authored
Merge pull request #512 from CodeForPhilly/dsgit1-patch-2
Included contributor checklist from Mozilla
2 parents 225879d + 409533b commit 4ba3bed

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

docs/CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,12 @@ As of March 21, help is especially wanted from contributors with experience in K
2626

2727
- [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [CodeforPhilly/chime](https://github.com/CodeForPhilly/chime) repo.
2828
- Base your work on the `develop` branch.
29+
- Take a few minutes to review this [resource](https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Reviewer_Checklist) for contributors and reviewers, to accelerate the adoption of your contribution (thanks to the good folks at Mozilla for this).
2930
- Submit pull requests from your fork, also against the `develop` branch of the `CodeforPhilly/chime` repo.
3031
- Request review from the relevant maintainer(s).
3132
- Check your pull request periodically to see if any changes have been requested or any merge conflicts have arisen.
3233
- If a merge conflict arises, rebase against the latest `develop` branch and force-push the new branch as early as you can. You may need to do this more than once before your changes get merged. Do your best to keep your branch in a mergeable state until it is finished being reviewed and accepted.
33-
- If your change affects the results calculated or presented, update `change_date` in `src/penn_chime/parameters.py` when the pull request is ready for merge, so users can see when results have last changed
34+
- If your change affects the results calculated or presented, update `change_date` in `src/penn_chime/constants.py` when the pull request is ready for merge, so users can see when results have last changed
3435
- Note: Frequent contributors with write access can submit pull requests from a new branch in the `CodeforPhilly/chime` repository.
3536

3637
## Review & Release

0 commit comments

Comments
 (0)