Skip to content

Commit 6d4913f

Browse files
committed
Remove assignemt to self.raw from run_projection
1 parent e3597f8 commit 6d4913f

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/penn_chime/models.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,10 @@ def __init__(self, p: Parameters):
6969
self.beta_t = get_beta(intrinsic_growth_rate, self.gamma, self.susceptible, p.relative_contact_rate)
7070

7171
self.i_day = 0 # seed to the full length
72-
self.run_projection(p, [(self.beta, p.n_days)])
73-
self.i_day = i_day = int(get_argmin_ds(self.raw["census_hospitalized"], p.current_hospitalized))
72+
raw = self.run_projection(p, [(self.beta, p.n_days)])
73+
self.i_day = i_day = int(get_argmin_ds(raw["census_hospitalized"], p.current_hospitalized))
7474

75-
self.run_projection(p, self.gen_policy(p))
75+
self.raw = self.run_projection(p, self.gen_policy(p))
7676

7777
logger.info('Set i_day = %s', i_day)
7878
p.date_first_hospitalized = p.current_date - timedelta(days=i_day)
@@ -109,7 +109,7 @@ def __init__(self, p: Parameters):
109109
intrinsic_growth_rate = get_growth_rate(p.doubling_time)
110110
self.beta = get_beta(intrinsic_growth_rate, self.gamma, self.susceptible, 0.0)
111111
self.beta_t = get_beta(intrinsic_growth_rate, self.gamma, self.susceptible, p.relative_contact_rate)
112-
self.run_projection(p, self.gen_policy(p))
112+
self.raw = self.run_projection(p, self.gen_policy(p))
113113

114114
self.population = p.population
115115
else:
@@ -160,14 +160,14 @@ def get_argmin_doubling_time(self, p: Parameters, dts):
160160
self.beta = get_beta(intrinsic_growth_rate, self.gamma, self.susceptible, 0.0)
161161
self.beta_t = get_beta(intrinsic_growth_rate, self.gamma, self.susceptible, p.relative_contact_rate)
162162

163-
self.run_projection(p, self.gen_policy(p))
163+
raw = self.run_projection(p, self.gen_policy(p))
164164

165165
# Skip values the would put the fit past peak
166-
peak_admits_day = self.raw["admits_hospitalized"].argmax()
166+
peak_admits_day = raw["admits_hospitalized"].argmax()
167167
if peak_admits_day < 0:
168168
continue
169169

170-
loss = self.get_loss()
170+
loss = self.get_loss(raw)
171171
losses[i] = loss
172172

173173
min_loss = pd.Series(losses).argmin()
@@ -206,11 +206,11 @@ def run_projection(self, p: Parameters, policy: Sequence[Tuple[float, int]]):
206206
calculate_admits(raw, self.rates)
207207
calculate_census(raw, self.days)
208208

209-
self.raw = raw
209+
return raw
210210

211-
def get_loss(self) -> float:
211+
def get_loss(self, raw) -> float:
212212
"""Squared error: predicted vs. actual current hospitalized."""
213-
predicted = self.raw["census_hospitalized"][self.i_day]
213+
predicted = raw["census_hospitalized"][self.i_day]
214214
return (self.current_hospitalized - predicted) ** 2.0
215215

216216

0 commit comments

Comments
 (0)