Make all the non-OptionalFoo validators explcitly check for None, to get cleaner error reports

Author: PhilMiller

src/penn_chime/parameters.py

@@ -85,7 +85,7 @@ def __init__(self, **kwargs):
             try:
                 validator(value=value)
             except (TypeError, ValueError) as ve:
-                raise ValueError(f"For parameter {key}, with value {value}, validation returned error \"{ve}\"")
+                raise ValueError(f"For parameter '{key}', with value '{value}', validation returned error \"{ve}\"")
             setattr(self, key, value)
 
         if self.region is  None and self.population is None:

src/penn_chime/validators/validators.py

@@ -32,6 +32,8 @@ def __init__(
 
     def validate(self, value):
         """This method implicitly validates isinstance(value, (float, int)) because it will throw a TypeError on comparison"""
+        if value is None:
+            raise ValueError(f"This parameter must be set")
         if (self.upper_bound is not None and value > self.upper_bound) \
            or (self.lower_bound is not None and value < self.lower_bound):
             raise ValueError(f"{value} needs to be {self.message[(self.lower_bound, self.upper_bound)]}.")
@@ -56,6 +58,8 @@ def __init__(self) -> None:
         pass
 
     def validate(self, value):
+        if value is None:
+            raise ValueError(f"This parameter must be set")
         if 0 > value or value > 1:
             raise ValueError(f"{value} needs to be a rate (i.e. in [0,1]).")
 
@@ -65,6 +69,8 @@ def __init__(self) -> None:
         pass
 
     def validate(self, value):
+        if value is None:
+            raise ValueError(f"This parameter must be set")
         if not isinstance(value, (date, datetime)):
             raise (ValueError(f"{value} must be a date or datetime object."))
 
@@ -82,5 +88,7 @@ def __init__(self) -> None:
         pass
 
     def validate(self, value):
+        if value is None:
+            raise ValueError(f"This parameter must be set")
         Bounded(lower_bound=EPSILON)(value=value.days)
         Rate()(value=value.rate)