Skip to content

Commit a6e43fa

Browse files
Merge pull request #523 from CodeForPhilly/dsgit1-patch-2
Developer guidelines on documentation to support pull requests
2 parents 5a60be8 + 849e3fc commit a6e43fa

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

docs/CONTRIBUTING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ As of March 21, help is especially wanted from contributors with experience in K
2828
- Base your work on the `develop` branch.
2929
- Take a few minutes to review this [resource](https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Reviewer_Checklist) for contributors and reviewers, to accelerate the adoption of your contribution (thanks to the good folks at Mozilla for this).
3030
- Submit pull requests from your fork, also against the `develop` branch of the `CodeforPhilly/chime` repo.
31+
- As part of your pull request, please ensure you provide the following information
32+
- References to the issue/PR resolved with your contribution(s) (use key word e.g. Fixes #123, #321 See #213)
33+
- Explicitly identify the scope/area the change impacts (ex: Operations/Deployment/Model/Documentation)
34+
- Describe any necessary follow on work, ideally with links to any already open issues
3135
- Request review from the relevant maintainer(s).
3236
- Check your pull request periodically to see if any changes have been requested or any merge conflicts have arisen.
3337
- If a merge conflict arises, rebase against the latest `develop` branch and force-push the new branch as early as you can. You may need to do this more than once before your changes get merged. Do your best to keep your branch in a mergeable state until it is finished being reviewed and accepted.

0 commit comments

Comments
 (0)