Skip to content

Commit c8551cd

Browse files
committed
Merge branch 'develop' of github.com:CodeForPhilly/chime into move_computation
2 parents 4c0d37e + a04868a commit c8551cd

File tree

4 files changed

+58
-4
lines changed

4 files changed

+58
-4
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
---
2+
name: General bug report
3+
about: Create an report to help us improve.
4+
title: [bug]
5+
labels: 'bug'
6+
assignees: ''
7+
8+
---
9+
10+
<!--
11+
Before you begin, please help us manage volume by checking if this could be submitted another way:
12+
- Usage questions? Ask in Slack [#chime-help](https://codeforphilly.org/chat?channel=chime-help).
13+
- Feature ideas? Propose in Slack for discussion.
14+
- Is this something you can debug and fix? Pull requests are very welcome.
15+
-->
16+
17+
### Description:
18+
19+
### Steps to reproduce:
20+
1.
21+
2.
22+
3.
23+
24+
### Expected behavior:
25+
26+
### What I got instead:
27+
(screenshots if applicable)

.github/ISSUE_TEMPLATE/model.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
---
2+
name: Bug report for model
3+
about: Feedback or bug report for the epidemiological model and analysis.
4+
title: [model]
5+
labels: 'models'
6+
assignees: ''
7+
8+
---
9+
10+
<!--
11+
Please note: Any changes to the model have a huge impact on rapidly evolving hospital system & public health decisions. The current model has been in use for a while now, and it has been validated against other similar models, so any changes to the model must meet a very high bar.
12+
13+
However, these 2 types of issue reports are very welcome:
14+
- Bugs causing this model to produce invalid results. In this case, please include details and a suggested fix.
15+
- If this model is producing a significantly different result than another well-known epidemiological model. In this case, please include proof of this difference and a suggested fix to our approach.
16+
17+
For questions or early discussion, please join us in [#chime-analysis](https://codeforphilly.org/chat?channel=chime-analysis) in Slack instead.
18+
-->
19+
20+
### Summary
21+
22+
23+
### Additional details
24+
25+
26+
### Suggested fix

script/server

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/usr/bin/env sh
1+
#!/usr/bin/env bash
22

33
# script/server: Launch the application and any extra required processes
44
# locally.

src/penn_chime/charts.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
from .parameters import Parameters
99
from .utils import add_date_column
10+
from .presentation import DATE_FORMAT
1011

1112

1213
def new_admissions_chart(
@@ -26,7 +27,7 @@ def new_admissions_chart(
2627
tooltip_dict = {False: "day", True: "date:T"}
2728
if as_date:
2829
projection_admits = add_date_column(projection_admits)
29-
x_kwargs = {"shorthand": "date:T", "title": "Date"}
30+
x_kwargs = {"shorthand": "date:T", "title": "Date", "axis": alt.Axis(format=(DATE_FORMAT))}
3031
else:
3132
x_kwargs = {"shorthand": "day", "title": "Days from today"}
3233

@@ -59,7 +60,7 @@ def admitted_patients_chart(
5960
as_date = parameters.as_date
6061
if as_date:
6162
census = add_date_column(census)
62-
x_kwargs = {"shorthand": "date:T", "title": "Date"}
63+
x_kwargs = {"shorthand": "date:T", "title": "Date", "axis": alt.Axis(format=(DATE_FORMAT))}
6364
idx = "date:T"
6465
else:
6566
x_kwargs = {"shorthand": "day", "title": "Days from today"}
@@ -107,7 +108,7 @@ def additional_projections_chart(
107108

108109
if as_date:
109110
dat = add_date_column(dat)
110-
x_kwargs = {"shorthand": "date:T", "title": "Date"}
111+
x_kwargs = {"shorthand": "date:T", "title": "Date", "axis": alt.Axis(format=(DATE_FORMAT))}
111112
else:
112113
x_kwargs = {"shorthand": "day", "title": "Days from today"}
113114

0 commit comments

Comments
 (0)