Skip to content

Commit b0d9cf0

Browse files
Merge pull request #1084 from CodeForPhilly/staging
Weekly PR from Staging to Main
2 parents b7cdd74 + c38bf92 commit b0d9cf0

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

docs/CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,12 @@ To ensure smooth contributions to the Clean & Green Philly project, please follo
2222
- Clone your fork of the repository to your local machine using `git clone`
2323
- Keep your fork up to date with the original repository by following the instructions [here](https://docs.github.com/en/get-started/quickstart/fork-a-repo#keep-your-fork-synced)
2424
- [ ] **Set up your local environment**: Follow instructions in the [SETUP](/docs/SETUP) folder
25+
- [ ] **Make sure you're up-to-date with the `staging` branch** To maintain repo organization and protection, merges to main are not allowed. All changes must be made through pull requests to the `staging` branch.
2526
- [ ] **Create a new branch**:
2627
- Name it `<github-username>/<issue-number>-<kebab-case-description>`
2728
- Example: `vimusds/1069-fix-territory-on-mobile`
2829
- [ ] **Work on the issue**: Make your changes, commit them, and push to your branch
29-
- [ ] **Open a Pull Request (PR)**: Use the provided template, tag relevant issues, and provide testing instructions
30+
- [ ] **Open a Pull Request (PR)**: Use the provided template, tag relevant issues, and provide testing instructions. Make sure the base branch of the PR is set to `base: staging`.
3031
- [ ] **Ensure all checks pass**: Fix any errors and re-check
3132
- [ ] **Tag reviewers**: Find appropriate reviewers from the [CODEOWNERS](https://github.com/CodeForPhilly/vacant-lots-proj/blob/main/.github/CODEOWNERS) file
3233
- [ ] **Close the issue**: Once your PR is merged, comment on the issue to close it, tagging the relevant reviewer(s)

src/app/globals.css

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,23 @@
44

55
@font-face {
66
font-family: 'HK Grotesk';
7-
src:
8-
url('/fonts/hkgrotesk-bold-webfont.woff2') format('woff2'),
7+
src: url('/fonts/hkgrotesk-bold-webfont.woff2') format('woff2'),
98
url('/fonts/hkgrotesk-bold-webfont.woff') format('woff');
109
font-weight: bold;
1110
font-style: normal;
1211
}
1312

1413
@font-face {
1514
font-family: 'HK Grotesk';
16-
src:
17-
url('/fonts/hkgrotesk-extrabold-webfont.woff2') format('woff2'),
15+
src: url('/fonts/hkgrotesk-extrabold-webfont.woff2') format('woff2'),
1816
url('/fonts/hkgrotesk-extrabold-webfont.woff') format('woff');
1917
font-weight: 800;
2018
font-style: normal;
2119
}
2220

2321
@font-face {
2422
font-family: 'HK Grotesk';
25-
src:
26-
url('/fonts/hkgrotesk-regular-webfont.woff2') format('woff2'),
23+
src: url('/fonts/hkgrotesk-regular-webfont.woff2') format('woff2'),
2724
url('/fonts/hkgrotesk-regular-webfont.woff') format('woff');
2825
font-weight: normal;
2926
font-style: normal;
@@ -147,7 +144,7 @@
147144
/* added webkit transform to remove icon movement in safari */
148145

149146
.iconLink {
150-
@apply text-gray-900 items-center active:bg-gray-100 active:text-green-700 focus:text-green-700 focus:bg-green-100 bg-color-none hover:bg-gray-10 rounded-medium max-sm:hover:bg-gray-0;
147+
@apply text-gray-900 items-center active:bg-gray-100 active:text-green-700 focus:text-green-700 focus:bg-green-100 bg-color-none hover:bg-gray-10 rounded-medium;
151148
transform: translateZ(0);
152149
-webkit-transform: translateZ(0);
153150
}

src/components/MobileNav.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ const MobileNav: FC = () => {
4545
as="nav"
4646
aria-label={isMenuOpen ? 'Close menu' : 'Open menu'}
4747
className="min-[850px]:hidden flex-end w-fit"
48+
tabIndex={0}
4849
icon={
4950
<>
5051
<PiList className="h-6 w-6 linkIcon" /> Menu

0 commit comments

Comments
 (0)