fix: update function signature for checkWriteAccess

themightychris · themightychris · commit 9cbf9030e0f4 · 2019-02-05T20:00:12.000-05:00
diff --git a/php-classes/Laddr/ProjectBuzzRequestHandler.php b/php-classes/Laddr/ProjectBuzzRequestHandler.php
@@ -44,7 +44,7 @@ protected static function onRecordSaved(ActiveRecord $Buzz, $requestData)
         $Buzz->save();
     }
 
-    public static function checkWriteAccess(ActiveRecord $ProjectUpdate, $suppressLogin = false)
+    public static function checkWriteAccess(ActiveRecord $ProjectUpdate = null, $suppressLogin = false)
     {
         // only allow creating, editing your own, and staff editing
         if (!$ProjectUpdate->isPhantom && ($ProjectUpdate->CreatorID != $GLOBALS['Session']->PersonID) && !$GLOBALS['Session']->hasAccountLevel('Staff')) {
diff --git a/php-classes/Laddr/ProjectUpdatesRequestHandler.php b/php-classes/Laddr/ProjectUpdatesRequestHandler.php
@@ -19,7 +19,7 @@ public static function handleBrowseRequest($options = [], $conditions = [], $res
         return parent::handleBrowseRequest($options, $conditions, $responseID, $responseData);
     }
 
-    public static function checkWriteAccess(\ActiveRecord $ProjectUpdate, $suppressLogin = false)
+    public static function checkWriteAccess(\ActiveRecord $ProjectUpdate = null, $suppressLogin = false)
     {
         // only allow creating, editing your own, and staff editing
         if (!$ProjectUpdate->isPhantom && ($ProjectUpdate->CreatorID != $GLOBALS['Session']->PersonID) && !$GLOBALS['Session']->hasAccountLevel('Staff')) {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ protected static function onRecordSaved(ActiveRecord $Buzz, $requestData)`
`44`	`44`	`$Buzz->save();`
`45`	`45`	`}`
`46`	`46`
`47`		`- public static function checkWriteAccess(ActiveRecord $ProjectUpdate, $suppressLogin = false)`
	`47`	`+ public static function checkWriteAccess(ActiveRecord $ProjectUpdate = null, $suppressLogin = false)`
`48`	`48`	`{`
`49`	`49`	`// only allow creating, editing your own, and staff editing`
`50`	`50`	`if (!$ProjectUpdate->isPhantom && ($ProjectUpdate->CreatorID != $GLOBALS['Session']->PersonID) && !$GLOBALS['Session']->hasAccountLevel('Staff')) {`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public static function handleBrowseRequest($options = [], $conditions = [], $res`
`19`	`19`	`return parent::handleBrowseRequest($options, $conditions, $responseID, $responseData);`
`20`	`20`	`}`
`21`	`21`
`22`		`- public static function checkWriteAccess(\ActiveRecord $ProjectUpdate, $suppressLogin = false)`
	`22`	`+ public static function checkWriteAccess(\ActiveRecord $ProjectUpdate = null, $suppressLogin = false)`
`23`	`23`	`{`
`24`	`24`	`// only allow creating, editing your own, and staff editing`
`25`	`25`	`if (!$ProjectUpdate->isPhantom && ($ProjectUpdate->CreatorID != $GLOBALS['Session']->PersonID) && !$GLOBALS['Session']->hasAccountLevel('Staff')) {`