Merge pull request #310 from CodeForPhilly/308-false-matches

sposerina · web-flow · commit 21f6203b2307 · 2021-05-25T19:09:59.000-04:00
fix bad matching
diff --git a/src/server/pipeline/match_data.py b/src/server/pipeline/match_data.py
@@ -62,11 +62,11 @@ def start(connection, added_or_updated_rows, manual_matches_df):
         # Exact matches based on specified columns
         row_matches = pdp_contacts[
             (
-                ((pdp_contacts["first_name_normalized"] == row["first_name_normalized"]) &
+                (((pdp_contacts["first_name_normalized"] == row["first_name_normalized"]) &
                 (pdp_contacts["last_name_normalized"] == row["last_name_normalized"]))
                 |
                 ((pdp_contacts["first_name_normalized"] == row["last_name_normalized"]) &
-                (pdp_contacts["last_name_normalized"] == row["first_name_normalized"]))
+                (pdp_contacts["last_name_normalized"] == row["first_name_normalized"])))
                 &
                 ((pdp_contacts["email_normalized"] == row["email_normalized"]) | (pdp_contacts["mobile"] == row["mobile"]))
             )

Original file line number	Diff line number	Diff line change
`@@ -62,11 +62,11 @@ def start(connection, added_or_updated_rows, manual_matches_df):`
`62`	`62`	`# Exact matches based on specified columns`
`63`	`63`	`row_matches = pdp_contacts[`
`64`	`64`	`(`
`65`		`- ((pdp_contacts["first_name_normalized"] == row["first_name_normalized"]) &`
	`65`	`+ (((pdp_contacts["first_name_normalized"] == row["first_name_normalized"]) &`
`66`	`66`	`(pdp_contacts["last_name_normalized"] == row["last_name_normalized"]))`
`67`	`67`	`\|`
`68`	`68`	`((pdp_contacts["first_name_normalized"] == row["last_name_normalized"]) &`
`69`		`- (pdp_contacts["last_name_normalized"] == row["first_name_normalized"]))`
	`69`	`+ (pdp_contacts["last_name_normalized"] == row["first_name_normalized"])))`
`70`	`70`	`&`
`71`	`71`	`((pdp_contacts["email_normalized"] == row["email_normalized"]) \| (pdp_contacts["mobile"] == row["mobile"]))`
`72`	`72`	`)`