Skip to content

Commit 1262376

Browse files
vvi230714pwolanin
andauthored
Baseball Card and Ward leader fixes (#312)
Baseball Card name cutoff fix, Ward leader info text clean up remove unused npm commands --------- Co-authored-by: pwolanin <[email protected]>
1 parent fe0e4c3 commit 1262376

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
"dev": "vite",
99
"preview": "vite build && vite preview --port 8080",
1010
"build": "vite build",
11-
"test": "jest --testPathIgnorePatterns ./e2e",
12-
"lint": "standard --plugin html 'src/**/*.{js,vue}'",
1311
"format:check": "prettier --check src ./*.js",
1412
"format": "prettier --write src ./*.js",
1513
"serve-http": "vite preview --port 8080",

src/components/baseball-card/svg.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,11 @@ export function createFront(el, data) {
8383

8484
const nameWidth = config.cardWidth - 19;
8585
const nameHeight = config.cardHeight - 17;
86+
const nameFontSize = data.name.length < 28 ? 22 : 20;
8687
const nameText = svg.text(nameWidth, nameHeight, data.name).attr({
8788
"text-anchor": "end",
8889
fill: config.cardBorderColor,
89-
"font-size": 22,
90+
"font-size": nameFontSize,
9091
"font-family": "Arial",
9192
});
9293

src/views/ward-leader.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
<dt>Address</dt>
105105
<dd v-if="leader.address">{{ leader.address }}</dd>
106106
<dd v-else>
107-
<span class="unknown">Unknown</span>
107+
<span class="unknown">Unknown | </span>
108108
<ask-detail
109109
:thePage="feedbackPage"
110110
detail="Address"
@@ -114,21 +114,21 @@
114114
<dt>Phone</dt>
115115
<dd v-if="leader.phone">{{ leader.phone }}</dd>
116116
<dd v-else>
117-
<span class="unknown">Unknown</span>
117+
<span class="unknown">Unknown | </span>
118118
<ask-detail :thePage="feedbackPage" detail="Phone"></ask-detail>
119119
</dd>
120120

121121
<dt>Age</dt>
122122
<dd v-if="age">{{ age }}</dd>
123123
<dd v-else>
124-
<span class="unknown">Unknown</span>
124+
<span class="unknown">Unknown | </span>
125125
<ask-detail :thePage="feedbackPage" detail="Age"></ask-detail>
126126
</dd>
127127

128128
<dt>Gender</dt>
129129
<dd v-if="leader.gender">{{ leader.gender }}</dd>
130130
<dd v-else>
131-
<span class="unknown">Unknown</span>
131+
<span class="unknown">Unknown | </span>
132132
<ask-detail
133133
:thePage="feedbackPage"
134134
detail="Gender"
@@ -138,7 +138,7 @@
138138
<dt>Occupation</dt>
139139
<dd v-if="leader.occupation">{{ leader.occupation }}</dd>
140140
<dd v-else>
141-
<span class="unknown">Unknown</span>
141+
<span class="unknown">Unknown | </span>
142142
<ask-detail :thePage="feedbackPage" detail="Occupation">
143143
</ask-detail>
144144
</dd>
@@ -151,7 +151,7 @@
151151
<a :href="'mailto:' + leader.email">{{ leader.email }}</a>
152152
</dd>
153153
<dd v-else>
154-
<span class="unknown">Unknown</span>
154+
<span class="unknown">Unknown | </span>
155155
<ask-detail :thePage="feedbackPage" detail="Email"></ask-detail>
156156
</dd>
157157

0 commit comments

Comments
 (0)