slug field is disabled on edit view in admin

- add verbose name for slug
- normalize slug

Author: MikeyManoguerra

core/admin.py

@@ -4,5 +4,15 @@
 # Register your models here.
 admin.site.register(ProgramAvailability)
 admin.site.register(Program)
-admin.site.register(Service)
 admin.site.register(Site)
+
+
+class ServiceAdmin(admin.ModelAdmin):
+
+    def get_readonly_fields(self, request, obj=None):
+        # slug is set on create and unchangable afterwards
+        if obj:
+            return ('slug',)
+        return []
+
+admin.site.register(Service, ServiceAdmin)

core/migrations/0001_initial.py

@@ -55,7 +55,6 @@ class Migration(migrations.Migration):
                 ('name', models.CharField(max_length=100)),
                 ('is_closed', models.BooleanField(default=False)),
                 ('is_frozen', models.BooleanField(default=False)),
-                ('slug', models.CharField(max_length=100, unique=True)),
             ],
         ),
         migrations.CreateModel(

core/models/program.py

@@ -6,22 +6,6 @@ class Program(models.Model):
     is_closed = models.BooleanField(default=False)
     is_frozen = models.BooleanField(default=False)
     has_queue = models.BooleanField(default=True)
-    slug = models.CharField(max_length=100, unique=True)
 
     def __str__(self):
         return '%s' % (self.name)
-
-    def clean(self):
-        """
-        normalize slugs to kebab-case
-        """
-        slug = re.sub(r'[^a-zA-Z0-9\-]', '', self.slug.lower())
-        self.slug = '-'.join(slug.split())
-
-        self.is_cleaned = True
-
-    def save(self, *args, **kwargs):
-        self.full_clean()
-        super().save(*args, **kwargs)
-
-

core/models/service.py

@@ -2,13 +2,19 @@
 from core.models import Program
 import re
 
+
 class Service(models.Model):
     name = models.CharField(max_length=100)
     available = models.BooleanField(default=False)
     program = models.ForeignKey(
-        Program, related_name="services", on_delete=models.CASCADE #related name replaces "service_set" for backwards nested relationships
+        # related name replaces "service_set" for backwards nested relationships
+        Program, related_name="services", on_delete=models.CASCADE
+    )
+    slug = models.CharField(
+        max_length=100,
+        unique=True,
+        verbose_name="Concise Descriptive Identifier"
     )
-    slug = models.CharField(max_length=100, unique=True)
 
     def __str__(self):
         return '%s: %s' % (self.program, self.name)
@@ -18,17 +24,11 @@ def clean(self):
         normalize slugs to lowercase, but only when first saving
         """
 
-        # admin validation VVV
-        # https://stackoverflow.com/questions/48908102/is-it-possible-to-disable-a-field-in-django-admin
-
-
-        # TODO:
-        # only service has slug
-        #  make name unique by program here
-        # automatically generate slug from program name and service name
-        #  make editable false on model
+        if self.pk:
+            self.is_cleaned = True
+            return
 
-        slug = re.sub(r'[^a-zA-Z0-9\-]', '', self.slug.lower())
+        slug = re.sub(r'[^a-zA-Z0-9\-\s]', '', self.slug.lower())
         self.slug = '-'.join(slug.split())
 
         self.is_cleaned = True