Skip to content

Commit 8a1c2dc

Browse files
authored
Merge pull request #220 from CodeForPhilly/clean-up-js-dependencies
Clean up JS dependencies
2 parents 419109a + 15b2b23 commit 8a1c2dc

File tree

16 files changed

+20
-15808
lines changed

16 files changed

+20
-15808
lines changed

.gitignore

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,9 @@ db.sqlite3
9595
/.cache
9696
/dist
9797

98-
# dependencies
98+
# Javascript
9999
frontend/node_modules/
100+
node_modules
100101
frontend/.pnp
101102
.pnp.js
102103

@@ -116,4 +117,4 @@ npm-debug.log*
116117
yarn-debug.log*
117118
yarn-error.log*
118119

119-
/notes.txt
120+
/notes.txt

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ Currently, they are storing data from their programs in separate Excel spreadshe
88

99
This project would work to migrate all of the disparate data sources into one system, make a UI that allows Prevention Point to access all participant data in one system, and increase the ease with which program coordinators can evaluate and monitor activities.
1010

11-
## Before Contributing:
11+
## Before Contributing:
1212

13-
* Read through the [Wiki](https://github.com/CodeForPhilly/prevention-point/wiki).
13+
* Read through the [Wiki](https://github.com/CodeForPhilly/prevention-point/wiki).
1414
* Familiarize yourself with the agreed upon project [change management practices](https://github.com/CodeForPhilly/prevention-point/wiki/Change-Management-Practices).
1515

1616
## [Code of Conduct](https://codeforphilly.org/pages/code_of_conduct/)
@@ -66,6 +66,8 @@ $ docker-compose down
6666
- Run `yarn` to install dependencies
6767
- Run `yarn dev` and navigate to `localhost:1234`
6868

69+
For more information on the front-end please see the [front-end README](./frontend/readme)
70+
6971
Other tools
7072
## Links
7173
[Wiki](https://github.com/CodeForPhilly/prevention-point/wiki)

frontend/README.md

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,26 @@
11
# Prevention Point URS Frontend
2+
23
The frontend app for the Prevention Point Unified Reporting System (URS) project.
34

45
## Project Frameworks and Tools
5-
- Main Framework: [React](https://reactjs.org/)
6-
- UI Framework: [Material UI](https://material-ui.com/)
7-
- Styling: [Sass](https://sass-lang.com/)
8-
- Bundler: [Parcel](https://parceljs.org/)
9-
- Package manager: [Yarn](https://yarnpkg.com/)
6+
7+
- Main Framework: [React](https://reactjs.org/)
8+
- UI Framework: [Material UI](https://material-ui.com/)
9+
- Styling: [Sass](https://sass-lang.com/)
10+
- Bundler: [Parcel](https://parceljs.org/)
11+
- Package manager: [Yarn](https://yarnpkg.com/)
1012

1113
## Project Style Conventions:
14+
1215
### Javascript
16+
1317
- Javascript styling / formatting is enforced by [ESLint](https://eslint.org/) and [Prettier](https://prettier.io/)
1418
- configure ESLint settings in .eslintrc.json
1519
- configure Prettier settings in .prettierrc.json
1620
- The project uses [Husky](https://github.com/typicode/husky) to run a precommit hook to lint files before they are commited. If there are any files ESlint and/or Prettier can't fix automatically, they'll fail to commit and an error log will be displayed
1721

1822
### SCSS
23+
1924
- When possible, try to rely onn Material UI component APIs for styling
2025
- SCSS styling enforced by [stylelint](https://stylelint.io/)
21-
- When writing SCSS, try to adhear to [BEM conventions](http://getbem.com/)
26+
- When writing SCSS, try to adhere to [BEM conventions](http://getbem.com/)

0 commit comments

Comments
 (0)