Chore/#155114660 - Make e2e tests more stable (#171)

* chore(e2e): add more waitForElement's

* chore(yarn): update yarn.lock

Author: timdavish

e2e/step_definitions/steps.js

@@ -3,16 +3,14 @@ const { Given, Then, When } = require('cucumber')
 
 Given(/^I am logged out$/, async () => {
   const header = client.page.header()
-  await client.pause(250)
-  await header.expect.element('@loginButton').to.be.visible
-  await header.expect.element('@signupButton').to.be.visible
+  await header.waitForElementVisible('@loginButton', 2500)
+  await header.waitForElementVisible('@signupButton', 2500)
 })
 
 Given(/^I am logged in$/, async () => {
   const header = client.page.header()
-  await client.pause(250)
-  await header.expect.element('@loginButton').to.not.be.present
-  await header.expect.element('@signupButton').to.not.be.present
+  await header.waitForElementNotPresent('@loginButton', 2500)
+  await header.waitForElementNotPresent('@signupButton', 2500)
 })
 
 Given(/^I open the "(.*)" page$/, async selector => {
@@ -22,7 +20,7 @@ Given(/^I open the "(.*)" page$/, async selector => {
 
 Then(/^I am on the "(.*)" page$/, async selector => {
   const page = client.page[selector]()
-  await page.waitForElementVisible('@body', 1000)
+  await page.waitForElementVisible('@body', 2500)
   await client.assert.urlEquals(page.url)
 })
 
@@ -52,11 +50,13 @@ When(/^I apply to a project with the project details (.*?)$/, async name => {
 })
 
 Then(/^I do not see the project with the project details (.*?)$/, async name => {
-  const createProject = client.page.createProject()
-  await createProject.expect.element('@body').text.to.not.contain(name)
+  const profile = client.page.profile()
+  await profile.waitForElementPresent('@body', 2500)
+  await profile.expect.element('@body').text.to.not.contain(name)
 })
 
 Then(/^I see the project with the project details (.*?)$/, async name => {
-  const createProject = client.page.createProject()
-  await createProject.expect.element('@body').text.to.contain(name)
+  const profile = client.page.profile()
+  await profile.waitForElementPresent('@body', 2500)
+  await profile.expect.element('@body').text.to.contain(name)
 })

yarn.lock

@@ -3338,14 +3338,14 @@ eslint-plugin-import@^2.7.0:
     minimatch "^3.0.3"
     read-pkg-up "^2.0.0"
 
-eslint-plugin-node@^5.2.0:
-  version "5.2.1"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-node/-/eslint-plugin-node-5.2.1.tgz#80df3253c4d7901045ec87fa660a284e32bdca29"
+eslint-plugin-node@^6.0.0:
+  version "6.0.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-node/-/eslint-plugin-node-6.0.0.tgz#5ad5ee6b5346aec6cc9cde0b8619caed2c6d8f25"
   dependencies:
     ignore "^3.3.6"
     minimatch "^3.0.4"
     resolve "^1.3.3"
-    semver "5.3.0"
+    semver "^5.4.1"
 
 eslint-plugin-promise@^3.5.0:
   version "3.6.0"
@@ -8329,14 +8329,14 @@ semver-diff@^2.0.0:
   version "5.5.0"
   resolved "https://registry.yarnpkg.com/semver/-/semver-5.5.0.tgz#dc4bbc7a6ca9d916dee5d43516f0092b58f7b8ab"
 
-[email protected], semver@~5.3.0:
-  version "5.3.0"
-  resolved "https://registry.yarnpkg.com/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f"
-
 semver@~5.0.1:
   version "5.0.3"
   resolved "https://registry.yarnpkg.com/semver/-/semver-5.0.3.tgz#77466de589cd5d3c95f138aa78bc569a3cb5d27a"
 
+semver@~5.3.0:
+  version "5.3.0"
+  resolved "https://registry.yarnpkg.com/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f"
+
 [email protected]:
   version "0.15.2"
   resolved "https://registry.yarnpkg.com/send/-/send-0.15.2.tgz#f91fab4403bcf87e716f70ceb5db2f578bdc17d6"