fix: default contentEncodings and contentTypes to constants

closes #373

Author: brett-vendia

src/configure.js

@@ -6,9 +6,7 @@ const { getEventSourceNameBasedOnEvent } = require('./event-sources/utils')
 const { getFramework } = require('./frameworks')
 const makeResolver = require('./make-resolver')
 const { forwardRequestToNodeServer, respondToEventSourceWithError } = require('./transport')
-
-const DEFAULT_BINARY_ENCODINGS = ['gzip', 'deflate', 'br']
-const DEFAULT_BINARY_CONTENT_TYPES = ['image/*']
+const { DEFAULT_BINARY_ENCODINGS, DEFAULT_BINARY_CONTENT_TYPES } = require('./constants')
 
 function getDefaultBinarySettings (deprecatedBinaryMimeTypes) {
   return {

src/constants.js

@@ -0,0 +1,2 @@
+module.exports.DEFAULT_BINARY_ENCODINGS = ['gzip', 'deflate', 'br']
+module.exports.DEFAULT_BINARY_CONTENT_TYPES = ['image/*']

src/index.js

@@ -25,11 +25,14 @@ function createServer (app, serverListenCallback, binaryMimeTypes) {
 }
 
 function proxy (configureOptions, event, context, resolutionMode, callback) {
+  console.warn('[DEPRECATION NOTICE] You\'re using the deprecated proxy method that will be removed in the next major version. See https://github.com/vendia/serverless-express/blob/mainline/UPGRADE.md to upgrade.')
+
   const se = configure({
     ...configureOptions,
     resolutionMode
   })
   return se(event, context, callback)
 }
+
 module.exports.createServer = createServer
 module.exports.proxy = proxy

src/is-binary.js

@@ -1,4 +1,5 @@
 // ATTRIBUTION: https://github.com/dougmoscrop/serverless-http
+const { DEFAULT_BINARY_ENCODINGS, DEFAULT_BINARY_CONTENT_TYPES } = require('./constants')
 
 function isContentEncodingBinary ({ headers, binaryEncodingTypes }) {
   const contentEncoding = headers['content-encoding']
@@ -37,6 +38,9 @@ module.exports = function isBinary ({ headers, binarySettings }) {
     return binarySettings.isBinary({ headers })
   }
 
-  return isContentEncodingBinary({ headers, binaryEncodingTypes: binarySettings.contentEncodings }) ||
-    isContentTypeBinary({ headers, binaryContentTypes: binarySettings.contentTypes })
+  const binaryEncodingTypes = binarySettings.contentEncodings || DEFAULT_BINARY_ENCODINGS
+  const binaryContentTypes = binarySettings.contentTypes || DEFAULT_BINARY_CONTENT_TYPES
+
+  return isContentEncodingBinary({ headers, binaryEncodingTypes }) ||
+    isContentTypeBinary({ headers, binaryContentTypes })
 }