Skip to content
This repository was archived by the owner on Jul 2, 2022. It is now read-only.

Commit 32f5490

Browse files
committed
2.3.1-RC12.3.1-RC1
1 parent f53f08a commit 32f5490

30 files changed

+89
-44
lines changed

CodeHub.Core/Factories/LoginFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public LoginFactory(IAccountsService accounts)
1818

1919
public async Task<LoginData> LoginWithToken(string clientId, string clientSecret, string code, string redirect, string requestDomain, string apiDomain, GitHubAccount account)
2020
{
21-
var token = await Task.Run(() => Client.RequestAccessToken(clientId, clientSecret, code, redirect, requestDomain));
21+
var token = await Client.RequestAccessToken(clientId, clientSecret, code, redirect, requestDomain);
2222
var client = Client.BasicOAuth(token.AccessToken, apiDomain);
2323
var info = await client.ExecuteAsync(client.AuthenticatedUser.GetInfo());
2424
var username = info.Data.Login;

CodeHub.Core/ViewModels/Accounts/AccountsViewModel.cs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,9 @@ protected async override void SelectAccount(IAccount account)
6262
else
6363
ShowViewModel<LoginViewModel>(LoginViewModel.NavObject.CreateDontRemember(githubAccount));
6464
}
65-
catch (TaskCanceledException)
66-
{
67-
DisplayAlert("Timeout waiting for a response from GitHub! Please try again.");
68-
}
69-
catch (WebException)
70-
{
71-
DisplayAlert("Unable to communicate with GitHub. Please check your connection and try again.");
72-
}
7365
catch (Exception e)
7466
{
75-
ReportException(e);
67+
DisplayAlert(e.Message);
7668
}
7769
finally
7870
{

CodeHub.Core/ViewModels/App/StartupViewModel.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ protected async override void Startup()
7272
}
7373
catch (Exception e)
7474
{
75-
if (!(e is TaskCanceledException))
76-
ReportException(e);
75+
DisplayAlert(e.Message);
7776
ShowViewModel<Accounts.AccountsViewModel>();
7877
}
7978
finally

CodeHub.Core/ViewModels/LoadableViewModel.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ protected override async Task ExecuteLoadResource(bool forceCacheInvalidation)
1212
{
1313
await base.ExecuteLoadResource(forceCacheInvalidation);
1414
}
15+
catch (System.IO.IOException)
16+
{
17+
DisplayAlert("Unable to communicate with GitHub as the transmission was interrupted! Please try again.");
18+
}
1519
catch (StatusCodeException e)
1620
{
1721
DisplayAlert(e.Message);

CodeHub.iOS/CodeHub.iOS.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@
9292
<MtouchI18n>
9393
</MtouchI18n>
9494
<MtouchArch>ARMv7</MtouchArch>
95-
<MtouchUseLlvm>true</MtouchUseLlvm>
9695
<MtouchUseThumb>true</MtouchUseThumb>
9796
<CodesignProvision>Automatic:AdHoc</CodesignProvision>
9897
<CodesignEntitlements>Entitlements.plist</CodesignEntitlements>

CodeHub.iOS/Info.plist

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,22 +21,22 @@
2121
<key>CFBundleIdentifier</key>
2222
<string>com.dillonbuchanan.codehub</string>
2323
<key>CFBundleShortVersionString</key>
24-
<string>2.3.0</string>
24+
<string>2.3.1</string>
2525
<key>CFBundleIconFiles</key>
2626
<array>
27+
<string>Icon-60@2x</string>
28+
<string>Icon-72</string>
29+
<string>Icon</string>
30+
<string>Icon@2x</string>
31+
<string>Icon-Small-40@2x</string>
32+
<string>Icon-Small-40</string>
2733
<string>Icon-Small-50</string>
34+
<string>Icon-Small@2x</string>
2835
<string>Icon-Small-50@2x</string>
2936
<string>Icon-Small</string>
30-
<string>Icon-Small@2x</string>
31-
<string>Icon</string>
32-
<string>Icon@2x</string>
33-
<string>Icon-72</string>
37+
<string>Icon-76@2x</string>
3438
<string>Icon-72@2x</string>
35-
<string>Icon-60@2x</string>
3639
<string>Icon-76</string>
37-
<string>Icon-76@2x</string>
38-
<string>Icon-Small-40</string>
39-
<string>Icon-Small-40@2x</string>
4040
</array>
4141
<key>UIStatusBarTintParameters</key>
4242
<dict>
@@ -68,6 +68,6 @@
6868
</dict>
6969
</array>
7070
<key>CFBundleVersion</key>
71-
<string>4</string>
71+
<string>2.3.1</string>
7272
</dict>
7373
</plist>
-3.8 KB
Loading

CodeHub.iOS/Resources/Icon-72.png

100755100644
-19.4 KB
Loading

CodeHub.iOS/Resources/[email protected]

100755100644
-23.3 KB
Loading

CodeHub.iOS/Resources/Icon-76.png

-1.15 KB
Loading

0 commit comments

Comments
 (0)