Skip to content

Commit b98b92e

Browse files
authored
[build_defs.bzl]: tests: disable implicit-int warning (KhronosGroup#6337)
Also reformat to satisfy Google-internal formatting checker
1 parent 5b6d1ff commit b98b92e

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

build_defs.bzl

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ TEST_COPTS = COMMON_COPTS + [
3838
"-Wno-self-assign",
3939
"-Wno-shadow",
4040
"-Wno-unused-parameter",
41+
# Work around looseness in protobuf parse table generated code
42+
"-Wno-implicit-int-conversion",
4143
],
4244
})
4345

@@ -59,7 +61,7 @@ def _merge_dicts(dicts):
5961
return merged
6062

6163

62-
def ExtInst(name, target = "", prefix =""):
64+
def ExtInst(name, target = "", prefix = ""):
6365
"""
6466
Returns a dictionary specifying the info needed to
6567
process an extended instruction set.
@@ -74,22 +76,21 @@ def ExtInst(name, target = "", prefix =""):
7476
Returns a dictionary with keys 'name', 'target', 'prefix' and the
7577
corresponding values.
7678
"""
77-
return {'name':name, 'target':target, 'prefix':prefix}
79+
return {"name": name, "target": target, "prefix": prefix}
7880

7981

8082
def _extinst_grammar_target(e):
8183
"""
8284
Args: e, as returned from extinst
8385
Returns the SPIRV-Headers target for the given extended instruction set spec.
8486
"""
85-
target = e['target']
86-
name = e['name']
87+
target = e["target"]
88+
name = e["name"]
8789
if len(target) > 0:
8890
return "@spirv_headers//:{}".format(target)
8991
name_part = name.replace("-", "_").replace(".", "_")
9092
return "@spirv_headers//:spirv_ext_inst_{}_grammar_unified1".format(name_part)
9193

92-
9394
def create_grammar_tables_target(name, extinsts):
9495
"""
9596
Creates a ":gen_compressed_tables" target for SPIR-V instruction
@@ -109,7 +110,7 @@ def create_grammar_tables_target(name, extinsts):
109110
)
110111
extinst_args = []
111112
for e in extinsts:
112-
extinst_args.append('--extinst={},$(location {})'.format(e['prefix'],_extinst_grammar_target(e)))
113+
extinst_args.append("--extinst={},$(location {})".format(e["prefix"], _extinst_grammar_target(e)))
113114

114115
cmd = (
115116
"$(location :ggt)" +

0 commit comments

Comments
 (0)