ci: Pull Request workflow. (#9)

* ci: Pull Request workflow.

      - build
      - test
      - clippy
      - fmt

* lint: Use try_for_each.
* Add windows release target.
* target: Disable auto_table_width on Windows.

      This ascii_table feature depends on termion, which does
      not support windows.

Author: CodeMan99

.github/workflows/pull_request.yml

@@ -0,0 +1,48 @@
+on:
+  push:
+    branches:
+      main
+  pull_request:
+    branches:
+      main
+  workflow_dispatch:
+
+jobs:
+  build-test-lint-and-fmt:
+    name: "Build and Test"
+    runs-on: ${{ matrix.config.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        config:
+          - os: ubuntu-latest
+            rust_target: x86_64-unknown-linux-gnu
+          - os: macos-latest
+            rust_target: aarch64-apple-darwin
+          - os: windows-latest
+            rust_target: x86_64-pc-windows-msvc
+    steps:
+      - uses: actions/checkout@v3
+      - name: Setup Rust
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          targets: ${{ matrix.config.rust_target }}
+      - uses: Swatinem/rust-cache@v2
+        with:
+          key: ${{ matrix.config.rust_target }}
+      - name: Build
+        run: cargo build --tests
+      - name: Test
+        run: cargo test
+      - name: Clippy
+        # Use bash to support backslash newline escapes.
+        shell: bash
+        run: |
+          cargo clippy -- \
+            --no-deps \
+            -D warnings \
+            -W clippy::unwrap_used \
+            -W clippy::expect_used \
+            -A clippy::result_large_err
+      - name: Format Check
+        run: cargo fmt -- --check --verbose

.github/workflows/release.yml

@@ -4,14 +4,13 @@ on:
   push:
     tags:
       - "v*.*.*"
-  workflow_dispatch:
 
 permissions:
   contents: write
 
 jobs:
-  build:
-    name: Building for ${{ matrix.config.os }}
+  build-and-release:
+    name: Building for ${{ matrix.config.os }} and Release
     runs-on: ${{ matrix.config.os }}
 
     strategy:
@@ -27,9 +26,9 @@ jobs:
           - os: macos-latest
             rust_target: aarch64-apple-darwin
             ext: ""
-          # - os: windows-latest
-          #   rust_target: x86_64-pc-windows-msvc
-          #   ext: ".exe"
+          - os: windows-latest
+            rust_target: x86_64-pc-windows-msvc
+            ext: ".exe"
 
     steps:
       - uses: actions/checkout@v3

Cargo.lock

@@ -17,10 +17,9 @@ bin-dir = "{ name }-{ version }-{ target }/{ bin }{ binary-ext }"
 pkg-fmt = "tgz"
 
 [dependencies]
-ascii_table = { version = "4.0.3", features = ["auto_table_width"] }
 clap = { version = "4.4.6", features = ["derive", "wrap_help"] }
-clap-verbosity-flag = "2.1.0"
 clap_complete = { version = "4.4.4", optional = true }
+clap-verbosity-flag = "2.1.0"
 dirs = "5.0.1"
 env_logger = "0.10.1"
 human_format = "1.0.3"
@@ -34,6 +33,12 @@ serde_json = { version = "1.0.107", features = ["preserve_order"] }
 serde_jsonc = { version = "1.0.107", features = ["preserve_order"] }
 tar = "0.4.40"
 
+[target.'cfg(windows)'.dependencies]
+ascii_table = "4.0.3"
+
+[target.'cfg(unix)'.dependencies]
+ascii_table = { version = "4.0.3", features = ["auto_table_width"] }
+
 [features]
 default = ["completions"]
 completions = ["dep:clap_complete"]

Cargo.toml

@@ -66,18 +66,16 @@ impl Display for LifecycleHook {
             LifecycleHook::Single(value) => write!(f, "{value}"),
             LifecycleHook::Multiple(values) => write!(f, "{}", values.join(", ")),
             LifecycleHook::Named(values) => {
-                values.iter().enumerate().fold(Ok(()), |r, (index, (key, value))| {
-                    r.and_then(|_| {
-                        let join = if index == 0 { "" } else { "; " };
-                        match value.as_ref() {
-                            LifecycleHook::Single(v) => write!(f, "{join}{key}={v}"),
-                            LifecycleHook::Multiple(vs) => {
-                                write!(f, "{join}{key}={}", vs.join(", "))
-                            },
-                            // Only a single level of nesting makes sense.
-                            LifecycleHook::Named(_) => Err(fmt::Error),
-                        }
-                    })
+                values.iter().enumerate().try_for_each(|(index, (key, value))| {
+                    let join = if index == 0 { "" } else { "; " };
+                    match value.as_ref() {
+                        LifecycleHook::Single(v) => write!(f, "{join}{key}={v}"),
+                        LifecycleHook::Multiple(vs) => {
+                            write!(f, "{join}{key}={}", vs.join(", "))
+                        },
+                        // Only a single level of nesting makes sense.
+                        LifecycleHook::Named(_) => Err(fmt::Error),
+                    }
                 })
             },
         }