Merge pull request #475 from CodeNow/client-with-retries

moved retry logic to client

Author: anandkumarpatel

lib/models/apis/runnable.js

@@ -70,33 +70,7 @@ Runnable.prototype.redeployInstance = function (instance, opts, cb) {
     opts = {};
   }
   var instanceModel = this.newInstance(instance.shortHash);
-  var retries = 0;
-  var maxRetries = 15;
-  redeploy();
-  function redeploy () {
-    instanceModel.redeploy(opts, function (err) {
-      if (err) {
-        if (err.output.statusCode === 409 && opts.json.build) {
-          // only attempt retries if buildId is provided
-          setTimeout(function () {
-            attemptRetry(err);
-          }, 500);
-          return;
-        }
-        cb(err); // real error
-      }
-      else {
-        cb.apply(this, arguments);
-      }
-    });
-  }
-  function attemptRetry (err) {
-    if (retries > maxRetries) {
-      return cb(err);
-    }
-    retries++;
-    return redeploy();
-  }
+  instanceModel.redeploy(opts, cb);
 };
 
 

package.json

@@ -69,7 +69,7 @@
     "request": "2.42.0",
     "rimraf": "^2.2.8",
     "rollbar": "^0.3.13",
-    "runnable": "git+ssh://[email protected]:CodeNow/runnable-api-client#v0.38.4",
+    "runnable": "git+ssh://[email protected]:CodeNow/runnable-api-client#v0.38.12",
     "s3-stream-upload": "0.0.6",
     "simple-api-client": "^0.5.9",
     "substream": "0.1.1",