add process.env.ENABLE_NEW_BRANCH_BUILDS_ON_GIT_PUSH to disable

Author: podviaznikov

configs/.env

@@ -39,6 +39,7 @@ SLACK_BOT_USERNAME="runnabot"
 HIPCHAT_BOT_USERNAME="runnabot"
 ENABLE_BUILDS_ON_GIT_PUSH=false
 ENABLE_NOTIFICATIONS_ON_GIT_PUSH=false
+ENABLE_NEW_BRANCH_BUILDS_ON_GIT_PUSH=false
 POLL_MONGO_TIMEOUT="30 minutes"
 GITHUB_SCOPE="user:email,repo,repo_deployment,read:repo_hook"
 GITHUB_HOOK_SECRET="3V3RYTHINGisAW3S0ME!"

configs/.env.production

@@ -30,4 +30,5 @@ CAYLEY="http://cayley.runnable.io"
 DOCKER_IMAGE_BUILDER_CACHE="/git-cache"
 ENABLE_BUILDS_ON_GIT_PUSH=true
 ENABLE_NOTIFICATIONS_ON_GIT_PUSH=true
+ENABLE_NEW_BRANCH_BUILDS_ON_GIT_PUSH=false
 GITHUB_DEPLOY_KEYS_POOL_SIZE=100

lib/routes/actions/github.js

@@ -101,6 +101,16 @@ function parseGitHubPushData (req, res, next) {
 
 function newBranch () {
   return flow.series(
+    function (req, res, next) {
+      // our env parsing cannot parse boolean correctly atm
+      if (process.env.ENABLE_NEW_BRANCH_BUILDS_ON_GIT_PUSH !== 'true') {
+        res.status(202);
+        res.send('New branch builds are disabled for now');
+      } else {
+        next();
+      }
+    },
+
     // TODO: ask praful again about creating builds for all branches
     instances.findContextVersionsForRepo('githubPushInfo.repo'),
     mw.req().set('contextVersionIds', 'instances'),