Skip to content

Commit 214b89d

Browse files
committed
Merge branch 'compose-default-branch' of github.com:CodeNow/runnable-angular into compose-default-branch
* 'compose-default-branch' of github.com:CodeNow/runnable-angular: clean up update copy add feature flag for branch selector show branch selector only in compose tab add default branch selector
2 parents d89fbc8 + ba6ea55 commit 214b89d

File tree

6 files changed

+31
-2
lines changed

6 files changed

+31
-2
lines changed

client/assets/styles/scss/modals/modals-forms.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@
157157
// max-width on buttons
158158
> .btn,
159159
.btn-wrapped {
160+
@extend %btn-sm;
160161
display: block;
161162
font-size: 16px;
162163
max-width: 360px;

client/assets/styles/scss/views/views-new-service.scss

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,19 @@
4444
}
4545
}
4646

47+
// for branch selector
48+
.btn-wrapped {
49+
@extend %btn-md;
50+
display: flex;
51+
flex: 1 1 auto;
52+
justify-content: space-between;
53+
padding-left: 8px;
54+
55+
.icons-branch {
56+
top: 9px;
57+
}
58+
}
59+
4760
// for the nested compose test file
4861
.well > .label {
4962
margin-bottom: 0;

client/directives/components/fancySelectors/branchSelector/branchSelectorView.jade

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
fancy-select.btn-sm.white.btn-wrapped(
1+
fancy-select.white.btn-wrapped(
22
ng-disabled = "branchFetching || !state.repo.branches.models.length"
33
ng-required = "true"
44
on-update = "onBranchChange"

client/directives/components/newContainer/forms/configureNewServiceView.jade

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,16 @@ section.grid-block.vertical.modal-body(
5151
)
5252

5353
//- form for naming the environment
54-
form.grid-block.vertical.label(
54+
form.grid-block.vertical.label.label-name(
5555
name = "NCC.nameForm"
5656
ng-include = "'nameNewServiceView'"
5757
)
58+
59+
//- default branch selector
60+
label.grid-block.vertical.label(
61+
ng-if = "NCC.state.dockerFileTab === 'compose' && $root.featureFlags.composeDefaultBranch"
62+
ng-include = "'defaultBranchView'"
63+
)
5864

5965
.grid-block.vertical.views-kubernetes-setup(
6066
ng-if = "NCC.state.dockerFileTab === 'kubernetes'"
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
.padding-xxs.small.label-sm Initial Branch
2+
.grid-block(
3+
auto-update = "true"
4+
branch-selector
5+
loading-promises-target = "editServerModal"
6+
state = "state"
7+
)
8+
small.padding-xxs.small Select the first branch you want to add.

client/services/featureFlagService.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ function featureFlags(
1414
autoIsolationSetup: false,
1515
backup: false,
1616
cardStatus: false,
17+
composeDefaultBranch: false,
1718
composeEditing: false,
1819
composeInstance: true,
1920
composeNav: true,

0 commit comments

Comments
 (0)