fix: prevent model selection failures when API requests fail (fixes RooCodeInc#3813, RooCodeInc#3874)

- Use Promise.allSettled instead of Promise.all to handle provider API failures gracefully
- Fix model initialization logic in ModelPicker component
- Ensures models can be selected even when some provider APIs fail

Author: indiesewell

src/core/webview/webviewMessageHandler.ts

@@ -288,14 +288,20 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
 		case "requestRouterModels":
 			const { apiConfiguration } = await provider.getState()
 
-			const [openRouterModels, requestyModels, glamaModels, unboundModels, litellmModels] = await Promise.all([
+			// Use Promise.allSettled instead of Promise.all to handle API failures gracefully
+			const results = await Promise.allSettled([
 				getModels("openrouter", apiConfiguration.openRouterApiKey),
 				getModels("requesty", apiConfiguration.requestyApiKey),
 				getModels("glama", apiConfiguration.glamaApiKey),
 				getModels("unbound", apiConfiguration.unboundApiKey),
 				getModels("litellm", apiConfiguration.litellmApiKey, apiConfiguration.litellmBaseUrl),
 			])
 
+			// Extract results, using empty objects for any failed requests
+			const [openRouterModels, requestyModels, glamaModels, unboundModels, litellmModels] = results.map(
+				(result) => (result.status === "fulfilled" ? result.value : {}),
+			)
+
 			provider.postMessageToWebview({
 				type: "routerModels",
 				routerModels: {

webview-ui/src/components/settings/ModelPicker.tsx

@@ -94,12 +94,14 @@ export const ModelPicker = ({
 	}, [])
 
 	useEffect(() => {
-		if (!selectedModelId && !isInitialized.current) {
-			const initialValue = modelIds.includes(selectedModelId) ? selectedModelId : defaultModelId
-			setApiConfigurationField(modelIdKey, initialValue)
+		if (!isInitialized.current) {
+			// If no model is selected or the selected model is not in the available models list,
+			// initialize with the default model
+			if (!selectedModelId || !modelIds.includes(selectedModelId)) {
+				setApiConfigurationField(modelIdKey, defaultModelId)
+			}
+			isInitialized.current = true
 		}
-
-		isInitialized.current = true
 	}, [modelIds, setApiConfigurationField, modelIdKey, selectedModelId, defaultModelId])
 
 	return (