- fix linter code duplications

Author: NinjaRocks

src/Parsley/Parser.cs

@@ -48,26 +48,10 @@ public Parser(ParseOptions options)
 
         public T[] Parse<T>(string[] lines, ParseOptions options) where T : IFileLine, new()
         {
-            if (options == null)
-                options = new ParseOptions();
-
-            if (lines == null || lines.Length == 0)
+            var linesToProcess = ProcessLinesArray(lines, options);
+            if (linesToProcess.Length == 0)
                 return Array.Empty<T>();
 
-            // Store original lines to work with
-            var originalLines = lines;
-
-            // Handle SkipHeaderLine option
-            if (options.SkipHeaderLine && originalLines.Length > 0)
-            {
-                originalLines = originalLines.Skip(1).ToArray();
-            }
-
-            // Determine which lines to process
-            var linesToProcess = options.IncludeEmptyLines
-                ? originalLines
-                : originalLines.Where(line => !string.IsNullOrWhiteSpace(line)).ToArray();
-
             return ProcessLines<T>(linesToProcess, options);
         }
 
@@ -254,8 +238,12 @@ private async Task<List<string>> ReadLinesFromStreamAsync(Stream stream, ParseOp
             {
                 string line;
                 int lineNumber = 0;
-                while ((line = await readLineFunc(reader)) != null)
+                
+                do
                 {
+                    line = await readLineFunc(reader);
+                    if (line == null) break;
+                    
                     // If it's the first line and we should skip header, skip it
                     if (options.SkipHeaderLine && lineNumber == 0)
                     {
@@ -273,28 +261,57 @@ private async Task<List<string>> ReadLinesFromStreamAsync(Stream stream, ParseOp
                         lines.Add(processedLine);
                     }
                     lineNumber++;
-                }
+                } while (line != null);
             }
             return lines;
         }
 
+        private string[] ProcessLinesArray(string[] lines, ParseOptions options)
+        {
+            if (options == null)
+                options = new ParseOptions();
+
+            if (lines == null || lines.Length == 0)
+                return Array.Empty<string>();
+
+            // Store original lines to work with
+            var originalLines = lines;
+
+            // Handle SkipHeaderLine option
+            if (options.SkipHeaderLine && originalLines.Length > 0)
+            {
+                originalLines = originalLines.Skip(1).ToArray();
+            }
+
+            // Determine which lines to process
+            var linesToProcess = options.IncludeEmptyLines
+                ? originalLines
+                : originalLines.Where(line => !string.IsNullOrWhiteSpace(line)).ToArray();
+
+            return linesToProcess;
+        }
+
         private List<string> ReadLinesFromStream(Stream stream, ParseOptions options, Encoding encoding)
         {
             var lines = new List<string>();
             using (var reader = new StreamReader(stream, encoding ?? Encoding.UTF8))
             {
+                var allLines = new List<string>();
                 string line;
-                int lineNumber = 0;
                 while ((line = reader.ReadLine()) != null)
+                {
+                    allLines.Add(line);
+                }
+                
+                for (int i = 0; i < allLines.Count; i++)
                 {
                     // If it's the first line and we should skip header, skip it
-                    if (options.SkipHeaderLine && lineNumber == 0)
+                    if (options.SkipHeaderLine && i == 0)
                     {
-                        lineNumber++;
                         continue;
                     }
 
-                    var processedLine = options.TrimFieldValues ? line.Trim() : line;
+                    var processedLine = options.TrimFieldValues ? allLines[i].Trim() : allLines[i];
                     if (!options.IncludeEmptyLines && string.IsNullOrWhiteSpace(processedLine))
                     {
                         // Skip empty lines if not including them
@@ -303,7 +320,6 @@ private List<string> ReadLinesFromStream(Stream stream, ParseOptions options, En
                     {
                         lines.Add(processedLine);
                     }
-                    lineNumber++;
                 }
             }
             return lines;
@@ -397,26 +413,16 @@ private List<string> ReadLinesFromStream(Stream stream, ParseOptions options, En
 
         public async Task<T[]> ParseAsync<T>(string[] lines, ParseOptions options) where T : IFileLine, new()
         {
-            if (options == null)
-                options = new ParseOptions();
-
-            if (lines == null || lines.Length == 0)
-                return Array.Empty<T>();
-
-            // Store original lines to work with
-            var originalLines = lines;
-
-            // Handle SkipHeaderLine option
-            if (options.SkipHeaderLine && originalLines.Length > 0)
+            string[] linesToProcess;
+            try 
             {
-                originalLines = originalLines.Skip(1).ToArray();
+                linesToProcess = ProcessLinesArray(lines, options);
             }
-
-            // Determine which lines to process
-            var linesToProcess = options.IncludeEmptyLines
-                ? originalLines
-                : originalLines.Where(line => !string.IsNullOrWhiteSpace(line)).ToArray();
-
+            catch
+            {
+                return Array.Empty<T>();
+            }
+            
             if (linesToProcess.Length == 0)
                 return Array.Empty<T>();