- Fix Datatime Github Issue.

NinjaRocks · NinjaRocks · commit 530aed609e0f · 2024-11-22T14:21:53.000Z
diff --git a/tests/Schemio.EntityFramework.Tests/Customer.db b/tests/Schemio.EntityFramework.Tests/Customer.db
diff --git a/tests/Schemio.EntityFramework.Tests/CustomerDbContext.cs b/tests/Schemio.EntityFramework.Tests/CustomerDbContext.cs
@@ -1,3 +1,4 @@
+using System.Globalization;
 using Microsoft.EntityFrameworkCore;
 using Schemio.Core.Helpers;
 using Schemio.EntityFramework.Tests.Domain;
@@ -54,7 +55,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                  eb.HasKey(b => b.OrderId);
                  eb.Property(b => b.OrderNo);
                  eb.Property(b => b.Date).HasColumnName("OrderDate")
-                                         .HasConversion(v => v.ToShortDateString(), s => s.IsNotNullOrEmpty() ? DateTime.ParseExact(s, "dd/MM/yyyy", null) : DateTime.MinValue);
+                                         .HasConversion(v => v.ToShortDateString(), s => s.IsNotNullOrEmpty() ? DateTime.ParseExact(s, "dd/MM/yyyy HH:mm:ss", CultureInfo.InvariantCulture) : DateTime.MinValue);
                  eb.HasOne(b => b.Customer);
                  eb.HasMany(b => b.Items);
              });
diff --git a/tests/Schemio.EntityFramework.Tests/E2E.Tests.cs b/tests/Schemio.EntityFramework.Tests/E2E.Tests.cs
@@ -47,7 +47,7 @@ public void TestDataProviderToFetchWholeEntityWhenPathsAreNull()
                 Orders = [ new Order {
                         OrderId = 1,
                         OrderNo = "ZX123VH",
-                        Date = DateTime.Parse("2021-10-22T00:00:00"),
+                        Date = DateTime.Parse("2021-10-22T12:13:04"),
                         Items =
                         [
                             new OrderItem
@@ -117,7 +117,7 @@ public void TestDataProviderToFetchEntityWhenPathsContainsOrderItems()
                     {
                         OrderId = 1,
                         OrderNo = "ZX123VH",
-                        Date = DateTime.Parse("2021-10-22T00:00:00"),
+                        Date = DateTime.Parse("2021-10-22T12:13:04"),
                         Items =
                         [
                             new OrderItem
diff --git a/tests/Schemio.SQL.Tests/Customer.db b/tests/Schemio.SQL.Tests/Customer.db
diff --git a/tests/Schemio.SQL.Tests/E2E.Tests.cs b/tests/Schemio.SQL.Tests/E2E.Tests.cs
@@ -48,7 +48,7 @@ public void TestDataProviderToFetchWholeEntityWhenPathsAreNull()
                 Orders = [ new Order {
                         OrderId = 1,
                         OrderNo = "ZX123VH",
-                        Date = DateTime.Parse("2021-10-22T00:00:00"),
+                        Date = DateTime.Parse("2021-10-22T12:13:04"),
                         Items =
                         [
                             new OrderItem
@@ -84,7 +84,7 @@ public void TestDataProviderToFetchEntityWhenPathsContainsOrderItems()
                     {
                         OrderId = 1,
                         OrderNo = "ZX123VH",
-                        Date = DateTime.Parse("2021-10-22T00:00:00"),
+                        Date = DateTime.Parse("2021-10-22T12:13:04"),
                         Items =
                         [
                             new OrderItem
diff --git a/tests/Schemio.SQL.Tests/EntitySetup/EntityConfiguration/Transforms/OrdersTransform.cs b/tests/Schemio.SQL.Tests/EntitySetup/EntityConfiguration/Transforms/OrdersTransform.cs
@@ -1,3 +1,4 @@
+using System.Globalization;
 using Schemio.Core;
 using Schemio.SQL.Tests.EntitySetup.Entities;
 using Schemio.SQL.Tests.EntitySetup.EntitySchemas.Queries;
@@ -19,7 +20,7 @@ public override void Transform(CollectionResult<OrderRecord> collectionResult, C
             {
                 customer.Orders[index] = new Order
                 {
-                    Date = DateTime.Parse(collectionResult[index].OrderDate),
+                    Date = DateTime.ParseExact(collectionResult[index].OrderDate, "dd/MM/yyyy HH:mm:ss", CultureInfo.InvariantCulture),
                     OrderId = collectionResult[index].OrderId,
                     OrderNo = collectionResult[index].OrderNo
                 };

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public void TestDataProviderToFetchWholeEntityWhenPathsAreNull()`
`47`	`47`	`Orders = [ new Order {`
`48`	`48`	`OrderId = 1,`
`49`	`49`	`OrderNo = "ZX123VH",`
`50`		`- Date = DateTime.Parse("2021-10-22T00:00:00"),`
	`50`	`+ Date = DateTime.Parse("2021-10-22T12:13:04"),`
`51`	`51`	`Items =`
`52`	`52`	`[`
`53`	`53`	`new OrderItem`
`@@ -117,7 +117,7 @@ public void TestDataProviderToFetchEntityWhenPathsContainsOrderItems()`
`117`	`117`	`{`
`118`	`118`	`OrderId = 1,`
`119`	`119`	`OrderNo = "ZX123VH",`
`120`		`- Date = DateTime.Parse("2021-10-22T00:00:00"),`
	`120`	`+ Date = DateTime.Parse("2021-10-22T12:13:04"),`
`121`	`121`	`Items =`
`122`	`122`	`[`
`123`	`123`	`new OrderItem`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public void TestDataProviderToFetchWholeEntityWhenPathsAreNull()`
`48`	`48`	`Orders = [ new Order {`
`49`	`49`	`OrderId = 1,`
`50`	`50`	`OrderNo = "ZX123VH",`
`51`		`- Date = DateTime.Parse("2021-10-22T00:00:00"),`
	`51`	`+ Date = DateTime.Parse("2021-10-22T12:13:04"),`
`52`	`52`	`Items =`
`53`	`53`	`[`
`54`	`54`	`new OrderItem`
`@@ -84,7 +84,7 @@ public void TestDataProviderToFetchEntityWhenPathsContainsOrderItems()`
`84`	`84`	`{`
`85`	`85`	`OrderId = 1,`
`86`	`86`	`OrderNo = "ZX123VH",`
`87`		`- Date = DateTime.Parse("2021-10-22T00:00:00"),`
	`87`	`+ Date = DateTime.Parse("2021-10-22T12:13:04"),`
`88`	`88`	`Items =`
`89`	`89`	`[`
`90`	`90`	`new OrderItem`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+using System.Globalization;`
`1`	`2`	`using Schemio.Core;`
`2`	`3`	`using Schemio.SQL.Tests.EntitySetup.Entities;`
`3`	`4`	`using Schemio.SQL.Tests.EntitySetup.EntitySchemas.Queries;`
`@@ -19,7 +20,7 @@ public override void Transform(CollectionResult<OrderRecord> collectionResult, C`
`19`	`20`	`{`
`20`	`21`	`customer.Orders[index] = new Order`
`21`	`22`	`{`
`22`		`- Date = DateTime.Parse(collectionResult[index].OrderDate),`
	`23`	`+ Date = DateTime.ParseExact(collectionResult[index].OrderDate, "dd/MM/yyyy HH:mm:ss", CultureInfo.InvariantCulture),`
`23`	`24`	`OrderId = collectionResult[index].OrderId,`
`24`	`25`	`OrderNo = collectionResult[index].OrderNo`
`25`	`26`	`};`