Merge pull request #324 from CodeWithDennis/add-global-configure-using-handler

Add InteractsWithServiceProviders trait and refactor table loading logic

Author: CodeWithDennis

src/Commands/FilamentTestsCommand.php

@@ -32,8 +32,6 @@ class FilamentTestsCommand extends Command
 
     protected Collection $resources;
 
-    protected bool $tableLoadingGloballyDeferred = false;
-
     use InteractsWithFilesystem;
     use InteractsWithUserInput;
 
@@ -47,7 +45,6 @@ public function handle(): void
     {
         $this->panels = $this->askUserToSelectPanels();
         $this->resources = $this->askUserToSelectResourcesFromTheSelectedPanels();
-        $this->tableLoadingGloballyDeferred = $this->askUserIfTableLoadingIsGloballyDeferred();
 
         $this->generateTests();
         $this->showGenerationSummary();

src/Concerns/Commands/InteractsWithFilesystem.php

@@ -84,7 +84,7 @@ protected function renderTestsForResource(string $resource): array
         $output = $renderers
             ->map(fn (string $renderer) =>
             /** @var BaseTest $renderer */
-            $renderer::build($resource)->tableLoadingGloballyDeferred($this->tableLoadingGloballyDeferred)->render())
+            $renderer::build($resource)->render())
             ->prepend('<?php')
             ->implode("\n\n");
 

src/Concerns/Commands/InteractsWithUserInput.php

@@ -6,7 +6,6 @@
 use Filament\Panel;
 use Illuminate\Support\Collection;
 
-use function Laravel\Prompts\confirm;
 use function Laravel\Prompts\multiselect;
 
 trait InteractsWithUserInput
@@ -65,13 +64,4 @@ protected function askUserToSelectResourcesFromTheSelectedPanels(): Collection
 
         return $selectedResources;
     }
-
-    protected function askUserIfTableLoadingIsGloballyDeferred(): bool
-    {
-        return confirm(
-            label: 'Do you globally defer table loading in your Filament app?',
-            default: false,
-            hint: 'If you set `deferLoading` individually on your resource tables, you can select "No" here.',
-        );
-    }
 }

src/Concerns/InteractsWithGlobalConfiguration.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace CodeWithDennis\FilamentTests\Concerns;
+
+use CodeWithDennis\FilamentTests\Exceptions\GlobalConfiguredUsingCouldNotBeDeterminedException;
+use Filament\Forms\Components\Field;
+use Filament\Infolists\Components\Entry;
+use Filament\Resources\Pages\ListRecords;
+use Filament\Support\Concerns\EvaluatesClosures;
+use Filament\Tables\Table;
+
+trait InteractsWithGlobalConfiguration
+{
+    use EvaluatesClosures;
+
+    public function getGloballyConfiguredUsing(string $class): object
+    {
+        return match ($class) {
+            Table::class => Table::make(app('livewire')->new(ListRecords::class)),
+            is_subclass_of($class, Entry::class, true),
+            is_subclass_of($class, Field::class, true) => $class::make('dummy-name'), // some components require a name in their constructor
+            method_exists($class, 'make') => $class::make(),
+            default => throw new GlobalConfiguredUsingCouldNotBeDeterminedException($class, 'make() method')
+        };
+    }
+}

src/Concerns/Resources/InteractsWithTables.php

@@ -2,6 +2,7 @@
 
 namespace CodeWithDennis\FilamentTests\Concerns\Resources;
 
+use CodeWithDennis\FilamentTests\Exceptions\GlobalConfiguredUsingCouldNotBeDeterminedException;
 use Filament\Actions\Action;
 use Filament\Resources\Pages\ListRecords;
 use Filament\Tables\Columns\Column;
@@ -126,7 +127,11 @@ public function getResourceTableVisibleActions(): array
 
     public function isResourceTableLoadingDeferred(): bool
     {
-        return $this->isTableLoadingGlobalyDeferred() ?: $this->getResourceTable()->isLoadingDeferred();
+        try {
+            return $this->getGloballyConfiguredUsing(\Filament\Tables\Table::class)->isLoadingDeferred();
+        } catch (GlobalConfiguredUsingCouldNotBeDeterminedException) {
+            return $this->getResourceTable()->isLoadingDeferred();
+        }
     }
 
     public function isResourceTablePaginationEnabled(): bool

src/Exceptions/GlobalConfiguredUsingCouldNotBeDeterminedException.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace CodeWithDennis\FilamentTests\Exceptions;
+
+use Exception;
+
+class GlobalConfiguredUsingCouldNotBeDeterminedException extends Exception
+{
+    public function __construct(string $class, string $method)
+    {
+        parent::__construct("Could not determine the globally configured using for {$class}::{$method}().");
+    }
+}

src/TestRenderers/BaseTest.php

@@ -4,6 +4,7 @@
 
 use CodeWithDennis\FilamentTests\Concerns\ExposesPublicMethodsToViews;
 use CodeWithDennis\FilamentTests\Concerns\HasFilamentResources;
+use CodeWithDennis\FilamentTests\Concerns\InteractsWithGlobalConfiguration;
 use CodeWithDennis\FilamentTests\Concerns\InteractsWithResources;
 use CodeWithDennis\FilamentTests\Concerns\Renderers\CanRenderViews;
 use Filament\Resources\Resource;
@@ -12,31 +13,18 @@ abstract class BaseTest implements HasFilamentResources
 {
     use CanRenderViews;
     use ExposesPublicMethodsToViews;
+    use InteractsWithGlobalConfiguration;
     use InteractsWithResources;
 
-    public bool $tableLoadingGloballyDeferred = false;
-
     public function __construct(
         public ?string $resourceClass = null,
     ) {}
 
-    public function tableLoadingGloballyDeferred(bool $tableLoadingGloballyDeferred): static
-    {
-        $this->tableLoadingGloballyDeferred = $tableLoadingGloballyDeferred;
-
-        return $this;
-    }
-
     public static function build(string $resourceClass): static
     {
         return new static($resourceClass);
     }
 
-    public function isTableLoadingGlobalyDeferred(): bool
-    {
-        return $this->tableLoadingGloballyDeferred;
-    }
-
     public function getResourceClass(): ?string
     {
         return $this->resourceClass;