BugFix: Validate and cast ids array for collections as strings

Author: CodeWithKyrian

.github/workflows/test.yml

@@ -12,7 +12,7 @@ jobs:
         php: [ 8.1, 8.2, 8.3 ]
         dependency-version: [ prefer-lowest, prefer-stable ]
 
-    name: Tests on PHP ${{ matrix.php }} - ${{ matrix.os }} - ${{ matrix.dependency-version }}
+    name: Tests on PHP ${{ matrix.php }} - ${{ matrix.dependency-version }}
 
     services:
       chroma:

composer.json

@@ -1,6 +1,7 @@
 {
   "name": "codewithkyrian/chromadb-php",
   "description": "A PHP client for the Chroma Open Source Embedding Database",
+  "keywords": ["chromadb", "php", "embedding", "database", "vectors", "semantic", "search", "chroma", "open-source"],
   "type": "library",
   "license": "MIT",
   "require": {

src/Generated/Exceptions/ChromaException.php

@@ -10,20 +10,15 @@ class ChromaException extends \Exception
 
     public static function throwSpecific(string $message, string $type, int $code)
     {
-        switch ($type) {
-            case 'NotFoundError':
-                throw new ChromaNotFoundException($message, $code);
-            case 'ValueError':
-                throw new ChromaValueException($message, $code);
-            case 'UniqueConstraintError':
-                throw new ChromaUniqueConstraintException($message, $code);
-            case 'DimensionalityError':
-                throw new ChromaDimensionalityException($message, $code);
-            case 'TypeError':
-                throw new ChromaTypeException($message, $code);
-            default:
-                throw new self($message, $code);
-        }
+        throw match ($type) {
+            'NotFoundError' => new ChromaNotFoundException($message, $code),
+            'ValueError' => new ChromaValueException($message, $code),
+            'UniqueConstraintError' => new ChromaUniqueConstraintException($message, $code),
+            'DimensionalityError' => new ChromaDimensionalityException($message, $code),
+            'InvalidCollection' => new ChromaInvalidCollectionException($message, $code),
+            'TypeError' => new ChromaTypeException($message, $code),
+            default => new self($message, $code),
+        };
     }
 
     public static function inferTypeFromMessage(string $message): string

src/Generated/Exceptions/ChromaInvalidCollectionException.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+
+namespace Codewithkyrian\ChromaDB\Generated\Exceptions;
+
+class ChromaInvalidCollectionException extends ChromaException
+{
+
+}

src/Resources/CollectionResource.php

@@ -353,7 +353,6 @@ function validate(
         bool   $requireEmbeddingsOrDocuments
     ): array
     {
-        $finalEmbeddings = [];
 
         if ($requireEmbeddingsOrDocuments) {
             if ($embeddings === null && $documents === null && $images === null) {
@@ -392,6 +391,14 @@ function validate(
             $finalEmbeddings = $embeddings;
         }
 
+        $ids = array_map(function ($id) {
+            $id = (string)$id;
+            if ($id === '') {
+                throw new \InvalidArgumentException('Expected IDs to be non-empty strings');
+            }
+            return $id;
+        }, $ids);
+
         $uniqueIds = array_unique($ids);
         if (count($uniqueIds) !== count($ids)) {
             $duplicateIds = array_filter($ids, function ($id) use ($ids) {
@@ -400,6 +407,7 @@ function validate(
             throw new \InvalidArgumentException('Expected IDs to be unique, found duplicates for: ' . implode(', ', $duplicateIds));
         }
 
+
         return [
             'ids' => $ids,
             'embeddings' => $finalEmbeddings,