Skip to content

Commit 5b819d3

Browse files
Move signing environment variables to job level
This commit refactors the GitHub Actions workflows by moving the signing key environment variables from individual build steps to the job level. This change simplifies the workflow files and reduces redundancy. The `KEY_STORE_FILE`, `KEY_STORE_PASSWORD`, `KEY_ALIAS`, and `KEY_PASSWORD` environment variables are now defined once per job, making them available to all steps within that job. This refactoring affects the following CI workflows: - `nightly-release.yml` - `android-release_ci.yml` - `android-branch_ci.yml` - `android-pr_ci.yml` - `android-main_ci.yml`
1 parent 466758d commit 5b819d3

File tree

5 files changed

+31
-21
lines changed

5 files changed

+31
-21
lines changed

.github/workflows/android-branch_ci.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@ jobs:
1313
build:
1414
name: Build, Sign & Upload
1515
runs-on: ubuntu-latest
16+
env:
17+
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
18+
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
19+
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
20+
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
21+
1622
steps:
1723
- name: Checkout project
1824
uses: actions/checkout@v6.0.1
@@ -37,10 +43,6 @@ jobs:
3743
run: ./gradlew clean assembleProdDebug --refresh-dependencies --no-daemon
3844
env:
3945
JAVA_TOOL_OPTIONS: "-Dhttps.protocols=TLSv1.2"
40-
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
41-
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
42-
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
43-
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
4446

4547
- name: Upload Artifact
4648
uses: actions/upload-artifact@v6.0.0

.github/workflows/android-main_ci.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ jobs:
1111
build:
1212
name: Build, Sign & Upload
1313
runs-on: ubuntu-latest
14+
env:
15+
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
16+
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
17+
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
18+
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
19+
1420
steps:
1521
- name: Checkout project
1622
uses: actions/checkout@v6.0.1
@@ -34,8 +40,4 @@ jobs:
3440
- name: Build with Gradle
3541
run: ./gradlew clean assembleProdDebug --refresh-dependencies --no-daemon
3642
env:
37-
JAVA_TOOL_OPTIONS: "-Dhttps.protocols=TLSv1.2"
38-
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
39-
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
40-
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
41-
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
43+
JAVA_TOOL_OPTIONS: "-Dhttps.protocols=TLSv1.2"

.github/workflows/android-pr_ci.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ jobs:
1111
build:
1212
name: Build, Sign & Upload
1313
runs-on: ubuntu-latest
14+
env:
15+
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
16+
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
17+
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
18+
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
19+
1420
steps:
1521
- name: Checkout project
1622
uses: actions/checkout@v6.0.1
@@ -35,10 +41,6 @@ jobs:
3541
run: ./gradlew clean assembleProdDebug --refresh-dependencies --no-daemon
3642
env:
3743
JAVA_TOOL_OPTIONS: "-Dhttps.protocols=TLSv1.2"
38-
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
39-
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
40-
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
41-
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
4244

4345
- name: Upload Artifact
4446
uses: actions/upload-artifact@v6.0.0

.github/workflows/android-release_ci.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ jobs:
1111
name: Build, Sign & Release
1212
if: "!startsWith(github.ref_name, 'nightly')"
1313
runs-on: ubuntu-latest
14+
env:
15+
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
16+
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
17+
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
18+
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
19+
1420
steps:
1521
- name: Checkout project
1622
uses: actions/checkout@v6.0.1
@@ -35,10 +41,6 @@ jobs:
3541
run: ./gradlew clean assembleProdRelease --refresh-dependencies --no-daemon && ./gradlew clean bundleProdRelease --refresh-dependencies --no-daemon
3642
env:
3743
JAVA_TOOL_OPTIONS: "-Dhttps.protocols=TLSv1.2"
38-
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
39-
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
40-
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
41-
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
4244

4345
- name: Release to GitHub
4446
uses: svenstaro/upload-release-action@2.11.3

.github/workflows/nightly-release.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@ jobs:
2525
build:
2626
name: Build, Sign & Release
2727
runs-on: ubuntu-latest
28+
env:
29+
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
30+
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
31+
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
32+
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
33+
2834
needs: release
2935
steps:
3036
- name: Checkout project
@@ -49,10 +55,6 @@ jobs:
4955
run: ./gradlew clean assembleNightlyRelease --refresh-dependencies --no-daemon
5056
env:
5157
JAVA_TOOL_OPTIONS: "-Dhttps.protocols=TLSv1.2"
52-
KEY_STORE_FILE: ${{ secrets.SIGNINGKEY_BASE64 }} # optional if using a file from env
53-
KEY_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
54-
KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
55-
KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
5658

5759
- name: Extract Version
5860
id: extract_version

0 commit comments

Comments
 (0)