Skip to content

Commit 385e9d0

Browse files
committed
general feedback applied to improve html structure
1 parent 330610b commit 385e9d0

File tree

1 file changed

+37
-30
lines changed

1 file changed

+37
-30
lines changed

debugging/book-library/index.html

Lines changed: 37 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<title>Library</title>
5-
<meta charset="utf-8" name="viewport" content="width=device-width, initial-scale=1.0" />
4+
<title>Book Library</title>
5+
<meta charset="utf-8" />
6+
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
67

78
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
89
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
@@ -18,42 +19,48 @@ <h1>My Book Library</h1>
1819
<p>Add books to your virtual library</p>
1920
</div>
2021

21-
<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
22-
Add new book
23-
</button>
22+
<div class="container">
2423

25-
<div id="demo" class="collapse">
26-
<div class="form-group">
27-
<label for="title">Title:</label>
28-
<input type="text" class="form-control" id="title" name="title" required />
24+
<button data-toggle="collapse" data-target="#demo" class="btn btn-info mb-3">
25+
Add new book
26+
</button>
2927

30-
<label for="author">Author: </label>
31-
<input type="text" class="form-control" id="author" name="author" required />
28+
<div id="demo" class="collapse mb-4">
29+
<div class="form-group">
3230

33-
<label for="pages">Pages:</label>
34-
<input type="number" class="form-control" id="pages" name="pages" required />
31+
<label for="title">Title:</label>
32+
<input type="text" class="form-control" id="title" placeholder="Enter book title" required />
3533

36-
<label class="form-check-label mt-2">
37-
<input type="checkbox" class="form-check-input" id="check" /> Read
38-
</label>
34+
<label for="author" class="mt-2">Author:</label>
35+
<input type="text" class="form-control" id="author" placeholder="Enter the author" required />
3936

40-
<button type="button" class="btn btn-primary mt-3" id="submitBtn">Submit</button>
37+
<label for="pages" class="mt-2">Pages:</label>
38+
<input type="number" class="form-control" id="pages" placeholder="e.g. 350" required />
39+
40+
<label class="form-check-label mt-2">
41+
<input type="checkbox" class="form-check-input" id="check" /> Read
42+
</label>
43+
44+
<button type="button" class="btn btn-primary mt-3" id="submitBtn">Submit</button>
45+
</div>
4146
</div>
42-
</div>
4347

44-
<table class="table" id="display">
45-
<thead class="thead-dark">
46-
<tr>
47-
<th>Title</th>
48-
<th>Author</th>
49-
<th>Number of Pages</th>
50-
<th>Read</th>
51-
<th></th>
52-
</tr>
53-
</thead>
54-
<tbody></tbody>
55-
</table>
48+
<table class="table" id="display">
49+
<thead class="thead-dark">
50+
<tr>
51+
<th>Title</th>
52+
<th>Author</th>
53+
<th>Number of Pages</th>
54+
<th>Read</th>
55+
<th></th>
56+
</tr>
57+
</thead>
58+
<tbody></tbody>
59+
</table>
60+
61+
</div>
5662

63+
<!-- JS File -->
5764
<script src="script.js"></script>
5865
</body>
5966
</html>

0 commit comments

Comments
 (0)